From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 06A42A0613 for ; Wed, 28 Aug 2019 15:53:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E3E121C219; Wed, 28 Aug 2019 15:53:08 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id F060129CB for ; Wed, 28 Aug 2019 15:53:06 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5A2DD87642; Wed, 28 Aug 2019 13:53:06 +0000 (UTC) Received: from dhcp-25.97.bos.redhat.com (unknown [10.18.25.8]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BC8EB5C220; Wed, 28 Aug 2019 13:53:05 +0000 (UTC) From: Aaron Conole To: Christian Ehrhardt Cc: dev , Kevin Laatz , Luca Boccassi , Thomas Monjalon References: <20190828122752.27887-1-christian.ehrhardt@canonical.com> Date: Wed, 28 Aug 2019 09:53:04 -0400 In-Reply-To: <20190828122752.27887-1-christian.ehrhardt@canonical.com> (Christian Ehrhardt's message of "Wed, 28 Aug 2019 14:27:52 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Wed, 28 Aug 2019 13:53:06 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH] build: avoid --as-needed as it causes overlinking X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Christian Ehrhardt writes: > A while ago telemetry was added in 57ae0ec6 and it also added as-needed > to config/meson.build. This seems no more needed these days as due to other > build changes the ordering in buildlogs is: > [...] -lrte_telemetry [...] -Wl,--no-as-needed [...] > Which means telemetry no more benefits from --no-as-needed anyway. > > Overlinking problems get triggered by the meson generated pkgconfig which > will have: > [...] -Wl,--no-as-needed > This will overlink and in addition anything that follows > as it also doesn't wrap back to --as-needed. So if a projects includes > dpdk libs + it will also consider with --no-as-needed. > > Fixes: https://bugs.launchpad.net/ubuntu/+source/dpdk/+bug/1841759 > > Signed-off-by: Christian Ehrhardt > --- Hi Christian, I agree this is something to be fixed. It will need additional work, though: https://travis-ci.com/ovsrobot/dpdk/builds/124909245 The unit tests are failing with this patch. > config/meson.build | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/config/meson.build b/config/meson.build > index 2bafea530..58800a980 100644 > --- a/config/meson.build > +++ b/config/meson.build > @@ -93,9 +93,6 @@ dpdk_conf.set('RTE_TOOLCHAIN_' + toolchain.to_upper(), 1) > > dpdk_conf.set('RTE_ARCH_64', cc.sizeof('void *') == 8) > > -add_project_link_arguments('-Wl,--no-as-needed', language: 'c') > -dpdk_extra_ldflags += '-Wl,--no-as-needed' > - > # use pthreads > add_project_link_arguments('-pthread', language: 'c') > dpdk_extra_ldflags += '-pthread'