From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <aconole@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id A2D79293B
 for <dev@dpdk.org>; Tue,  4 Apr 2017 15:39:55 +0200 (CEST)
Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com
 [10.5.11.12])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id B21AD3D97C;
 Tue,  4 Apr 2017 13:39:54 +0000 (UTC)
DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com B21AD3D97C
Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com;
 dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com;
 spf=pass smtp.mailfrom=aconole@redhat.com
DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com B21AD3D97C
Received: from dhcp-25-97.bos.redhat.com (unknown [10.18.25.172])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id 356B39FFE0;
 Tue,  4 Apr 2017 13:39:54 +0000 (UTC)
From: Aaron Conole <aconole@redhat.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
References: <20170331183122.22961-1-aconole@redhat.com>
 <2833575.ok4SoAkeVM@xps13>
Date: Tue, 04 Apr 2017 09:39:53 -0400
In-Reply-To: <2833575.ok4SoAkeVM@xps13> (Thomas Monjalon's message of "Tue, 04
 Apr 2017 15:26:47 +0200")
Message-ID: <f7td1cs70ly.fsf@redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.30]); Tue, 04 Apr 2017 13:39:54 +0000 (UTC)
Subject: Re: [dpdk-dev] [PATCH] eal: deprecate rte_cpu_check_supported
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Apr 2017 13:39:56 -0000

Hi Thomas,

Thomas Monjalon <thomas.monjalon@6wind.com> writes:

> 2017-03-31 14:31, Aaron Conole:
>> It's likely that this function isn't used anywhere, but since it was part of
>> the public API, mark the function for deprecation for at least one release.
>> 
>> Signed-off-by: Aaron Conole <aconole@redhat.com>

Thanks so much for the review!  I'll make sure to fix these with v2.

> [...]
>> +DPDK_17.05 {
>> +	global;
>> +
>> +	rte_cpu_is_supported;
>> +
>> +} DPDK_17.02;
>
> Should not it be a separate patch?

I thought it made sense to keep it rolled in with this patch, but if you
prefer it separate, I will do that.  Expect it as 1/2 in v2, unless you
say otherwise.

-Aaron