From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5202AA04F3; Wed, 8 Jan 2020 17:05:31 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 07B5E1DA8F; Wed, 8 Jan 2020 17:05:31 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 8991F1DA8B for ; Wed, 8 Jan 2020 17:05:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578499529; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Yp1tHNGeK3C1PvOecE/UCOnWdx79X6u8Q4XXofqgV/8=; b=E6yq1za98qeJU1lCP0UI0UMDNfyJEfPm0uuBcism2HTcKJsduxyJ2jDmoTamMHk2OY2uUW yioA29igEa7iBEHnPow9wOJX0rspT3V14gUDR5Y0sz2h4qSgrTPxDLnxmKLAq1Swb9uAqb ZL2lRfCJXTA4bSLR+WNTqICquR1N7ec= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-128-EXgisGKCM0m0SFo6nJ70pg-1; Wed, 08 Jan 2020 11:05:27 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C1D551005514; Wed, 8 Jan 2020 16:05:25 +0000 (UTC) Received: from dhcp-25.97.bos.redhat.com (unknown [10.18.25.108]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CD8E06FF0F; Wed, 8 Jan 2020 16:05:21 +0000 (UTC) From: Aaron Conole To: Ruifeng Wang Cc: "maicolgabriel\@hotmail.com" , "thomas\@monjalon.net" , "ferruh.yigit\@intel.com" , "arybchenko\@solarflare.com" , "dev\@dpdk.org" , "david.marchand\@redhat.com" , Gavin Hu , Honnappa Nagarahalli , nd References: <20191218053902.193417-1-ruifeng.wang@arm.com> <20191223070833.144628-1-ruifeng.wang@arm.com> <20191223070833.144628-3-ruifeng.wang@arm.com> Date: Wed, 08 Jan 2020 11:05:21 -0500 In-Reply-To: (Ruifeng Wang's message of "Tue, 7 Jan 2020 06:24:56 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-MC-Unique: EXgisGKCM0m0SFo6nJ70pg-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v3 2/2] ci: add travis ci support for aarch64 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Ruifeng Wang writes: >> -----Original Message----- >> From: Aaron Conole >> Sent: Monday, January 6, 2020 21:34 >> To: Ruifeng Wang >> Cc: maicolgabriel@hotmail.com; thomas@monjalon.net; >> ferruh.yigit@intel.com; arybchenko@solarflare.com; dev@dpdk.org; >> david.marchand@redhat.com; Gavin Hu ; Honnappa >> Nagarahalli ; nd >> Subject: Re: [PATCH v3 2/2] ci: add travis ci support for aarch64 >>=20 >> Ruifeng Wang writes: >>=20 >> > Add Travis compilation jobs for aarch64. gcc/clang compilations for >> > static/shared libraries are added. >> > >> > Some limitations for current aarch64 Travis support: >> > 1. Container is used. Huge page is not available due to security reaso= n. >> > 2. Missing kernel header package in Xenial distribution. >> > >> > Solutions to address the limitations: >> > 1. Not to add unit test for now. And run tests with no-huge in future. >> > 2. Use Bionic distribution for all aarch64 jobs. >> > >> > Signed-off-by: Ruifeng Wang >> > Reviewed-by: Gavin Hu >> > --- >>=20 >> Can't we achieve the same thing by setting >>=20 >> arch: >> - amd64 >> - arm64 >>=20 >> in the build matrix? Or will that also force the intel builds to use th= e container >> infrastructure (in which case the no-huge support needs to be fixed)? > > No, container infrastructure will not be imposed to intel builds.=20 > AFAIN, Travis infrastructure for a specific CPU arch is provided as > is, and there is no config option to control. > The problem with just adding 'arch' in build matrix is that RUN_TESTS on = arm64 is not supported > by now (Travis limitation). 'env' with RUN_TESTS will fail. Okay I see. >>=20 >> One thing I wonder, isn't is possible to use qemu-user to do the amd64 u= nit >> tests? Then do we really need some changes to do the native build? > > Do you mean to use qemu-user to do unit tests for non-x86 arch? Yes. This has the advantage of giving users a way to also do the multi-arch checks on their own systems (so a developer with just an x86 could at least do some testing on arm or ppc). > Changes will be needed as well to enable qemu-user to do unit test. > Since Travis support multi CPU arch, I think native build and test is sim= pler and more natural.=20 I agree, some script changes might be needed, but maybe not as many as you fear (can't we use binfmt_misc infrastructure to do this with qemu-user and then the actual 'execute' would work). >> Does it buy us anything *today* given the cost of the hugepage restricti= on? >> Will that ever be resolved (I didn't see so from the docs on travis)? > > The hugepage issue has been reported to Travis. I think it will be > resolved. But no set dates yet. Is there a plan for them to address? I guess probably not. So we either need the ability for tests to run in the no-huge environment (and detect that no hugepages are available to run the tests that way), or we need the travis environment supporting hugepages. Is there something I missed? >>=20 >> > .ci/linux-setup.sh | 11 +++++++---- >> > .travis.yml | 42 +++++++++++++++++++++++++++++++++++++++++- >> > 2 files changed, 48 insertions(+), 5 deletions(-) >> > >> > diff --git a/.ci/linux-setup.sh b/.ci/linux-setup.sh index >> > dfb9d4a20..a92978037 100755 >> > --- a/.ci/linux-setup.sh >> > +++ b/.ci/linux-setup.sh >> > @@ -3,7 +3,10 @@ >> > # need to install as 'root' since some of the unit tests won't run >> > without it sudo python3 -m pip install --upgrade meson >> > >> > -# setup hugepages >> > -cat /proc/meminfo >> > -sudo sh -c 'echo 1024 > /proc/sys/vm/nr_hugepages' >> > -cat /proc/meminfo >> > +# hugepage settings are skipped on aarch64 due to environment >> > +limitation if [ "$TRAVIS_ARCH" !=3D "aarch64" ]; then >> > + # setup hugepages >> > + cat /proc/meminfo >> > + sudo sh -c 'echo 1024 > /proc/sys/vm/nr_hugepages' >> > + cat /proc/meminfo >> > +fi >> > diff --git a/.travis.yml b/.travis.yml index 8f90d06f2..980c7605d >> > 100644 >> > --- a/.travis.yml >> > +++ b/.travis.yml >> > @@ -115,6 +115,46 @@ matrix: >> > apt: >> > packages: >> > - *extra_packages >> > - >> > + - env: DEF_LIB=3D"static" >> > + arch: arm64 >> > + compiler: gcc >> > + dist: bionic >> > + addons: >> > + apt: >> > + packages: >> > + - *required_packages >> > + - env: DEF_LIB=3D"shared" >> > + arch: arm64 >> > + compiler: gcc >> > + dist: bionic >> > + addons: >> > + apt: >> > + packages: >> > + - *required_packages >> > + - env: DEF_LIB=3D"static" >> > + arch: arm64 >> > + dist: bionic >> > + compiler: clang >> > + addons: >> > + apt: >> > + packages: >> > + - *required_packages >> > + - env: DEF_LIB=3D"shared" >> > + arch: arm64 >> > + dist: bionic >> > + compiler: clang >> > + addons: >> > + apt: >> > + packages: >> > + - *required_packages >> > + - env: DEF_LIB=3D"shared" OPTS=3D"-Denable_kmods=3Dfalse" BUILD_DOC= S=3D1 >> > + arch: arm64 >> > + compiler: gcc >> > + dist: bionic >> > + addons: >> > + apt: >> > + packages: >> > + - *required_packages >> > + - *doc_packages >> > >> > script: ./.ci/${TRAVIS_OS_NAME}-build.sh