DPDK patches and discussions
 help / color / mirror / Atom feed
From: Aaron Conole <aconole@redhat.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org,  rjarry@redhat.com,
	 Michael Santana <maicolgabriel@hotmail.com>
Subject: Re: [PATCH v3] ci: add Fedora 35 container in GHA
Date: Mon, 04 Apr 2022 12:06:28 -0400	[thread overview]
Message-ID: <f7tfsms25q3.fsf@redhat.com> (raw)
In-Reply-To: <20220404142439.15299-1-david.marchand@redhat.com> (David Marchand's message of "Mon, 4 Apr 2022 16:24:39 +0200")

David Marchand <david.marchand@redhat.com> writes:

> Build DPDK with Fedora 35 containers.
>
> GHA container support does not allow caching images and docker hub
> seems to limit image pulls.
> On the other hand, the Fedora project hub does not seem to limit them,
> so prefer this hub.
> Nevertheless, let's try to be good citizens and cache (once a day) a
> prepared image for subsequent builds.
> This preparation is done in a first prepare-container-images job.
> The rpm-container-builds job then depends on it with a 'needs:' tag.
>
> Differences with builds in Ubuntu GHA vm images:
> - tasks are run as root in containers, no need for sudo,
> - compiler must be explicitly installed,
> - GHA artifacts can't contain a ':' in their name, and must be filtered,
> - environment variables are not inherited and must be passed explicitly,
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> Changes since v2:
> - used a two stage pipeline so that container image generation
>   is done only once,
> - changed image name local:dpdk to dpdk-local (closer to conventions),
>
> Changes since v1:
> - switched to Fedora project hub,
> - cached container image,
>
> ---

This is fantastic!

Acked-by: Aaron Conole <aconole@redhat.com>


  reply	other threads:[~2022-04-04 16:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-16 12:31 [PATCH] " David Marchand
2021-11-16 14:44 ` Aaron Conole
2021-11-17 17:29   ` David Marchand
2021-11-18 14:17     ` Aaron Conole
2022-04-01 18:02 ` [PATCH v2] " David Marchand
2022-04-02  8:01   ` David Marchand
2022-04-04 14:24 ` [PATCH v3] " David Marchand
2022-04-04 16:06   ` Aaron Conole [this message]
2022-04-06 18:58     ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f7tfsms25q3.fsf@redhat.com \
    --to=aconole@redhat.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=maicolgabriel@hotmail.com \
    --cc=rjarry@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).