From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EAA45A0508; Mon, 4 Apr 2022 18:06:34 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 907B441148; Mon, 4 Apr 2022 18:06:34 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 141F04068C for ; Mon, 4 Apr 2022 18:06:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649088392; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lGAlsd8KFcSVBSwc4hoC394SMGJm5B/MEX2VVe3UtuU=; b=Rk4zAyFdb1qKlvlKen6l378MUIyUpMi9WWnc8fhsH/8LiqoBRaRuMDWU3sRltPjLioCdhf 8SpqiFKKyTUGl1UxaV8JeIqrrhHgMdI/pfZv+Oih93/kVkeJNlifoOA9gXEXyA+0i3DB6N VhQlSqYQ24HaJKPnzdeO2YWxlFTOM90= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-621-e4zDBRX1PlyjgLCgfgG0cA-1; Mon, 04 Apr 2022 12:06:29 -0400 X-MC-Unique: e4zDBRX1PlyjgLCgfgG0cA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 55FF518E6C41; Mon, 4 Apr 2022 16:06:29 +0000 (UTC) Received: from RHTPC1VM0NT (unknown [10.22.17.196]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1EE1A403D187; Mon, 4 Apr 2022 16:06:29 +0000 (UTC) From: Aaron Conole To: David Marchand Cc: dev@dpdk.org, rjarry@redhat.com, Michael Santana Subject: Re: [PATCH v3] ci: add Fedora 35 container in GHA References: <20211116123102.19237-1-david.marchand@redhat.com> <20220404142439.15299-1-david.marchand@redhat.com> Date: Mon, 04 Apr 2022 12:06:28 -0400 In-Reply-To: <20220404142439.15299-1-david.marchand@redhat.com> (David Marchand's message of "Mon, 4 Apr 2022 16:24:39 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=aconole@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org David Marchand writes: > Build DPDK with Fedora 35 containers. > > GHA container support does not allow caching images and docker hub > seems to limit image pulls. > On the other hand, the Fedora project hub does not seem to limit them, > so prefer this hub. > Nevertheless, let's try to be good citizens and cache (once a day) a > prepared image for subsequent builds. > This preparation is done in a first prepare-container-images job. > The rpm-container-builds job then depends on it with a 'needs:' tag. > > Differences with builds in Ubuntu GHA vm images: > - tasks are run as root in containers, no need for sudo, > - compiler must be explicitly installed, > - GHA artifacts can't contain a ':' in their name, and must be filtered, > - environment variables are not inherited and must be passed explicitly, > > Signed-off-by: David Marchand > --- > Changes since v2: > - used a two stage pipeline so that container image generation > is done only once, > - changed image name local:dpdk to dpdk-local (closer to conventions), > > Changes since v1: > - switched to Fedora project hub, > - cached container image, > > --- This is fantastic! Acked-by: Aaron Conole