From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9CFF2A034C; Tue, 4 Jan 2022 16:28:51 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2464140042; Tue, 4 Jan 2022 16:28:51 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id C791840040 for ; Tue, 4 Jan 2022 16:28:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1641310128; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Yh1oQq6gpnXVllIqwwLTFEFhSXuvcWQwnuSJO6Pd9C8=; b=NtxCN+OX2o8JnkK64RbL4ryLJE7RwKMPFFErmMw/8H/YcAgvuCPapO+QF0kL7If/ZXDCKw o8Mhw3W3lONl5FDMrrA3WDHS+t7Mnfw4JwxguShrS0wBlMZUNlKMvZuPMsSOteSxnFvYNm um18yMWHhpXqxX0Faqvmwoqfazq5Gnc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-638-wng-6OwfPYGv2AbkZpm4rQ-1; Tue, 04 Jan 2022 10:28:44 -0500 X-MC-Unique: wng-6OwfPYGv2AbkZpm4rQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7F63D801962; Tue, 4 Jan 2022 15:28:43 +0000 (UTC) Received: from RHTPC1VM0NT (unknown [10.22.17.178]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6EE467F80D; Tue, 4 Jan 2022 15:28:42 +0000 (UTC) From: Aaron Conole To: Shijith Thotton Cc: "dpdklab@iol.unh.edu" , Anoob Joseph , Pavan Nikhilesh Bhagavatula , Akhil Goyal , "Gujjar, Abhinandan S" , Jerin Jacob Kollanukkaran , "dev@dpdk.org" Subject: Re: [PATCH v2] app/eventdev: add crypto producer mode References: <83932e16cff802f4701832c1798e31ec15b028f8.1640029478.git.sthotton@marvell.com> <5b7dadb222f6eb018c74983750052543eb5f0d8e.1640076426.git.sthotton@marvell.com> Date: Tue, 04 Jan 2022 10:28:41 -0500 In-Reply-To: (Shijith Thotton's message of "Mon, 3 Jan 2022 09:14:05 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=aconole@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Shijith Thotton writes: >>> >> >>> >> In crypto producer mode, producer core enqueues cryptodev with >>> >> software generated crypto ops and worker core dequeues crypto >>> >> completion events from the eventdev. Event crypto metadata used for >>> >> above processing is pre- populated in each crypto session. >>> >> >>> >> Parameter --prod_type_cryptodev can be used to enable crypto producer >>> >mode. >>> >> Parameter --crypto_adptr_mode can be set to select the crypto adapter >>> >> mode, >>> >0 >>> >> for OP_NEW and 1 for OP_FORWARD. >>> >> >>> >> This mode can be used to measure the performance of crypto adapter. >>> >> >>> >> Example: >>> >> ./dpdk-test-eventdev -l 0-2 -w -w -- \ >>> >> --prod_type_cryptodev --crypto_adptr_mode 1 --test=perf_atq \ >>> >> --stlist=a --wlcores 1 --plcores 2 >>> > >>> >This patch has some perf failure as shown below. Could you please look into >>> this? >>> >105300 --> performance testing fail >>> > >>> >Test environment and result as below: >>> > >>> >Ubuntu 20.04 >>> >Kernel: 4.15.0-generic >>> >Compiler: gcc 7.4 >>> >NIC: Intel Corporation Ethernet Converged Network Adapter 82599ES 10000 >>> >Mbps >>> >Target: x86_64-native-linuxapp-gcc >>> >Fail/Total: 0/4 >>> > >>> >Detail performance results: >>> >+------------+---------+----------+-------------+------------------------------+ >>> >| frame_size | txd/rxd | num_cpus | num_threads | throughput >>> >| difference from >>> >| >>> >| | | | | expected | >>> >>>+============+=========+==========+=============+============ >>= >>> >=================+ >>> >| 64 | 512 | 1 | 1 | 0.3% | >>> >+------------+---------+----------+-------------+------------------------------+ >>> >| 64 | 2048 | 1 | 1 | -0.2% | >>> >+------------+---------+----------+-------------+------------------------------+ >>> >| 64 | 512 | 1 | 2 | 0.0% | >>> >+------------+---------+----------+-------------+------------------------------+ >>> >| 64 | 2048 | 1 | 2 | 0.3% | >>> >+------------+---------+----------+-------------+------------------------------+ >>> > >>> >Ubuntu 20.04 >>> >Kernel: 4.15.0-generic >>> >Compiler: gcc 7.4 >>> >NIC: Intel Corporation Ethernet Converged Network Adapter XL710-QDA2 >>> >40000 Mbps >>> >Target: x86_64-native-linuxapp-gcc >>> >Fail/Total: 1/4 >>> > >>> >Detail performance results: >>> >+------------+---------+----------+-------------+------------------------------+ >>> >| frame_size | txd/rxd | num_cpus | num_threads | throughput >>> >| difference from >>> >| >>> >| | | | | expected | >>> >>>+============+=========+==========+=============+============ >>= >>> >=================+ >>> >| 64 | 512 | 1 | 1 | 0.2% | >>> >+------------+---------+----------+-------------+------------------------------+ >>> >| 64 | 2048 | 1 | 1 | -0.7% | >>> >+------------+---------+----------+-------------+------------------------------+ >>> >| 64 | 512 | 1 | 2 | -1.5% | >>> >+------------+---------+----------+-------------+------------------------------+ >>> >| 64 | 2048 | 1 | 2 | -5.3% | >>> >+------------+---------+----------+-------------+------------------------------+ >>> > >>> >Ubuntu 20.04 ARM >>> >Kernel: 4.15.0-132-generic >>> >Compiler: gcc 7.5 >>> >NIC: Arm Intel Corporation Ethernet Converged Network Adapter >>> >XL710-QDA2 >>> >40000 Mbps >>> >Target: x86_64-native-linuxapp-gcc >>> >Fail/Total: 0/2 >>> > >>> >Detail performance results: >>> >+------------+---------+----------+-------------+------------------------------+ >>> >| frame_size | txd/rxd | num_cpus | num_threads | throughput >>> >| difference from >>> >| >>> >| | | | | expected | >>> >>>+============+=========+==========+=============+============ >>= >>> >=================+ >>> >| 64 | 512 | 1 | 1 | 0.1% | >>> >+------------+---------+----------+-------------+------------------------------+ >>> >| 64 | 2048 | 1 | 1 | -0.5% | >>> >+------------+---------+----------+-------------+------------------------------+ >>> > >>> >To view detailed results, visit: >>> >https://urldefense.proofpoint.com/v2/url?u=https- >>> >>>3A__lab.dpdk.org_results_dashboard_patchsets_20534_&d=DwIFAg&c=nKjWe >>> c2 >>> >b6R0mOyPaz7xtfQ&r=G9w4KsPaQLACBfGCL35PtiRH996yqJDxAZwrWegU2qQ& >>> m= >>> >>>dPDgmKiLC_KqhgjwZrodyFlBdlFPgckVr9IW0c7t2cIHpkw6u9pGqgElFqqwuU1v&s >>> =E >>> >ajYUFziZY27q6LB4p5sOGuFlty3VlOjbMsLXaQ5MeI&e= >>> > >>> >>> Performance regression is reported by nic_single_core_perf, but is using >>> testpmd to measure performance. As this patch does not touch testpmd, the >>> issue could be with DPDK CI. Is it possible to re-trigger CI ? >>I have don't have option to trigger CI from my side. >>So, I have added dpdklab and Aaron to the loop. >>Please check with them. >> > > Thanks Abhinandan. > > Aaron, > From DTS, I only see testpmd being used for nic_single_core_perf test. > This patch is not touching testpmd, but still got failure for the perf test. > If possible, Please re-retrigger CI for this patch. Seems this was superseded - I am guessing no new test needs to be run for this: https://patches.dpdk.org/project/dpdk/patch/736dc424a780b9547033f76f8911342ff06d3f87.1641292088.git.sthotton@marvell.com/ Is that correct?