From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1278DA0553; Mon, 17 Feb 2020 19:48:09 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E91321DA9E; Mon, 17 Feb 2020 19:48:07 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 29F511DA9C for ; Mon, 17 Feb 2020 19:48:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581965286; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nPGDXjOm1qQnehs/V/7IIrbW1SRZtJaCtDHOeQjNUHY=; b=RSnxN256ZuN07aVrVSNY2lQDbLAkeLesy6Da8A/tHwBzAtyqb2JZ38zEYyEJ1DidfVU3mx cqD/A6KkXvlfrOBBUMU3/cGMMuY9JpcKsTMcIcjMaNmCHnIVitB1+uIeU+WKTnHjTW4v+2 hfqlabRACac8N3iYFYq1et70KsBhgqc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-39-uY99Ce_ZMRm0lF-nmXm3qw-1; Mon, 17 Feb 2020 13:47:58 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B63B113E4; Mon, 17 Feb 2020 18:47:56 +0000 (UTC) Received: from dhcp-25.97.bos.redhat.com (unknown [10.18.25.126]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 84DC75C219; Mon, 17 Feb 2020 18:47:50 +0000 (UTC) From: Aaron Conole To: David Marchand Cc: thomas@monjalon.net, dev@dpdk.org, christian.ehrhardt@canonical.com, dodji@redhat.com, Michael Santana References: <20200217135929.30987-1-david.marchand@redhat.com> Date: Mon, 17 Feb 2020 13:47:49 -0500 In-Reply-To: <20200217135929.30987-1-david.marchand@redhat.com> (David Marchand's message of "Mon, 17 Feb 2020 14:59:29 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: uY99Ce_ZMRm0lF-nmXm3qw-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] ci: build and use libabigail 1.6 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" David Marchand writes: > libabigail 1.2 (at least) reports changes in 'const' property as an ABI > breakage [1]. > This was fixed upstream in libabigail 1.4 [2], and a bug has been opened > in launchpad [3]. > > But for now, build and use the last version 1.6 so that the ABI checks > can be kept. > > 1: https://travis-ci.com/DPDK/dpdk/jobs/287872118#L2242 > 2: https://sourceware.org/git/gitweb.cgi?p=3Dlibabigail.git;a=3Dcommitdif= f;h=3D215b7eb4fe8b986fe1cc87d9d8e7412998038392 > 3: https://bugs.launchpad.net/ubuntu/+source/libabigail/+bug/1863607 > > Signed-off-by: David Marchand > --- Does it make sense to base libabigail required ontop of extra packages? Otherwise some libraries won't get built / checked, no? > .ci/linux-build.sh | 22 ++++++++++++++++++++++ > .travis.yml | 15 ++++++++++----- > 2 files changed, 32 insertions(+), 5 deletions(-) > > diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh > index c7c3840fc..0d4bc9a62 100755 > --- a/.ci/linux-build.sh > +++ b/.ci/linux-build.sh > @@ -38,6 +38,28 @@ if [ "$AARCH64" !=3D "1" ]; then > fi > =20 > if [ "$ABI_CHECKS" =3D "1" ]; then > + LIBABIGAIL_REPO=3D${LIBABIGAIL_REPO:-https://sourceware.org/git/liba= bigail.git} > + LIBABIGAIL_VERSION=3D${LIBABIGAIL_VERSION:-libabigail-1.6} > + > + if [ "$(cat libabigail/VERSION 2>/dev/null)" !=3D "$LIBABIGAIL_VERSI= ON" ]; then > + rm -rf libabigail > + # if we change libabigail, invalidate existing abi cache > + rm -rf reference > + fi > + > + if [ ! -d libabigail ]; then > + git clone --single-branch -b $LIBABIGAIL_VERSION $LIBABIGAIL_REP= O libabigail/src > + cd libabigail/src && autoconf -vfi && cd - > + mkdir libabigail/src/build > + cd libabigail/src/build && ../configure --prefix=3D$(pwd)/libabi= gail && cd - > + make -C libabigail/src/build all install > + > + rm -rf libabigail/src > + echo $LIBABIGAIL_VERSION > libabigail/VERSION > + fi > + > + export PATH=3D$(pwd)/libabigail/bin:$PATH > + > REF_GIT_REPO=3D${REF_GIT_REPO:-https://dpdk.org/git/dpdk} > REF_GIT_TAG=3D${REF_GIT_TAG:-v19.11} > =20 > diff --git a/.travis.yml b/.travis.yml > index 22539d823..d8253fdd4 100644 > --- a/.travis.yml > +++ b/.travis.yml > @@ -2,6 +2,7 @@ language: c > cache: > ccache: true > directories: > + - libabigail > - reference > compiler: > - gcc > @@ -24,7 +25,11 @@ aarch64_packages: &aarch64_packages > =20 > extra_packages: &extra_packages > - *required_packages > - - [libbsd-dev, libpcap-dev, libcrypto++-dev, libjansson4, abigail-tool= s] > + - [libbsd-dev, libpcap-dev, libcrypto++-dev, libjansson4] > + > +libabigail_build_packages: &libabigail_build_packages > + - *required_packages > + - [autoconf, automake, libtool, pkg-config, libxml2-dev, libdw-dev] > =20 > build_32b_packages: &build_32b_packages > - *required_packages > @@ -154,18 +159,18 @@ matrix: > packages: > - *required_packages > - *doc_packages > - - env: DEF_LIB=3D"shared" EXTRA_PACKAGES=3D1 ABI_CHECKS=3D1 > + - env: DEF_LIB=3D"shared" ABI_CHECKS=3D1 > compiler: gcc > addons: > apt: > packages: > - - *extra_packages > - - env: DEF_LIB=3D"shared" EXTRA_PACKAGES=3D1 ABI_CHECKS=3D1 > + - *libabigail_build_packages > + - env: DEF_LIB=3D"shared" ABI_CHECKS=3D1 > arch: arm64 > compiler: gcc > addons: > apt: > packages: > - - *extra_packages > + - *libabigail_build_packages > =20 > script: ./.ci/${TRAVIS_OS_NAME}-build.sh