From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 48907A034F; Mon, 25 Nov 2019 23:53:59 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 649F528EE; Mon, 25 Nov 2019 23:53:58 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 5C840235 for ; Mon, 25 Nov 2019 23:53:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574722436; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ahcPZNWvMkErDJlO+vHg2kNtoaDj5Xqt5oEbsZOzMdI=; b=Nd80GYkv1zdFotWUTEtri+F0opt9RO2DsooDvk3AkPAtE0DTuv4a0nl3QKKWHKU45FBh1R VNGocrq38b4mRS4AlPxMxczAZhhXWo8QtLf6qy64WsQRlJMWk05DJm4ni4UDN4toNg31tk DrRgs2anLzuEV0dfw52ELQRTaBOfqnc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-125-lTNJLUDtNBCgykfRu2hmkA-1; Mon, 25 Nov 2019 17:53:53 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8D5D7104ECC1; Mon, 25 Nov 2019 22:53:51 +0000 (UTC) Received: from dhcp-25.97.bos.redhat.com (unknown [10.18.25.127]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 210B75D9CA; Mon, 25 Nov 2019 22:53:49 +0000 (UTC) From: Aaron Conole To: Thomas Monjalon Cc: "Van Haaren\, Harry" , "Amber\, Kumar" , "dev\@dpdk.org" , "Wang\, Yipeng1" , "Yigit\, Ferruh" , "Thakur\, Sham Singh" , David Marchand References: <20191122182100.15631-1-kumar.amber@intel.com> <2900799.QLPOietlla@xps> Date: Mon, 25 Nov 2019 17:53:49 -0500 In-Reply-To: (Aaron Conole's message of "Mon, 25 Nov 2019 13:10:41 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: lTNJLUDtNBCgykfRu2hmkA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v3] hash: added a new API to hash to query key id X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Aaron Conole writes: > Thomas Monjalon writes: > >>> From: Aaron Conole >>> > -=09if (!service_valid(id)) >>> > +=09if (id >=3D RTE_SERVICE_NUM_MAX || !service_valid(id)) >> >> Why not adding this check in service_valid()? > > I think the best fix is to use SERVICE_VALID_GET_OR_ERR_RET() in these > places. For this, I at least want to try and show that there aren't any > further errors. And my test loop has been running for a while now > without any more errors or segfaults, so I guess it's okay to build a > proper patch. This popped up: EAL: Test assert service_lcore_en_dis_able line 487 failed: Ex-service core= function call had no effect. So I'll spend some time in this area, it seems.