From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <aconole@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id 0CA384C74
 for <dev@dpdk.org>; Thu, 24 Jan 2019 21:02:50 +0100 (CET)
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com
 [10.5.11.22])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 51EA9C0C237D;
 Thu, 24 Jan 2019 20:02:49 +0000 (UTC)
Received: from dhcp-25.97.bos.redhat.com (unknown [10.18.25.61])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id 766AF1001640;
 Thu, 24 Jan 2019 20:02:48 +0000 (UTC)
From: Aaron Conole <aconole@redhat.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Michael Santana <msantana@redhat.com>, dev@dpdk.org,
 Bruce Richardson <bruce.richardson@intel.com>,
 Ferruh Yigit <ferruh.yigit@intel.com>
References: <20190123220714.20763-1-msantana@redhat.com>
 <41879020.unNp0mDazo@xps>
Date: Thu, 24 Jan 2019 15:02:47 -0500
In-Reply-To: <41879020.unNp0mDazo@xps> (Thomas Monjalon's message of "Thu, 24
 Jan 2019 19:18:41 +0100")
Message-ID: <f7tk1it963c.fsf@dhcp-25.97.bos.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.32]); Thu, 24 Jan 2019 20:02:49 +0000 (UTC)
Subject: Re: [dpdk-dev] [PATCH] Introduce travis builds for github
	repositories
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 24 Jan 2019 20:02:50 -0000

Thomas Monjalon <thomas@monjalon.net> writes:

> 23/01/2019 23:07, Michael Santana:
>> +if [ "${NINJABUILD}" == "1" ]; then
>> +    meson build
>> +    ninja -C build
>> +else
>> +    make config T=x86_64-native-linuxapp-${CC}
>> +    if [ "${SHARED}" == "1" ]; then
>> +        set_conf build CONFIG_RTE_BUILD_SHARED_LIB y
>> +    fi
>> +
>> +    if [ "${KERNEL}" == "1" ]; then
>> +        echo Unsupported kernel builds at the moment
>> +    fi
>
> Do we really want to support the "make system", given that it is going
> to be deprecated this year?

I prefer to keep it for as long as 'make' is a supported build system.
Once 'make' is deprecated (or removed, either one), it should definitely
be dropped.

Currently, the meson build isn't as well documented (for example, the
linux build guide doesn't even refer to meson).  So, most likely the
average developer who just wants to make a small contribution will run
'make' to build DPDK, and hasn't learned yet how to work with
meson/ninja.

Are there plans for which release will officially mark 'make' as
deprecated?  If it will be 19.02, then let's drop this check in v2,
since it won't be around long enough to provide any benefit.  If it will
be 19.05 or 19.08 then I think it probably will provide some value.