From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ADF1343C27; Fri, 8 Mar 2024 20:39:39 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 752D5402B4; Fri, 8 Mar 2024 20:39:39 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id D978640291 for ; Fri, 8 Mar 2024 20:39:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709926777; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QWLxhKlaxABmpGfyow9mu42CoP7/do28ILhWRiheT+k=; b=KZHpkG8cpVtMrQZpJd0fxCeZmUri/oIUht4b7Vgln0H2Cvgmf6UHaeRYLKmGrg9fAf43cE bazNRD3OOPsPtHddG7i1SMPeNHN6rjeL0foics/pwFegh2TvLqexJU9+JsWh3Y03r8Y3a3 lBOuhbVnzbSlD9LrksESWJ6Zn5Xmudc= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-590-ldiA4ATPOLqgGKid29WQ1g-1; Fri, 08 Mar 2024 14:39:34 -0500 X-MC-Unique: ldiA4ATPOLqgGKid29WQ1g-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 98D2F8A7A08; Fri, 8 Mar 2024 19:39:33 +0000 (UTC) Received: from RHTPC1VM0NT (unknown [10.22.17.159]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E7AA91C060D6; Fri, 8 Mar 2024 19:39:32 +0000 (UTC) From: Aaron Conole To: "Power, Ciara" Cc: "Sivaramakrishnan, VenkatX" , "Akhil Goyal" , "Ji, Kai" , "probb@iol.unh.edu" , "dev@dpdk.org" , "De Lara Guarch, Pablo" , Thomas Monjalon , David Marchand , Kevin Traynor Subject: Re: reg. https://patches.dpdk.org/project/dpdk/list/?series=31200 - patch result References: Date: Fri, 08 Mar 2024 14:39:32 -0500 In-Reply-To: (Ciara Power's message of "Wed, 6 Mar 2024 16:57:18 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org "Power, Ciara" writes: > Hi Aaron, > >> -----Original Message----- >> From: Aaron Conole >> Sent: Wednesday, March 6, 2024 2:57 PM >> To: Power, Ciara >> Cc: Sivaramakrishnan, VenkatX ; Akhi= l >> Goyal ; Ji, Kai ; probb@iol.unh.ed= u; >> dev@dpdk.org; De Lara Guarch, Pablo ; >> Thomas Monjalon ; David Marchand >> ; Kevin Traynor >> Subject: Re: reg. https://patches.dpdk.org/project/dpdk/list/?series=3D3= 1200 - >> patch result >>=20 >> "Power, Ciara" writes: >>=20 >> > Hi Aaron, >> > >> >> -----Original Message----- >> >> From: Aaron Conole >> >> Sent: Tuesday, March 5, 2024 6:37 PM >> >> To: Power, Ciara >> >> Cc: Sivaramakrishnan, VenkatX ; >> >> Akhil Goyal ; Ji, Kai ; >> >> probb@iol.unh.edu; dev@dpdk.org >> >> Subject: Re: reg. >> >> https://patches.dpdk.org/project/dpdk/list/?series=3D31200 - patch >> >> result >> >> >> >> "Power, Ciara" writes: >> >> >> >> > + Patrick >> >> > >> >> > >> >> > >> >> > From: Power, Ciara >> >> > Sent: Tuesday, March 5, 2024 10:05 AM >> >> > To: Sivaramakrishnan, VenkatX ; >> >> > Akhil Goyal >> >> > Cc: Ji, Kai ; Aaron Conole >> >> > Subject: RE: reg. >> >> > https://patches.dpdk.org/project/dpdk/list/?series=3D31200 - patch >> >> > result >> >> > >> >> > >> >> > >> >> > Hi folks, >> >> > >> >> > >> >> > >> >> > Had a quick look, I can also see this: >> >> > >> >> > crypto/ipsec_mb: IPSec_MB version >=3D 1.4.0 is required, found >> >> > version >> >> > 1.2.0 >> >> >> >> This version of ipsec_mb is less than 1 year old. Did this pass any >> >> other CI testing? I would be surprised if it did - I'm not sure any >> >> downstream environments that would be using it already. >> > >> > We have been using 1.4 (and even 1.5 since it was released) for intern= al >> regression testing and development. >> > Other than that, the library would be tested by Intel-ipsec-mb team di= rectly. >> > 1.4 has been supported by the ipsec-mb SW PMDs since it was released, >> > but now we would like to make it the required version, to remove the v= arious >> ifdef codepaths in PMD, and use the newer, more performant version of th= e >> library. >>=20 >> While that is a good goal, this patch series would cause build issues on= some >> distributions (which is evident from the CI failures), and that there ar= e new >> requirements isn't as clearly documented. > > Yes, the CI failures need to be resolved, some questions/discussion on > that in the other thread. > > Usually, for a version bump we would have documented in PMD > documentation, and the release notes. > We did similar before when moving from 0.53 to 1.0 as part of this > work previously for 21.11: > https://github.com/DPDK/dpdk/commit/c75542ae42000062b55cb03643575cd13b66a= eaf > https://github.com/DPDK/dpdk/commit/918fd2f1466b0e3b21a033df7012a77a83665= 582 > > >>=20 >> AFAICT, it also shifts the requirements from either OpenSSL or IPSec-MB = to >> IPSec-MB. Did I understand it correctly? > > No, bumping the ipsec-mb version from 1.1 to 1.4 for the ipsec-mb SW > PMDs doesn't involve any Openssl dependency changes - these SW PMDs > have only ever used the ipsec-mb library. > This would affect snow3g, Kasumi, zuc, aesni_mb, aesni_gcm and > chachapoly PMDs - they would need v1.4 to be compiled. Ahh, okay - thanks that makes sense to me. I guess one issue is that the current github robot will be based on 22.04, which is only shipping with ipsec-mb 1.2. I know that 23.10 includes ipsec-mb 1.4, but this is not an LTS so we likely wouldn't support it. 24.04 (the next LTS to release) will use 1.5, so when we move it shouldn't be an issue any longer. Perhaps we can look for a PPA or even build from scratch during the build the ipsec-mb to link against. This will at least give us the right coverage. I did a quick glance, but didn't see that there is any kind of 'jammy' (the 22.04 code name) ppa which covers this version, but maybe the approach is to set one up and then use it until we move to 24.04 in the future. WDYT? > >>=20 >> >> >> >> > I guess the installed PMD .so file isn=E2=80=99t created because th= ey are >> >> > not compiled in, due to the minimum version on environment not >> >> > meeting the >> >> new requirements. >> >> >> >> I don't see any such new requirements anywhere on the crypto tree. >> >> The only change I know about was for QAT to try and default to >> >> IPSec_MB 1.4, but it is supposed to fall back to OpenSSL if that is u= navailable. >> Did this change? >> > >> > This patchset introduces the requirement, it is not yet on the crypto = tree. >> > It is a SW PMD change only - currently they require 1.1 ipsec-mb, but = we want >> to bump that to 1.4. >> > QAT dependencies are unchanged. >>=20 >> In that case I think there needs to be some additional communications / >> announcements since it is changing a dependency. > > Sure, we can look to do that if needed. > Apart from the release notes + PMD doc changes, what other comms/announce= ments > do you suggest we do to bump the ipsec-mb PMD version from 1.0 to 1.4? > > =20 > Thanks, > Ciara