DPDK patches and discussions
 help / color / mirror / Atom feed
From: Aaron Conole <aconole@redhat.com>
To: Amit Gupta <agupta3@marvell.com>
Cc: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>, "Wang\,
	Yipeng1" <yipeng1.wang@intel.com>, "Gobriel\,
	Sameh" <sameh.gobriel@intel.com>, "Richardson\,
	Bruce" <bruce.richardson@intel.com>, "De Lara Guarch\,
	Pablo" <pablo.de.lara.guarch@intel.com>,
	"dev\@dpdk.org" <dev@dpdk.org>, nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH v2 1/1] test/meson: hash lf test moved to dpdk perf testsuite
Date: Thu, 17 Oct 2019 09:16:04 -0400	[thread overview]
Message-ID: <f7to8yftsvf.fsf@dhcp-25.97.bos.redhat.com> (raw)
In-Reply-To: <CY4PR1801MB19264CB7E60235ACBC2DB220FD6D0@CY4PR1801MB1926.namprd18.prod.outlook.com> (Amit Gupta's message of "Thu, 17 Oct 2019 04:57:09 +0000")

Amit Gupta <agupta3@marvell.com> writes:

>> -----Original Message-----
>> From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
>> Sent: Friday, September 13, 2019 9:17 PM
>> To: Wang, Yipeng1 <yipeng1.wang@intel.com>; Aaron Conole
>> <aconole@redhat.com>; Amit Gupta <agupta3@marvell.com>
>> Cc: Gobriel, Sameh <sameh.gobriel@intel.com>; Richardson, Bruce
>> <bruce.richardson@intel.com>; De Lara Guarch, Pablo
>> <pablo.de.lara.guarch@intel.com>; dev@dpdk.org; Honnappa Nagarahalli
>> <Honnappa.Nagarahalli@arm.com>; nd <nd@arm.com>; nd <nd@arm.com>
>> Subject: [EXT] RE: [dpdk-dev] [PATCH v2 1/1] test/meson: hash lf test moved
>> to dpdk perf testsuite
>> 
>> External Email
>> 
>> ----------------------------------------------------------------------
>> <snip>
>> 
>> > >
>> > > <agupta3@marvell.com> writes:
>> > >
>> > > > From: Amit Gupta <agupta3@marvell.com>
>> > > >
>> > > > hash_readwrite_lf test always getting TIMEOUT as required time to
>> > > > finish this test was much longer compare to time required for fast
>> > > > tests(10s). Hence, the test is being renamed moved to perf test
>> > > > category for its execution to complete.
>> > > >
>> > > > Signed-off-by: Amit Gupta <agupta3@marvell.com>
>> > > > ---
>> > >
>> > > Okay.  I'll note that we pass the '-t 3' flag, so it is actually
>> > > timing out with 30s instead of the default 10.  We do this because
>> > > occasionally the lpm6 and table tests would also exceed the 10s
>> > > timeout in the travis environment.  I agree, it's better to pull the
>> > > perf part
>> > of tests out.
>> > >
>> > > I think there isn't any additional functional test in this readwrite - is that
>> so?
>> > > If it is, then we need to also prioritize adding back in some of the
>> > > functional testing.  Maybe I misread the lf_autotest, though.
>> > >
>> > [Wang, Yipeng]
>> > Yes that is my concern too, if we just move all the lock-free test
>> > into perf test then we miss the functional test.
>> > Would any of you like to consider adding a small functional test into
>> > the readwrite or readwrite_lf_functional?
>> > That would be great :)
>> Yes, I will take up for readwrite_lf_functional. But, I do not have much
>> bandwidth for 19.11. I suggest we move only part of the tests to perf tests
>> instead for 19.11, this would serve both the purposes.
>> 
>> Amit, would it be possible to check what tests will run within the timeout
>> period?
>> >
> @Wang, Yipeng1, is it good if we do the change as @Honnappa
> Nagarahalli suggestion of changing 'hash_readwrite_lf_autotest' to
> 'hash_readwrite_lf_perf_autotest' for the time being and later once
> have sufficient bandwidth we can move only perf part of the test to
> perf tests.

NAK.

I don't like that proposal.  While it's true that there are occasional
TIMEOUT failures with the current setup, I'd much prefer these timeouts
(which we can easily distinguish) to removing the test from the travis
chain.  My understanding is that there *are* some functionality being
exercised by this test that isn't exercised elsewhere.  I'd prefer we
don't sacrifice the coverage.

  reply	other threads:[~2019-10-17 13:16 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-06  5:49 [dpdk-dev] [PATCH 0/2] test/meson: fix hash readwrite timeout failure agupta3
2019-09-06  5:49 ` [dpdk-dev] [PATCH 1/2] test/meson: hash test split into shorter subtests agupta3
2019-09-11 17:05   ` Wang, Yipeng1
2019-10-17  5:02     ` Amit Gupta
2019-11-01  4:54       ` Amit Gupta
2019-11-01 17:04         ` Wang, Yipeng1
2019-11-05 16:37           ` Ferruh Yigit
2019-11-07  3:32             ` [dpdk-dev] [EXT] " Amit Gupta
2019-12-31  4:56               ` Amit Gupta
2019-09-06  5:49 ` [dpdk-dev] [PATCH 2/2] test/meson: hash lf test moved to dpdk perf testsuite agupta3
2019-09-11 17:13   ` Wang, Yipeng1
2019-09-12 15:00     ` Honnappa Nagarahalli
2019-09-13  8:24       ` Amit Gupta
2019-09-13  8:12   ` [dpdk-dev] [PATCH v2 1/1] " agupta3
2019-09-13 14:40     ` Aaron Conole
2019-09-13 15:09       ` Wang, Yipeng1
2019-09-13 15:46         ` Honnappa Nagarahalli
2019-09-16  4:39           ` Amit Gupta
2019-10-17  4:57           ` Amit Gupta
2019-10-17 13:16             ` Aaron Conole [this message]
2019-10-24  7:22               ` David Marchand
2019-09-13  8:15   ` agupta3
2019-09-11  5:55 ` [dpdk-dev] [PATCH 0/2] test/meson: fix hash readwrite timeout failure Amit Gupta
2020-02-03 19:49 ` [dpdk-dev] [PATCH v2 0/5] " Honnappa Nagarahalli
2020-02-03 19:49   ` [dpdk-dev] [PATCH v2 1/5] test/meson: hash test split into shorter subtests Honnappa Nagarahalli
2020-02-03 19:49   ` [dpdk-dev] [PATCH v2 2/5] test/hash: remove duplicated test code Honnappa Nagarahalli
2020-02-05  8:48     ` David Marchand
2020-02-05 16:42       ` David Marchand
2020-02-03 19:49   ` [dpdk-dev] [PATCH v2 3/5] test/hash: add lock free reader writer functional tests Honnappa Nagarahalli
2020-02-05  9:07     ` David Marchand
2020-02-05 16:22       ` Honnappa Nagarahalli
2020-02-05 16:41         ` David Marchand
2020-02-05 19:34           ` Wang, Yipeng1
2020-02-05 19:52             ` Honnappa Nagarahalli
2020-02-05 19:57               ` Wang, Yipeng1
2020-02-03 19:49   ` [dpdk-dev] [PATCH v2 4/5] test/hash: move reader writer lock free tests to perf tests Honnappa Nagarahalli
2020-02-03 19:49   ` [dpdk-dev] [PATCH v2 5/5] hash: correct lock free extendable table support Honnappa Nagarahalli
2020-02-05 18:41   ` [dpdk-dev] [PATCH v2 0/5] test/meson: fix hash readwrite timeout failure David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f7to8yftsvf.fsf@dhcp-25.97.bos.redhat.com \
    --to=aconole@redhat.com \
    --cc=Honnappa.Nagarahalli@arm.com \
    --cc=agupta3@marvell.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=nd@arm.com \
    --cc=pablo.de.lara.guarch@intel.com \
    --cc=sameh.gobriel@intel.com \
    --cc=yipeng1.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).