From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 269B842D8F; Thu, 29 Jun 2023 20:26:46 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F0EE040EDB; Thu, 29 Jun 2023 20:26:45 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 90731406B7 for ; Thu, 29 Jun 2023 20:26:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688063204; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=B/RA7KHxzpPvCcY3nnisLm5awSzxwkZHbl7uDXA+zM0=; b=Es9RNiQUTwR0o63eWb0WijOCaD888viSUedPKU7UWlR8c2fCVtvkoA2NlSKvMElbUNZoAO 5eKwSl3736UwuGpNsSqfu6r86lyv5g21Pd330iEvQ0lAEiA9axWpf1UymqNpykNhSA7TCL q/qL0Uqt4XV91slyfnBDeTQq5ZZORcw= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-464-TuFkeSY1ObyhSZzK7b9RhQ-1; Thu, 29 Jun 2023 14:26:42 -0400 X-MC-Unique: TuFkeSY1ObyhSZzK7b9RhQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 37A7A1044589; Thu, 29 Jun 2023 18:26:42 +0000 (UTC) Received: from RHTPC1VM0NT (unknown [10.22.32.232]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 07DC3F5CEF; Thu, 29 Jun 2023 18:26:41 +0000 (UTC) From: Aaron Conole To: David Young Cc: dev@dpdk.org, Bruce Richardson Subject: Re: [PATCH] Updated to dpdk20.11 References: <20230629181209.400-1-dave@youngcopy.com> Date: Thu, 29 Jun 2023 14:26:41 -0400 In-Reply-To: <20230629181209.400-1-dave@youngcopy.com> (David Young's message of "Thu, 29 Jun 2023 14:12:08 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi David, David Young writes: > --- Thanks for the contribution! Very happy to have someone working on the docs. Thanks for getting a patch to the mailing list. Just a few nits to address before the patch can get merged. Customarily, a change to each area will describe that in the subject - ie: docs: freebsd: Update to 20.11 Then in the message body, we can add a bit extra detailing why the change was needed: The docs were specifying to install the dpdk package, but this is ambiguous/didn't work/blah blah blah... Finally, just before the end, we add a DCO sign-off tag: Signed-off-by: David Young When replying for a v2, v3, etc., you will need to reply to the most recent version which was obsoleted (in this case, git send-email \ --in-reply-to="<20230629181209.400-1-dave@youngcopy.com>") and make sure that the [PATCH] metadata line includes the text v2. Thanks! > doc/guides/freebsd_gsg/install_from_ports.rst | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/doc/guides/freebsd_gsg/install_from_ports.rst b/doc/guides/freebsd_gsg/install_from_ports.rst > index d946f3f3b2..ae866cd879 100644 > --- a/doc/guides/freebsd_gsg/install_from_ports.rst > +++ b/doc/guides/freebsd_gsg/install_from_ports.rst > @@ -23,7 +23,7 @@ Installing the DPDK Package for FreeBSD > > DPDK can be installed on FreeBSD using the command:: > > - pkg install dpdk > + pkg install dpdk20.11 > > After the installation of the DPDK package, instructions will be printed on > how to install the kernel modules required to use the DPDK. A more > @@ -51,7 +51,7 @@ a pre-compiled binary package. > On a system with the ports collection installed in ``/usr/ports``, the DPDK > can be installed using the commands:: > > - cd /usr/ports/net/dpdk > + cd /usr/ports/net/dpdk20.11 > > make install > > @@ -123,3 +123,4 @@ via the contigmem module, and 4 NIC ports bound to the nic_uio module:: > > For an explanation of the command-line parameters that can be passed to an > DPDK application, see section :ref:`running_sample_app`. > +