From: Aaron Conole <aconole@redhat.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, blo@iol.unh.edu, bruce.richardson@intel.com,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH v2] test: rely on EAL detection for core list
Date: Tue, 19 Oct 2021 15:09:33 -0400 [thread overview]
Message-ID: <f7tpms04ys2.fsf@redhat.com> (raw)
In-Reply-To: <20211019112602.17782-1-david.marchand@redhat.com> (David Marchand's message of "Tue, 19 Oct 2021 13:26:02 +0200")
David Marchand <david.marchand@redhat.com> writes:
> Cores count has a direct impact on the time needed to complete unit
> tests.
>
> Currently, the core list used for unit test is enforced to "all cores on
> the system" with no way for (CI) users to adapt it.
> On the other hand, EAL default behavior (when no -c/-l option gets passed)
> is to start threads on as many cores available in the process cpu
> affinity.
>
> Remove logic from meson: users can then select where to run the tests by
> either running meson with a custom cpu affinity (using taskset/cpuset
> depending on OS) or by passing a --test-args option to meson.
>
> Example:
> $ sudo meson test -C build --suite fast-tests -t 3 --test-args "-l 0-3"
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
LGTM - the spelling issue flagged seems to be a false positive.
Acked-by: Aaron Conole <aconole@redhat.com>
next prev parent reply other threads:[~2021-10-19 19:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 17:01 [dpdk-dev] [PATCH] " David Marchand
2021-10-18 17:53 ` Bruce Richardson
2021-10-19 9:52 ` David Marchand
2021-10-19 10:04 ` Bruce Richardson
2021-10-19 11:26 ` [dpdk-dev] [PATCH v2] " David Marchand
2021-10-19 12:43 ` Bruce Richardson
2021-10-19 14:46 ` Honnappa Nagarahalli
2021-10-19 15:04 ` David Marchand
2021-10-19 18:04 ` Honnappa Nagarahalli
2021-10-19 19:09 ` Aaron Conole [this message]
2021-10-19 19:28 ` David Marchand
2021-10-20 11:20 ` David Marchand
2021-10-21 14:50 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7tpms04ys2.fsf@redhat.com \
--to=aconole@redhat.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=blo@iol.unh.edu \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).