From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 98A18A0547; Tue, 19 Oct 2021 21:09:56 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7EC8340683; Tue, 19 Oct 2021 21:09:56 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 1765840142 for ; Tue, 19 Oct 2021 21:09:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634670594; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hcyvbssKUUGt21AkOZNHxKeHvCibwS1reIvWleMMUaw=; b=KnWv92NtJgVTUdPq5Qemtf5QHiNBhq0Qyw1GYEM2nCGU7jXcT/r/bRQN3VpYN9Es9PtF6q 2bsjGtz1I5rE/R4aCJpIfMrXc5R/7KKHYOzMfYIsDJXwfy4xctHClC46fmlftCvaBfTs2G SpOHXRs6owuHDnH1TuuLsiV1e6MQ7t0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-468-aBQChZ-hNwmh8RhlM_ga_Q-1; Tue, 19 Oct 2021 15:09:51 -0400 X-MC-Unique: aBQChZ-hNwmh8RhlM_ga_Q-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4BDBC104ECFE; Tue, 19 Oct 2021 19:09:50 +0000 (UTC) Received: from RHTPC1VM0NT (unknown [10.22.16.245]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1764A62A41; Tue, 19 Oct 2021 19:09:45 +0000 (UTC) From: Aaron Conole To: David Marchand Cc: dev@dpdk.org, blo@iol.unh.edu, bruce.richardson@intel.com, Honnappa Nagarahalli , nd References: <20211018170136.5189-1-david.marchand@redhat.com> <20211019112602.17782-1-david.marchand@redhat.com> Date: Tue, 19 Oct 2021 15:09:33 -0400 In-Reply-To: <20211019112602.17782-1-david.marchand@redhat.com> (David Marchand's message of "Tue, 19 Oct 2021 13:26:02 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=aconole@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Subject: Re: [dpdk-dev] [PATCH v2] test: rely on EAL detection for core list X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" David Marchand writes: > Cores count has a direct impact on the time needed to complete unit > tests. > > Currently, the core list used for unit test is enforced to "all cores on > the system" with no way for (CI) users to adapt it. > On the other hand, EAL default behavior (when no -c/-l option gets passed) > is to start threads on as many cores available in the process cpu > affinity. > > Remove logic from meson: users can then select where to run the tests by > either running meson with a custom cpu affinity (using taskset/cpuset > depending on OS) or by passing a --test-args option to meson. > > Example: > $ sudo meson test -C build --suite fast-tests -t 3 --test-args "-l 0-3" > > Signed-off-by: David Marchand > --- LGTM - the spelling issue flagged seems to be a false positive. Acked-by: Aaron Conole