From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <aconole@redhat.com>
Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])
 by dpdk.org (Postfix) with ESMTP id 64619DD2
 for <dev@dpdk.org>; Mon, 30 Apr 2018 15:13:33 +0200 (CEST)
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com
 [10.11.54.3])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 7B2B3406DE36;
 Mon, 30 Apr 2018 13:13:32 +0000 (UTC)
Received: from dhcp-25.97.bos.redhat.com (unknown [10.18.25.61])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id 47D1D111DCF4;
 Mon, 30 Apr 2018 13:13:30 +0000 (UTC)
From: Aaron Conole <aconole@redhat.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org,  tredaelli@redhat.com
References: <20180427024342.24054-1-thomas@monjalon.net>
 <20180427024342.24054-2-thomas@monjalon.net>
Date: Mon, 30 Apr 2018 09:13:29 -0400
In-Reply-To: <20180427024342.24054-2-thomas@monjalon.net> (Thomas Monjalon's
 message of "Fri, 27 Apr 2018 04:43:41 +0200")
Message-ID: <f7tpo2g7s7a.fsf@dhcp-25.97.bos.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.11.55.7]); Mon, 30 Apr 2018 13:13:32 +0000 (UTC)
X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]);
 Mon, 30 Apr 2018 13:13:32 +0000 (UTC) for IP:'10.11.54.3'
 DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com'
 HELO:'smtp.corp.redhat.com' FROM:'aconole@redhat.com' RCPT:''
Subject: Re: [dpdk-dev] [PATCH 1/2] eal: fix build with glibc < 2.16
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 30 Apr 2018 13:13:33 -0000

Thomas Monjalon <thomas@monjalon.net> writes:

> The fake getauxval function does not use its parameter.
> So the compiler raised this error:
> 	lib/librte_eal/common/eal_common_cpuflags.c:25:25: error:
> 	unused parameter 'type'
>
> Fixes: 2ed9bf330709 ("eal: abstract away the auxiliary vector")
> Cc: aconole@redhat.com
> Cc: tredaelli@redhat.com
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
Oops - sorry about that.

Acked-by: Aaron Conole <aconole@redhat.com>

>  lib/librte_eal/common/eal_common_cpuflags.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_eal/common/eal_common_cpuflags.c b/lib/librte_eal/common/eal_common_cpuflags.c
> index a09667563..6a9dbaeb1 100644
> --- a/lib/librte_eal/common/eal_common_cpuflags.c
> +++ b/lib/librte_eal/common/eal_common_cpuflags.c
> @@ -22,7 +22,7 @@
>  
>  #ifndef HAS_AUXV
>  static unsigned long
> -getauxval(unsigned long type)
> +getauxval(unsigned long type __rte_unused)
>  {
>  	errno = ENOTSUP;
>  	return 0;