From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5419AA00C4; Fri, 25 Mar 2022 15:32:51 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0FE4842846; Fri, 25 Mar 2022 15:32:51 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 06D5840140 for ; Fri, 25 Mar 2022 15:32:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648218768; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+8W8jNJqnjVG4FddT5hJYd/PoF48IflZS5Krm4Ct1rU=; b=e7HL1Z7JkPTWk/zDre8fBW7BdJIOVBpg7lxU7L5A860M9v5intW6/MfQe36UoAkdjMYH8u YXFTZSBpPLr+4k5xQfAfnYZ2Gheb577u0e6jm9LM+3KIZdYzO0gBA689EgCQUNaWn3wL0c 9UHTRhutwk8ggZiSCuLhxYNA4Gg19eo= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-332-zT_eHP4HNHWVpnt_DzUyEQ-1; Fri, 25 Mar 2022 10:32:43 -0400 X-MC-Unique: zT_eHP4HNHWVpnt_DzUyEQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 866573C1484D; Fri, 25 Mar 2022 14:32:42 +0000 (UTC) Received: from RHTPC1VM0NT (unknown [10.22.11.198]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2BBEC400E122; Fri, 25 Mar 2022 14:32:42 +0000 (UTC) From: Aaron Conole To: David Marchand Cc: dev@dpdk.org, thomas@monjalon.net, Michael Santana Subject: Re: [PATCH] ci: run more checks in private repositories References: <20220324145343.24485-1-david.marchand@redhat.com> Date: Fri, 25 Mar 2022 10:32:38 -0400 In-Reply-To: <20220324145343.24485-1-david.marchand@redhat.com> (David Marchand's message of "Thu, 24 Mar 2022 15:53:42 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=aconole@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org David Marchand writes: > Though devtools/checkpatches.sh is run as part of our CI, some other > (not well known) checks could help when run in private repositories > before submitting to the mailing list and even when run from the > ovsrobot. > > Most of them require a git history or checked sources to run. > And I can't guarantee there won't be false positives. > > Add a new job just for those checks so that it won't block compilation > tests in other jobs. > > Signed-off-by: David Marchand > --- Looks good to me. The extra fetches shouldn't take too long (since we refresh main branch weekly to the robot repository). The checks look good - and since it's part of the same build workflow, it will be reported in the same place (and hopefully in a readable form). Acked-by: Aaron Conole