DPDK patches and discussions
 help / color / mirror / Atom feed
From: Aaron Conole <aconole@redhat.com>
To: Jie Zhou <jizh@linux.microsoft.com>
Cc: dev@dpdk.org,  dmitry.kozliuk@gmail.com,  roretzla@microsoft.com,
	navasile@linux.microsoft.com,  dmitrym@microsoft.com,
	pallavi.kadam@intel.com,  talshn@nvidia.com,
	 thomas@monjalon.net
Subject: Re: [dpdk-dev] [PATCH v3 13/13] app/test: enable subset of unit tests on Windows
Date: Tue, 07 Sep 2021 09:43:56 -0400
Message-ID: <f7tsfyg4i1v.fsf@redhat.com> (raw)
In-Reply-To: <1630729155-24584-14-git-send-email-jizh@linux.microsoft.com> (Jie Zhou's message of "Fri, 3 Sep 2021 21:19:15 -0700")

Jie Zhou <jizh@linux.microsoft.com> writes:

> Enable a subset of unit tests on Windows. Currently not all the
> dependencies (e.g. libraries and some functionalities) of all unit
> tests are supported on Windows yet.
>
> Signed-off-by: Jie Zhou <jizh@linux.microsoft.com>
> ---

Hi Jie,

How is it expected that a developer will add unit tests here?  For
example, let's pretend I develop some new test.  Do I insert it into the
non-windows section or the 'all' section?  Will it ever be moved common
(for example, do windows development team aim to provide some additional
test / review cycles for new tests added)?  This have some implication
on how developers need to add tests - maybe there can be a documented
process for getting code more common (between windows / linux /
freebsd)?

-Aaron

PS: I would suggest a possible route is to update to the doc proposed in
http://patches.dpdk.org/project/dpdk/patch/20210714164047.511561-1-aconole@redhat.com/
but it still isn't merged.


  reply	other threads:[~2021-09-07 13:44 UTC|newest]

Thread overview: 172+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-18  6:17 [dpdk-dev] [PATCH v1 00/13] app/test: enable subset of " Jie Zhou
2021-08-18  6:17 ` [dpdk-dev] [PATCH v1 01/13] lib: build libraries that some tests depend on Jie Zhou
2021-08-18  6:17 ` [dpdk-dev] [PATCH v1 02/13] driver/mempool: build mempool stack on Windows Jie Zhou
2021-08-18  6:17 ` [dpdk-dev] [PATCH v1 03/13] eal/windows: return ENOTSUP for not supported API Jie Zhou
2021-08-18  6:17 ` [dpdk-dev] [PATCH v1 04/13] app/test: remove unnecessary headers Jie Zhou
2021-08-18  6:17 ` [dpdk-dev] [PATCH v1 05/13] app/test: replace POSIX specific code Jie Zhou
2021-08-18  6:17 ` [dpdk-dev] [PATCH v1 06/13] app/test: exclude ENOTSUP as failure Jie Zhou
2021-08-18  6:17 ` [dpdk-dev] [PATCH v1 07/13] app/test: skip interrupt tests on Windows Jie Zhou
2021-08-18  6:17 ` [dpdk-dev] [PATCH v1 08/13] app/test: temporarily "skip" one cmdline test case Jie Zhou
2021-08-18  6:17 ` [dpdk-dev] [PATCH v1 09/13] app/test: skip two logs_autotest cases on Windows Jie Zhou
2021-08-18  6:17 ` [dpdk-dev] [PATCH v1 10/13] app/test: differentiate a strerror on different OS Jie Zhou
2021-08-18  6:17 ` [dpdk-dev] [PATCH v1 11/13] app/test: remove two alarm_autotest cases Jie Zhou
2021-08-18  6:17 ` [dpdk-dev] [PATCH v1 12/13] app/test: replace .sh scripts with .py scripts Jie Zhou
2021-08-18  6:17 ` [dpdk-dev] [PATCH v1 13/13] app/test: enable subset of unit tests on Windows Jie Zhou
2021-08-18 17:13 ` [dpdk-dev] [PATCH v2 00/13] app/test: enable subset of " Jie Zhou
2021-08-18 17:13   ` [dpdk-dev] [PATCH v2 01/13] lib: build libraries that some tests depend on Jie Zhou
2021-08-18 17:13   ` [dpdk-dev] [PATCH v2 02/13] driver/mempool: build mempool stack on Windows Jie Zhou
2021-08-28 22:43     ` Dmitry Kozlyuk
2021-08-31 17:06       ` Jie Zhou
2021-08-18 17:13   ` [dpdk-dev] [PATCH v2 03/13] eal/windows: return ENOTSUP for not supported API Jie Zhou
2021-08-28 22:44     ` Dmitry Kozlyuk
2021-08-18 17:13   ` [dpdk-dev] [PATCH v2 04/13] app/test: remove unnecessary headers Jie Zhou
2021-08-18 17:13   ` [dpdk-dev] [PATCH v2 05/13] app/test: replace POSIX specific code Jie Zhou
2021-08-18 17:13   ` [dpdk-dev] [PATCH v2 06/13] app/test: exclude ENOTSUP as failure Jie Zhou
2021-08-18 17:13   ` [dpdk-dev] [PATCH v2 07/13] app/test: skip interrupt tests on Windows Jie Zhou
2021-08-18 17:13   ` [dpdk-dev] [PATCH v2 08/13] app/test: temporarily "skip" one cmdline test case Jie Zhou
2021-08-18 17:13   ` [dpdk-dev] [PATCH v2 09/13] app/test: skip two logs_autotest cases on Windows Jie Zhou
2021-08-18 17:13   ` [dpdk-dev] [PATCH v2 10/13] app/test: differentiate a strerror on different OS Jie Zhou
2021-08-18 17:13   ` [dpdk-dev] [PATCH v2 11/13] app/test: remove two alarm_autotest cases Jie Zhou
2021-08-18 17:13   ` [dpdk-dev] [PATCH v2 12/13] app/test: replace .sh scripts with .py scripts Jie Zhou
2021-08-28 22:17     ` Dmitry Kozlyuk
2021-08-31 16:58       ` Jie Zhou
2021-08-18 17:13   ` [dpdk-dev] [PATCH v2 13/13] app/test: enable subset of unit tests on Windows Jie Zhou
2021-08-28 22:18     ` Dmitry Kozlyuk
2021-08-31 17:01       ` Jie Zhou
2021-08-31 17:39         ` Dmitry Kozlyuk
2021-09-04  4:19   ` [dpdk-dev] [PATCH v3 00/13] app/test: enable subset of " Jie Zhou
2021-09-04  4:19     ` [dpdk-dev] [PATCH v3 01/13] lib: build libraries that some tests depend on Jie Zhou
2021-09-04  4:19     ` [dpdk-dev] [PATCH v3 02/13] mempool/stack: build on Windows Jie Zhou
2021-09-04  4:19     ` [dpdk-dev] [PATCH v3 03/13] eal/windows: return ENOTSUP for not supported API Jie Zhou
2021-09-04  4:19     ` [dpdk-dev] [PATCH v3 04/13] app/test: remove unnecessary headers Jie Zhou
2021-09-04  4:19     ` [dpdk-dev] [PATCH v3 05/13] app/test: replace POSIX specific code Jie Zhou
2021-09-04  4:19     ` [dpdk-dev] [PATCH v3 06/13] app/test: exclude ENOTSUP as failure Jie Zhou
2021-09-04  4:19     ` [dpdk-dev] [PATCH v3 07/13] app/test: skip interrupt tests on Windows Jie Zhou
2021-09-04  4:19     ` [dpdk-dev] [PATCH v3 08/13] app/test: temporarily "skip" one cmdline test case Jie Zhou
2021-09-04  4:19     ` [dpdk-dev] [PATCH v3 09/13] app/test: skip two logs_autotest cases on Windows Jie Zhou
2021-09-04  4:19     ` [dpdk-dev] [PATCH v3 10/13] app/test: differentiate a strerror on different OS Jie Zhou
2021-09-04  4:19     ` [dpdk-dev] [PATCH v3 11/13] app/test: remove two alarm_autotest cases Jie Zhou
2021-09-04  4:19     ` [dpdk-dev] [PATCH v3 12/13] app/test: replace .sh scripts with .py scripts Jie Zhou
2021-09-04  4:19     ` [dpdk-dev] [PATCH v3 13/13] app/test: enable subset of unit tests on Windows Jie Zhou
2021-09-07 13:43       ` Aaron Conole [this message]
2021-09-08 22:14         ` Jie Zhou
2021-09-23  7:35           ` Dmitry Kozlyuk
2021-09-30 23:57             ` Jie Zhou
2021-10-14  3:30     ` [dpdk-dev] [PATCH v4 00/12] app/test: enable subset of " Jie Zhou
2021-10-14  3:30       ` [dpdk-dev] [PATCH v4 01/12] lib: build libraries that some tests depend on Jie Zhou
2021-10-14  3:30       ` [dpdk-dev] [PATCH v4 02/12] eal/windows: return ENOTSUP for not supported API Jie Zhou
2021-10-14  3:30       ` [dpdk-dev] [PATCH v4 03/12] app/test: remove unnecessary headers Jie Zhou
2021-10-14  3:30       ` [dpdk-dev] [PATCH v4 04/12] app/test: replace POSIX specific code Jie Zhou
2021-10-14  3:30       ` [dpdk-dev] [PATCH v4 05/12] app/test: exclude ENOTSUP as failure Jie Zhou
2021-10-14  3:30       ` [dpdk-dev] [PATCH v4 06/12] app/test: skip interrupt tests on Windows Jie Zhou
2021-10-14  3:30       ` [dpdk-dev] [PATCH v4 07/12] app/test: temporarily "skip" one cmdline test case Jie Zhou
2021-10-14  3:30       ` [dpdk-dev] [PATCH v4 08/12] app/test: skip two logs_autotest cases on Windows Jie Zhou
2021-10-14  3:30       ` [dpdk-dev] [PATCH v4 09/12] app/test: differentiate a strerror on different OS Jie Zhou
2021-10-14  3:30       ` [dpdk-dev] [PATCH v4 10/12] app/test: remove two alarm_autotest cases Jie Zhou
2021-10-14  3:30       ` [dpdk-dev] [PATCH v4 11/12] app/test: replace .sh scripts with .py scripts Jie Zhou
2021-10-14  3:30       ` [dpdk-dev] [PATCH v4 12/12] app/test: enable subset of unit tests on Windows Jie Zhou
2021-10-14  4:52       ` [dpdk-dev] [PATCH v5 00/12] app/test: enable subset of " Jie Zhou
2021-10-14  4:52         ` [dpdk-dev] [PATCH v5 01/12] lib: build libraries that some tests depend on Jie Zhou
2021-10-14  4:52         ` [dpdk-dev] [PATCH v5 02/12] eal/windows: return ENOTSUP for not supported API Jie Zhou
2021-10-14  4:52         ` [dpdk-dev] [PATCH v5 03/12] app/test: remove unnecessary headers Jie Zhou
2021-10-14  4:52         ` [dpdk-dev] [PATCH v5 04/12] app/test: replace POSIX specific code Jie Zhou
2021-10-14  4:52         ` [dpdk-dev] [PATCH v5 05/12] app/test: exclude ENOTSUP as failure Jie Zhou
2021-10-14  4:52         ` [dpdk-dev] [PATCH v5 06/12] app/test: skip interrupt tests on Windows Jie Zhou
2021-10-14  4:52         ` [dpdk-dev] [PATCH v5 07/12] app/test: temporarily "skip" one cmdline test case Jie Zhou
2021-10-14  4:52         ` [dpdk-dev] [PATCH v5 08/12] app/test: skip two logs_autotest cases on Windows Jie Zhou
2021-10-14  4:52         ` [dpdk-dev] [PATCH v5 09/12] app/test: differentiate a strerror on different OS Jie Zhou
2021-10-14  4:52         ` [dpdk-dev] [PATCH v5 10/12] app/test: remove two alarm_autotest cases Jie Zhou
2021-10-14  4:52         ` [dpdk-dev] [PATCH v5 11/12] app/test: replace .sh scripts with .py scripts Jie Zhou
2021-10-14  4:52         ` [dpdk-dev] [PATCH v5 12/12] app/test: enable subset of unit tests on Windows Jie Zhou
2021-10-14 16:21         ` [dpdk-dev] [PATCH v6 00/12] app/test: enable subset of " Jie Zhou
2021-10-14 16:21           ` [dpdk-dev] [PATCH v6 01/12] lib: build libraries that some tests depend on Jie Zhou
2021-10-25 15:38             ` Thomas Monjalon
2021-10-26  0:47               ` Jie Zhou
2021-10-26  8:44                 ` Thomas Monjalon
2021-10-14 16:21           ` [dpdk-dev] [PATCH v6 02/12] eal/windows: return ENOTSUP for not supported API Jie Zhou
2021-10-14 16:21           ` [dpdk-dev] [PATCH v6 03/12] app/test: remove unnecessary headers Jie Zhou
2021-10-14 16:21           ` [dpdk-dev] [PATCH v6 04/12] app/test: replace POSIX specific code Jie Zhou
2021-10-14 16:21           ` [dpdk-dev] [PATCH v6 05/12] app/test: exclude ENOTSUP as failure Jie Zhou
2021-10-14 16:21           ` [dpdk-dev] [PATCH v6 06/12] app/test: skip interrupt tests on Windows Jie Zhou
2021-10-14 16:21           ` [dpdk-dev] [PATCH v6 07/12] app/test: temporarily "skip" one cmdline test case Jie Zhou
2021-10-14 16:21           ` [dpdk-dev] [PATCH v6 08/12] app/test: skip two logs_autotest cases on Windows Jie Zhou
2021-10-14 16:21           ` [dpdk-dev] [PATCH v6 09/12] app/test: differentiate a strerror on different OS Jie Zhou
2021-10-14 16:21           ` [dpdk-dev] [PATCH v6 10/12] app/test: remove two alarm_autotest cases Jie Zhou
2021-10-14 16:21           ` [dpdk-dev] [PATCH v6 11/12] app/test: replace .sh scripts with .py scripts Jie Zhou
2021-10-14 16:21           ` [dpdk-dev] [PATCH v6 12/12] app/test: enable subset of unit tests on Windows Jie Zhou
2021-10-26  2:26           ` [dpdk-dev] [PATCH v7 00/11] app/test: enable subset of " Jie Zhou
2021-10-26  2:26             ` [dpdk-dev] [PATCH v7 01/11] eal/windows: return ENOTSUP for not supported API Jie Zhou
2021-10-26  2:26             ` [dpdk-dev] [PATCH v7 02/11] app/test: remove unnecessary headers Jie Zhou
2021-10-26  2:26             ` [dpdk-dev] [PATCH v7 03/11] app/test: replace POSIX specific code Jie Zhou
2021-10-26  2:26             ` [dpdk-dev] [PATCH v7 04/11] app/test: exclude ENOTSUP as failure Jie Zhou
2021-10-26  2:26             ` [dpdk-dev] [PATCH v7 05/11] app/test: skip interrupt tests on Windows Jie Zhou
2021-10-26  2:26             ` [dpdk-dev] [PATCH v7 06/11] app/test: temporarily "skip" one cmdline test case Jie Zhou
2021-10-26  2:26             ` [dpdk-dev] [PATCH v7 07/11] app/test: skip two logs_autotest cases on Windows Jie Zhou
2021-10-26  2:26             ` [dpdk-dev] [PATCH v7 08/11] app/test: differentiate a strerror on different OS Jie Zhou
2021-10-26  2:26             ` [dpdk-dev] [PATCH v7 09/11] app/test: remove two alarm_autotest cases Jie Zhou
2021-10-26  2:26             ` [dpdk-dev] [PATCH v7 10/11] app/test: replace .sh scripts with .py scripts Jie Zhou
2021-10-26  2:26             ` [dpdk-dev] [PATCH v7 11/11] app/test: enable subset of unit tests on Windows Jie Zhou
2021-10-26  2:45             ` [dpdk-dev] [PATCH v8 00/11] app/test: enable subset of " Jie Zhou
2021-10-26  2:45               ` [dpdk-dev] [PATCH v8 01/11] eal/windows: return ENOTSUP for not supported API Jie Zhou
2021-10-26  2:45               ` [dpdk-dev] [PATCH v8 02/11] app/test: remove unnecessary headers Jie Zhou
2021-10-26  2:45               ` [dpdk-dev] [PATCH v8 03/11] app/test: replace POSIX specific code Jie Zhou
2021-11-23 22:02                 ` Dmitry Kozlyuk
2021-12-01  1:05                   ` Jie Zhou
2021-12-01  7:19                     ` Dmitry Kozlyuk
2021-10-26  2:45               ` [dpdk-dev] [PATCH v8 04/11] app/test: exclude ENOTSUP as failure Jie Zhou
2021-11-23 22:02                 ` Dmitry Kozlyuk
2021-12-01  0:31                   ` Jie Zhou
2021-10-26  2:45               ` [dpdk-dev] [PATCH v8 05/11] app/test: skip interrupt tests on Windows Jie Zhou
2021-10-26  2:45               ` [dpdk-dev] [PATCH v8 06/11] app/test: temporarily "skip" one cmdline test case Jie Zhou
2021-11-23 22:02                 ` Dmitry Kozlyuk
2021-12-01  0:30                   ` Jie Zhou
2021-10-26  2:45               ` [dpdk-dev] [PATCH v8 07/11] app/test: skip two logs_autotest cases on Windows Jie Zhou
2021-10-26  2:45               ` [dpdk-dev] [PATCH v8 08/11] app/test: differentiate a strerror on different OS Jie Zhou
2021-10-26  2:45               ` [dpdk-dev] [PATCH v8 09/11] app/test: remove two alarm_autotest cases Jie Zhou
2021-10-26  2:46               ` [dpdk-dev] [PATCH v8 10/11] app/test: replace .sh scripts with .py scripts Jie Zhou
2021-11-23 22:15                 ` Dmitry Kozlyuk
2021-12-01  0:29                   ` Jie Zhou
2021-10-26  2:46               ` [dpdk-dev] [PATCH v8 11/11] app/test: enable subset of unit tests on Windows Jie Zhou
2021-12-01 18:05               ` [PATCH v9 0/9] app/test: enable subset of " Jie Zhou
2021-12-01 18:05                 ` [PATCH v9 1/9] eal/windows: return ENOTSUP for not supported API Jie Zhou
2021-12-01 18:05                 ` [PATCH v9 2/9] app/test: remove POSIX-specific code Jie Zhou
2021-12-01 18:05                 ` [PATCH v9 3/9] app/test: fix incorrect errno variable Jie Zhou
2021-12-01 18:05                 ` [PATCH v9 4/9] app/test: skip interrupt tests on Windows Jie Zhou
2021-12-01 18:05                 ` [PATCH v9 5/9] app/test: skip two logs_autotest cases " Jie Zhou
2021-12-01 18:05                 ` [PATCH v9 6/9] app/test: differentiate a strerror on different OS Jie Zhou
2021-12-01 18:05                 ` [PATCH v9 7/9] app/test: remove two alarm_autotest cases Jie Zhou
2021-12-01 18:05                 ` [PATCH v9 8/9] app/test: replace .sh script with .py script Jie Zhou
2021-12-01 18:05                 ` [PATCH v9 9/9] app/test: enable subset of unit tests on Windows Jie Zhou
2021-12-01 18:45                   ` Stephen Hemminger
2021-12-01 18:52                     ` Jie Zhou
2021-12-01 18:58                     ` [EXTERNAL] " Tyler Retzlaff
2021-12-01 18:43                 ` [PATCH v10 0/9] app/test: enable subset of " Jie Zhou
2021-12-01 18:43                   ` [PATCH v10 1/9] eal/windows: return ENOTSUP for not supported API Jie Zhou
2021-12-01 18:43                   ` [PATCH v10 2/9] app/test: remove POSIX-specific code Jie Zhou
2021-12-04  1:05                     ` Dmitry Kozlyuk
2021-12-01 18:43                   ` [PATCH v10 3/9] app/test: fix incorrect errno variable Jie Zhou
2021-12-01 18:44                   ` [PATCH v10 4/9] app/test: skip interrupt tests on Windows Jie Zhou
2021-12-01 18:44                   ` [PATCH v10 5/9] app/test: skip two logs_autotest cases " Jie Zhou
2021-12-01 18:44                   ` [PATCH v10 6/9] app/test: differentiate a strerror on different OS Jie Zhou
2021-12-01 18:44                   ` [PATCH v10 7/9] app/test: remove two alarm_autotest cases Jie Zhou
2021-12-01 18:44                   ` [PATCH v10 8/9] app/test: replace .sh script with .py script Jie Zhou
2021-12-01 18:44                   ` [PATCH v10 9/9] app/test: enable subset of unit tests on Windows Jie Zhou
2021-12-02  9:17                     ` David Marchand
2021-12-02 23:23                       ` Jie Zhou
2021-12-03  0:06                   ` [PATCH v11 0/9] app/test: enable subset of " Jie Zhou
2021-12-03  0:06                     ` [PATCH v11 1/9] eal/windows: return ENOTSUP for not supported API Jie Zhou
2021-12-03  0:06                     ` [PATCH v11 2/9] app/test: remove POSIX-specific code Jie Zhou
2021-12-03  0:06                     ` [PATCH v11 3/9] app/test: fix incorrect errno variable Jie Zhou
2021-12-04  1:05                       ` Dmitry Kozlyuk
2021-12-03  0:06                     ` [PATCH v11 4/9] app/test: skip interrupt tests on Windows Jie Zhou
2021-12-04  1:06                       ` Dmitry Kozlyuk
2021-12-03  0:06                     ` [PATCH v11 5/9] app/test: skip two logs_autotest cases " Jie Zhou
2021-12-04  1:16                       ` Dmitry Kozlyuk
2021-12-03  0:06                     ` [PATCH v11 6/9] app/test: differentiate a strerror on different OS Jie Zhou
2021-12-04  1:33                       ` Dmitry Kozlyuk
2021-12-03  0:06                     ` [PATCH v11 7/9] app/test: remove two alarm_autotest cases Jie Zhou
2021-12-04  1:06                       ` Dmitry Kozlyuk
2021-12-03  0:06                     ` [PATCH v11 8/9] app/test: replace .sh script with .py script Jie Zhou
2021-12-04  1:06                       ` Dmitry Kozlyuk
2021-12-03  0:06                     ` [PATCH v11 9/9] app/test: enable subset of unit tests on Windows Jie Zhou
2021-12-04  0:07                     ` [PATCH v11 0/9] app/test: enable subset of " Kadam, Pallavi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f7tsfyg4i1v.fsf@redhat.com \
    --to=aconole@redhat.com \
    --cc=dev@dpdk.org \
    --cc=dmitry.kozliuk@gmail.com \
    --cc=dmitrym@microsoft.com \
    --cc=jizh@linux.microsoft.com \
    --cc=navasile@linux.microsoft.com \
    --cc=pallavi.kadam@intel.com \
    --cc=roretzla@microsoft.com \
    --cc=talshn@nvidia.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git