From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EF814A0526; Wed, 8 Jul 2020 15:43:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2C8081DC12; Wed, 8 Jul 2020 15:43:31 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 3F9851DBBC for ; Wed, 8 Jul 2020 15:43:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594215809; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=se++EVqOKdeWmCjaIaKiGmktQWpP+QMHVwb8bdrdEO8=; b=fkFBHtV+gjS0ebbekA1S3XmFI0Ag3+ANC9EFS76jBYApn+0lCR6jb3JXLHOpTbUtMwM6ZW wCb0SLC7wyBptxYAIMuyor1tDx6HCgECfA5zeCRrtN7gtLgRgMPj1JPR64ODVQ5xm5WGtR o5PPA7N1bZBWBqeInZCl6hm/9a722zw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-97-GO3cXTUZPF-8rMgY8oGH9w-1; Wed, 08 Jul 2020 09:43:15 -0400 X-MC-Unique: GO3cXTUZPF-8rMgY8oGH9w-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C7686C7467; Wed, 8 Jul 2020 13:43:13 +0000 (UTC) Received: from dhcp-25.97.bos.redhat.com (ovpn-114-181.rdu2.redhat.com [10.10.114.181]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 27383512FE; Wed, 8 Jul 2020 13:43:05 +0000 (UTC) From: Aaron Conole To: David Marchand Cc: Phil Yang , dev , David Christensen , Honnappa Nagarahalli , "Ruifeng Wang \(Arm Technology China\)" , nd , Dodji Seketeli , Neil Horman , Ray Kinsella , Harman Kalra References: <1591871065-12461-1-git-send-email-phil.yang@arm.com> <1591871065-12461-2-git-send-email-phil.yang@arm.com> Date: Wed, 08 Jul 2020 09:43:04 -0400 In-Reply-To: (David Marchand's message of "Wed, 8 Jul 2020 14:29:19 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=aconole@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Subject: Re: [dpdk-dev] [PATCH 2/2] eal: use c11 atomics for interrupt status X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" David Marchand writes: > On Thu, Jun 11, 2020 at 12:25 PM Phil Yang wrote: >> >> The event status is defined as a volatile variable and shared >> between threads. Use c11 atomics with explicit ordering instead >> of rte_atomic ops which enforce unnecessary barriers on aarch64. >> >> Signed-off-by: Phil Yang >> Reviewed-by: Ruifeng Wang >> --- >> lib/librte_eal/include/rte_eal_interrupts.h | 2 +- >> lib/librte_eal/linux/eal_interrupts.c | 47 ++++++++++++++++++++--------- >> 2 files changed, 34 insertions(+), 15 deletions(-) >> >> diff --git a/lib/librte_eal/include/rte_eal_interrupts.h b/lib/librte_eal/include/rte_eal_interrupts.h >> index 773a34a..b1e8a29 100644 >> --- a/lib/librte_eal/include/rte_eal_interrupts.h >> +++ b/lib/librte_eal/include/rte_eal_interrupts.h >> @@ -59,7 +59,7 @@ enum { >> >> /** interrupt epoll event obj, taken by epoll_event.ptr */ >> struct rte_epoll_event { >> - volatile uint32_t status; /**< OUT: event status */ >> + uint32_t status; /**< OUT: event status */ >> int fd; /**< OUT: event fd */ >> int epfd; /**< OUT: epoll instance the ev associated with */ >> struct rte_epoll_data epdata; > > I got a reject from the ABI check in my env. > > 1 function with some indirect sub-type change: > > [C]'function int rte_pci_ioport_map(rte_pci_device*, int, > rte_pci_ioport*)' at pci.c:756:1 has some indirect sub-type changes: > parameter 1 of type 'rte_pci_device*' has sub-type changes: > in pointed to type 'struct rte_pci_device' at rte_bus_pci.h:57:1: > type size hasn't changed > 1 data member changes (2 filtered): > type of 'rte_intr_handle rte_pci_device::intr_handle' changed: > type size hasn't changed > 1 data member change: > type of 'rte_epoll_event rte_intr_handle::elist[512]' changed: > array element type 'struct rte_epoll_event' changed: > type size hasn't changed > 1 data member change: > type of 'volatile uint32_t rte_epoll_event::status' changed: > entity changed from 'volatile uint32_t' to 'typedef > uint32_t' at stdint-uintn.h:26:1 > type size hasn't changed > > type size hasn't changed > > > This is probably harmless in our case (going from volatile to non > volatile), but it won't pass the check in the CI without an exception > rule. > > Note: checking on the test-report ml, I saw nothing, but ovsrobot did > catch the issue with this change too, Aaron? I don't have archives back to Jun 11 on the robot server. I think it doesn't preserve forever (and the archives seem to go back only until Jul 03). I will update it. I do see that we have a failed travis job: https://travis-ci.org/github/ovsrobot/dpdk/builds/697180855 I'm surprised this didn't go out. Have we seen other failures to report of the ovs robot recently? I can double check the job config.