DPDK patches and discussions
 help / color / mirror / Atom feed
From: Aaron Conole <aconole@redhat.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org,  Michael Santana <maicolgabriel@hotmail.com>
Subject: Re: [PATCH] ci: combine static and shared linking build tests
Date: Thu, 20 Oct 2022 11:34:26 -0400	[thread overview]
Message-ID: <f7ttu3yqzjx.fsf@redhat.com> (raw)
In-Reply-To: <20221017140731.3467481-1-david.marchand@redhat.com> (David Marchand's message of "Mon, 17 Oct 2022 16:07:31 +0200")

David Marchand <david.marchand@redhat.com> writes:

> Save some cpu time and disk by testing linking against static and shared
> library in single environments.
>
> The .ci/linux-build.sh is modified so it reconfigures an existing build
> directory: an empty DEF_LIB= means that static and shared builds are
> to be tested.
>
> ABI checks, documentation generation and unit tests are disabled for
> static builds as they would be redundant with the check against
> dynamically linked binaries, if any.
>
> Note:
> - --cross-file is an option that can be passed to meson only when
>   creating a build environment,
> - for some other reason, --buildtype and other non -D options are only
>   accepted when setting up a build directory with meson. When
>   reconfiguring, only their -D$option forms are accepted,
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---

Probably also saves overall time because we would need fewer runners.  I
think this is a good change.

Acked-by: Aaron Conole <aconole@redhat.com>


  parent reply	other threads:[~2022-10-20 15:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-17 14:07 David Marchand
2022-10-20 11:44 ` David Marchand
2022-10-20 11:51   ` Bruce Richardson
2022-10-20 15:34 ` Aaron Conole [this message]
2022-10-27 11:21   ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f7ttu3yqzjx.fsf@redhat.com \
    --to=aconole@redhat.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=maicolgabriel@hotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).