From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 127B3A0553; Thu, 20 Oct 2022 17:34:31 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A549A40A7D; Thu, 20 Oct 2022 17:34:30 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 3E1A840694 for ; Thu, 20 Oct 2022 17:34:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666280068; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P5N7whZXxZxTGH3k5dkrY1pG9WPhdwb82r2FFhTsn4w=; b=KDup85kr0Bj1t2RKs3tOXg+H+495WLm0VwaeqV8X8x+ZZQ37YNey+rgFZWCVJL2cTwf3c8 Yk92r3lN7ltz75f4dgEb+knshLTFs+omoTdQ/Kmj5btTxuLQOUX3PEst5BhlUvACyCYgf3 +WZCNJALZHoQJOW9y4bFflByoZvdRuk= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-110-d8Y_LZljMd-lmuo88ighVA-1; Thu, 20 Oct 2022 11:34:27 -0400 X-MC-Unique: d8Y_LZljMd-lmuo88ighVA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 120BF800B30; Thu, 20 Oct 2022 15:34:27 +0000 (UTC) Received: from RHTPC1VM0NT (unknown [10.22.8.238]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D05774EA4D; Thu, 20 Oct 2022 15:34:26 +0000 (UTC) From: Aaron Conole To: David Marchand Cc: dev@dpdk.org, Michael Santana Subject: Re: [PATCH] ci: combine static and shared linking build tests References: <20221017140731.3467481-1-david.marchand@redhat.com> Date: Thu, 20 Oct 2022 11:34:26 -0400 In-Reply-To: <20221017140731.3467481-1-david.marchand@redhat.com> (David Marchand's message of "Mon, 17 Oct 2022 16:07:31 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org David Marchand writes: > Save some cpu time and disk by testing linking against static and shared > library in single environments. > > The .ci/linux-build.sh is modified so it reconfigures an existing build > directory: an empty DEF_LIB= means that static and shared builds are > to be tested. > > ABI checks, documentation generation and unit tests are disabled for > static builds as they would be redundant with the check against > dynamically linked binaries, if any. > > Note: > - --cross-file is an option that can be passed to meson only when > creating a build environment, > - for some other reason, --buildtype and other non -D options are only > accepted when setting up a build directory with meson. When > reconfiguring, only their -D$option forms are accepted, > > Signed-off-by: David Marchand > --- Probably also saves overall time because we would need fewer runners. I think this is a good change. Acked-by: Aaron Conole