From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 086A6A0548; Tue, 20 Apr 2021 16:48:13 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7636E41749; Tue, 20 Apr 2021 16:48:13 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 64DFF41735 for ; Tue, 20 Apr 2021 16:48:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618930091; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QrMc7Gbds+ORPWYo3ezp9iD68mK12VgTZS2y13TZEfU=; b=VUgT10ZqHpD6k1m42OJzmo/4uHx1vQVUniPAAu+ER0rA7jmtQhxGou4JTu22SirlPUfSIp S27qV1CcSZxjNJuHM9UYM11Eus+9ipu2ZSn1O0dR/Bnkrf8xwd9n/iJoDZiSmZI+ydZrOy nyGnNeqlyYUZ1Y03NjifTIvAsDEorlM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-331-z45a7zldO7epra3AehPCxw-1; Tue, 20 Apr 2021 10:48:08 -0400 X-MC-Unique: z45a7zldO7epra3AehPCxw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4FB37802B5B; Tue, 20 Apr 2021 14:48:07 +0000 (UTC) Received: from dhcp-25.97.bos.redhat.com (ovpn-115-147.rdu2.redhat.com [10.10.115.147]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A24805D6AB; Tue, 20 Apr 2021 14:48:06 +0000 (UTC) From: Aaron Conole To: "Dumitrescu\, Cristian" Cc: Thomas Monjalon , "dev\@dpdk.org" References: <20210411232338.4005-1-cristian.dumitrescu@intel.com> <1799475.riq6yjk0ZW@thomas> <1649627.coH7sy9KVI@thomas> Date: Tue, 20 Apr 2021 10:48:05 -0400 In-Reply-To: (Cristian Dumitrescu's message of "Tue, 20 Apr 2021 10:20:28 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=aconole@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Subject: Re: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of action args X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" "Dumitrescu, Cristian" writes: >> -----Original Message----- >> From: Thomas Monjalon >> Sent: Tuesday, April 20, 2021 11:07 AM >> To: Dumitrescu, Cristian >> Cc: dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of >> action args >> >> 20/04/2021 12:04, Dumitrescu, Cristian: >> > From: Thomas Monjalon >> > > 12/04/2021 01:23, Cristian Dumitrescu: >> > > > Each table entry is made up of match fields and action data, with the >> > > > latter made up of the action ID and the action arguments. The approach >> > > > of having the user specify explicitly the endianness of the action >> > > > arguments is difficult to be picked up by P4 compilers, as the P4 >> > > > compiler is generally unaware about this aspect. >> > > > >> > > > This commit introduces the auto-detection of the endianness of the >> > > > action arguments by examining the endianness of the their destination: >> > > > network byte order (NBO) when they get copied to headers and host >> byte >> > > > order (HBO) when they get copied to packet meta-data or mailboxes. >> > > > >> > > > The endianness specification of each action argument as part of the >> > > > rule specification, e.g. H(...) and N(...) is removed from the rule >> > > > file and auto-detected based on their destination. The DMA instruction >> > > > scope is made internal, so mov instructions need to be used. The >> > > > pattern of transferring complete headers from table entry action args >> > > > to headers is detected, and the associated set of mov instructions >> > > > plus header validate is internally detected and replaced with the >> > > > internal-only DMA instruction to preserve performance. >> > > > >> > > > Signed-off-by: Cristian Dumitrescu >> > > > --- >> > > > examples/pipeline/examples/vxlan.spec | 41 ++- >> > > > examples/pipeline/examples/vxlan_table.py | 44 ++-- >> > > > examples/pipeline/examples/vxlan_table.txt | 32 +-- >> > > > lib/librte_pipeline/rte_swx_ctl.c | 15 +- >> > > > lib/librte_pipeline/rte_swx_ctl.h | 6 + >> > > > lib/librte_pipeline/rte_swx_pipeline.c | 282 ++++++++++++++++++- >> -- >> > > > lib/librte_pipeline/rte_swx_pipeline.h | 4 - >> > > >> > > There are compilation issues in the CI: >> > > https://patches.dpdk.org/project/dpdk/patch/20210411232338.4005-2- >> > > cristian.dumitrescu@intel.com/ >> > > >> > >> > Hi Thomas, >> > >> > The reason for the CI issues is because this patch set has dependencies on >> the previous patches that were pending, but now already applied by you >> (thank you!), so there should not be any real issues? >> >> Yes I didn't see any issue locally, just wanted to confirm. >> > > Thanks, Thomas. I just double checked by applying this set on the main > latest, and I could not see any apply or build issues. I restarted the builds for this. Currently, travis robot (but not github actions) reports an error even after the restart of this build - this is in error. The correct build should be: https://travis-ci.com/github/ovsrobot/dpdk/builds/223614512 And that shows the build completed successfully. Looks like we pull the build list incorrectly.