From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <aconole@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id ED34E1B1D0
 for <dev@dpdk.org>; Tue,  9 Jan 2018 17:44:41 +0100 (CET)
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com
 [10.5.11.14])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 10C69883CA;
 Tue,  9 Jan 2018 16:44:41 +0000 (UTC)
Received: from dhcp-25.97.bos.redhat.com (unknown [10.18.25.61])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id 84A575D9CA;
 Tue,  9 Jan 2018 16:44:40 +0000 (UTC)
From: Aaron Conole <aconole@redhat.com>
To: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
Cc: pbhagavatula@caviumnetworks.com, harry.van.haaren@intel.com, dev@dpdk.org
References: <1515005015-31990-1-git-send-email-erik.g.carrillo@intel.com>
 <1515005015-31990-2-git-send-email-erik.g.carrillo@intel.com>
Date: Tue, 09 Jan 2018 11:44:39 -0500
In-Reply-To: <1515005015-31990-2-git-send-email-erik.g.carrillo@intel.com>
 (Erik Gabriel Carrillo's message of "Wed, 3 Jan 2018 12:43:35 -0600")
Message-ID: <f7ttvvv3rt4.fsf@dhcp-25.97.bos.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.26]); Tue, 09 Jan 2018 16:44:41 +0000 (UTC)
Subject: Re: [dpdk-dev] [PATCH 1/1] eal: return true or false from lcore
	role check function
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 09 Jan 2018 16:44:42 -0000

Hi Erik,

Erik Gabriel Carrillo <erik.g.carrillo@intel.com> writes:

> Update rte_lcore_has_role() so that it returns true/false instead of
> success/failure.
>
> Fixes: 78666372fa2b ("eal: add function to check lcore role")
>
> Signed-off-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
> ---

I believe this breaks the published abi - Success is now 'true', and
failure is 'false';  previously success would be 0 == false.  You'll
need to invert the test, or note that the abi is breaking (since
semantically any caller will need to invert the test).