DPDK patches and discussions
 help / color / mirror / Atom feed
From: Aaron Conole <aconole@redhat.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org,  David Marchand <david.marchand@redhat.com>,
	 Michael Santana <msantana@redhat.com>,
	 Ilya Maximets <i.maximets@ovn.org>,
	 Erik Gabriel Carrillo <erik.g.carrillo@intel.com>,
	 bruce.richardson@intel.com
Subject: Re: [dpdk-dev] [dpdk-ci] [PATCH] test: drop 'alarm_autotest' and 'cycles_autotest' from test suite
Date: Tue, 25 May 2021 09:21:47 -0400	[thread overview]
Message-ID: <f7tv9776j9w.fsf@redhat.com> (raw)
In-Reply-To: <23172713.yfyB1BgmTZ@thomas> (Thomas Monjalon's message of "Tue,  25 May 2021 10:05:40 +0200")

Thomas Monjalon <thomas@monjalon.net> writes:

> 25/05/2021 02:16, Aaron Conole:
>> The tests 'alarm_autotest' and 'cycles_autotest' rely on the underlying
>> system having very accurate and precise timing.  On systems where the timing
>> isn't as rigid, or the load is particularly high, these tests are unreliable
>> since the wake latency from the scheduler can be high enough to miss the
>> timing window.
>> 
>> Remove these tests from the test suites.  Maybe it's useful for these
>> tests to be present as a diagnostics tool, but for normal unit testing,
>> they don't provide much value.  They have falsely flagged patches as
>> FAIL on various infrastructures.
>
> Are sure of the value keeping the source code?

Okay, I think it's fine to remove it as well.

I will submit v2


  reply	other threads:[~2021-05-25 13:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-25  0:16 [dpdk-dev] " Aaron Conole
2021-05-25  8:05 ` [dpdk-dev] [dpdk-ci] " Thomas Monjalon
2021-05-25 13:21   ` Aaron Conole [this message]
2021-05-26 11:58 ` [dpdk-dev] [PATCH v2] test: remove strict timing requirements from alarm and cycles tests Aaron Conole
2021-05-26 13:06   ` Aaron Conole
2021-06-03 13:46 ` [dpdk-dev] [PATCH v3] " Aaron Conole
2021-06-03 15:22   ` [dpdk-dev] [PATCH v4] " Aaron Conole
2021-06-03 16:13     ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f7tv9776j9w.fsf@redhat.com \
    --to=aconole@redhat.com \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=erik.g.carrillo@intel.com \
    --cc=i.maximets@ovn.org \
    --cc=msantana@redhat.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).