From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2C3D3A0546; Tue, 25 May 2021 15:22:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A745840150; Tue, 25 May 2021 15:22:08 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 5F5B04003F for ; Tue, 25 May 2021 15:22:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621948926; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GTR0tpLkm50HVw4r/QlxUlQpOVjempnEUMT7gfPZXqQ=; b=Et00k6aL0/yvzVWFtyhqYGE0DLH/KBjJ+YqyGaqFUBfjpqvQ+NR/Rng/N+PXm0GEObOZ2w NnRd44X6eaLNRFUHiZWQUv7ku4kF/VlJhkcwSPmDGLAPY59PccuTzv9ojNxkWBzb8Ri1Si nidyihKjl6sAzjGpYIvCXR/E0Elgfsc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-279-ZA5aUODwMBu87ZGypW7maw-1; Tue, 25 May 2021 09:22:04 -0400 X-MC-Unique: ZA5aUODwMBu87ZGypW7maw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DDD421922970; Tue, 25 May 2021 13:22:01 +0000 (UTC) Received: from RHTPC1VM0NT (ovpn-116-248.rdu2.redhat.com [10.10.116.248]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 54BD36060F; Tue, 25 May 2021 13:21:51 +0000 (UTC) From: Aaron Conole To: Thomas Monjalon Cc: dev@dpdk.org, David Marchand , Michael Santana , Ilya Maximets , Erik Gabriel Carrillo , bruce.richardson@intel.com References: <23172713.yfyB1BgmTZ@thomas> Date: Tue, 25 May 2021 09:21:47 -0400 In-Reply-To: <23172713.yfyB1BgmTZ@thomas> (Thomas Monjalon's message of "Tue, 25 May 2021 10:05:40 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=aconole@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Subject: Re: [dpdk-dev] [dpdk-ci] [PATCH] test: drop 'alarm_autotest' and 'cycles_autotest' from test suite X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Thomas Monjalon writes: > 25/05/2021 02:16, Aaron Conole: >> The tests 'alarm_autotest' and 'cycles_autotest' rely on the underlying >> system having very accurate and precise timing. On systems where the timing >> isn't as rigid, or the load is particularly high, these tests are unreliable >> since the wake latency from the scheduler can be high enough to miss the >> timing window. >> >> Remove these tests from the test suites. Maybe it's useful for these >> tests to be present as a diagnostics tool, but for normal unit testing, >> they don't provide much value. They have falsely flagged patches as >> FAIL on various infrastructures. > > Are sure of the value keeping the source code? Okay, I think it's fine to remove it as well. I will submit v2