From: Aaron Conole <aconole@redhat.com>
To: "Wang\, Haiyue" <haiyue.wang@intel.com>
Cc: Paolo Valerio <pvalerio@redhat.com>,
"dev\@dpdk.org" <dev@dpdk.org>, "Guo\, Jia" <jia.guo@intel.com>
Subject: Re: [dpdk-dev] ixgbe and UDP with zero checksum
Date: Wed, 27 Jan 2021 13:21:05 -0500 [thread overview]
Message-ID: <f7tv9bii6lq.fsf@dhcp-25.97.bos.redhat.com> (raw)
In-Reply-To: <BN8PR11MB37958D90BD595741170A9E66F7BB9@BN8PR11MB3795.namprd11.prod.outlook.com> (Haiyue Wang's message of "Wed, 27 Jan 2021 17:26:39 +0000")
"Wang, Haiyue" <haiyue.wang@intel.com> writes:
> Hi Paolo,
>
>> -----Original Message-----
>> From: Paolo Valerio <pvalerio@redhat.com>
>> Sent: Wednesday, January 27, 2021 21:50
>> To: dev@dpdk.org
>> Cc: Guo, Jia <jia.guo@intel.com>; Wang, Haiyue <haiyue.wang@intel.com>; Aaron Conole
>> <aconole@redhat.com>
>> Subject: ixgbe and UDP with zero checksum
>>
>> Hi,
>>
>> performing some tests, I noticed that on ixgbe when receiving UDP
>> packets with zero checksum (no checksum) over IPv4, the corresponding
>> ol_flag for the l4 checksum is set to PKT_RX_L4_CKSUM_BAD.
>>
>> In particular, this apparently has an impact on OvS using ct() action
>> where UDP packets with zero checksum are not tracked because of that.
>
>
>>
>> [1]
>> https://patchwork.ozlabs.org/project/netdev/patch/20090724040031.30202.1531.stgit@localhost.localdomai
>> n/
>
> About 12 years old patch, it is hardware errata. For fixing this,
> have to always disable vector Rx path for 82599, it seems not a
> good idea to bring in this workaround. :(
Just wondering that it means here - there's a user of DPDK who has an
ixgbe card exhibiting this behavior. What do DPDK engineers tell them
to do? Change the hardware? Upgrade the firmware?
> + /*
> + * 82599 errata, UDP frames with a 0 checksum can be marked as
> + * checksum errors.
> + */
> + if ((pkt_info & IXGBE_RXDADV_PKTTYPE_UDP) &&
> + (adapter->hw.mac.type == ixgbe_mac_82599EB))
> + return;
>
>>
>> Regards,
>> Paolo
next prev parent reply other threads:[~2021-01-27 18:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 13:49 Paolo Valerio
2021-01-27 17:26 ` Wang, Haiyue
2021-01-27 18:21 ` Aaron Conole [this message]
2021-01-27 21:35 ` Paolo Valerio
2021-01-29 2:02 ` Wang, Haiyue
2021-01-29 2:59 ` Wang, Haiyue
2021-01-29 14:19 ` Paolo Valerio
2021-02-02 7:41 ` Wang, Haiyue
2021-02-02 9:33 ` [dpdk-dev] 回复: " Feifei Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7tv9bii6lq.fsf@dhcp-25.97.bos.redhat.com \
--to=aconole@redhat.com \
--cc=dev@dpdk.org \
--cc=haiyue.wang@intel.com \
--cc=jia.guo@intel.com \
--cc=pvalerio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).