From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id BDF70A0096 for ; Tue, 4 Jun 2019 15:38:41 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3B9101BC89; Tue, 4 Jun 2019 15:38:40 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id D804A1BC6E; Tue, 4 Jun 2019 15:38:38 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D37113001463; Tue, 4 Jun 2019 13:38:33 +0000 (UTC) Received: from dhcp-25.97.bos.redhat.com (unknown [10.18.25.61]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BEC3A5D9D2; Tue, 4 Jun 2019 13:38:29 +0000 (UTC) From: Aaron Conole To: David Marchand Cc: dev@dpdk.org, thomas@monjalon.net, msantana@redhat.com, stable@dpdk.org, Reshma Pattan References: <1559638792-8608-1-git-send-email-david.marchand@redhat.com> <1559638792-8608-8-git-send-email-david.marchand@redhat.com> Date: Tue, 04 Jun 2019 09:38:29 -0400 In-Reply-To: <1559638792-8608-8-git-send-email-david.marchand@redhat.com> (David Marchand's message of "Tue, 4 Jun 2019 10:59:45 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Tue, 04 Jun 2019 13:38:38 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 07/14] test/latencystats: fix stack smashing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" David Marchand writes: > Caught in one Travis run: > + ------------------------------------------------------- + > + Test Suite : Latency Stats Unit Test Suite > + ------------------------------------------------------- + > + TestCase [ 0] : test_latency_init succeeded > + TestCase [ 1] : test_latency_update succeeded > [snip] > + TestCase [1601724781] : test_latencystats_get_names succeeded > [snip] > + Tests Failed : 1601790830 > > htonl(1601724781) -> "m", "a", "x", "_" > htonl(1601790830) -> "n", "c", "y", "_" > > Looks like someone went too far. > > The test passes a bigger size than the array it passes along. > > Fixes: 1e3676a06e4c ("test/latency: add unit tests for latencystats library") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand > --- Acked-by: Aaron Conole