From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 8519FCF8A for ; Thu, 23 Mar 2017 15:27:19 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9E1196A6AD; Thu, 23 Mar 2017 14:27:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 9E1196A6AD Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=aconole@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 9E1196A6AD Received: from dhcp-25-97.bos.redhat.com (unknown [10.18.25.172]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1B10B5C54E; Thu, 23 Mar 2017 14:27:19 +0000 (UTC) From: Aaron Conole To: Bruce Richardson Cc: dev@dpdk.org, Thomas Monjalon , Stephen Hemminger References: <20170322201940.24028-1-aconole@redhat.com> <20170322201940.24028-3-aconole@redhat.com> <20170323134730.GA8688@bricha3-MOBL3.ger.corp.intel.com> Date: Thu, 23 Mar 2017 10:27:18 -0400 In-Reply-To: <20170323134730.GA8688@bricha3-MOBL3.ger.corp.intel.com> (Bruce Richardson's message of "Thu, 23 Mar 2017 13:47:31 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Thu, 23 Mar 2017 14:27:19 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v7 02/14] eal: do not panic when CPU isn't supported X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Mar 2017 14:27:19 -0000 Bruce Richardson writes: > On Wed, Mar 22, 2017 at 04:19:28PM -0400, Aaron Conole wrote: >> This adds a new API to check for the eal cpu versions. >> >> It's now possible to gracefully exit the application, or for >> applications which support non-dpdk datapaths working in concert with >> DPDK datapaths, there no longer is the possibility of exiting for >> unsupported CPUs. >> >> Signed-off-by: Aaron Conole > > I think we should mark the old function as deprecated or else delete it > entirely. It was technically public, but I suspect it was only ever used > by the EAL init, so I'd look to get rid of it ASAP rather than leave it > hanging around unneeded. Okay, I'll submit a follow on patch after this is accepted to mark it as deprecated. I agree, I don't know of any application using it (though I looked at MoonGen, ovs, and warp17). > /Bruce