From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1689EA046B for ; Fri, 23 Aug 2019 17:49:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 898E91BFE9; Fri, 23 Aug 2019 17:49:10 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 30D261BFDB for ; Fri, 23 Aug 2019 17:49:08 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7EE803082131; Fri, 23 Aug 2019 15:49:07 +0000 (UTC) Received: from dhcp-25.97.bos.redhat.com (unknown [10.18.25.8]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A05816012D; Fri, 23 Aug 2019 15:49:06 +0000 (UTC) From: Aaron Conole To: Ray Kinsella Cc: dev@dpdk.org, bruce.richardson@intel.com, vladimir.medvedkin@intel.com, john.mcnamara@intel.com, marko.kovacevic@intel.com References: <20190822160717.13584-1-mdr@ashroe.eu> Date: Fri, 23 Aug 2019 11:49:05 -0400 In-Reply-To: <20190822160717.13584-1-mdr@ashroe.eu> (Ray Kinsella's message of "Thu, 22 Aug 2019 17:07:15 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Fri, 23 Aug 2019 15:49:07 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v2 0/2] add abi version testing to app/test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Ray Kinsella writes: > This patchset adds ABI version testing to the app/test unit test framework, > addressing two issues previously raised during ML conversations on ABI > stability; > > 1. How do we unit test still supported previous ABI versions? > 2. How to we unit test inline functions from still supported previous ABI > versions? > > Starting with rte_lpm, I did the following:- > > * I reproduced mostly unmodified unit tests for the v2.0 ABI, taken from DPDK > 2.2 and 17.02. > * I reproduced the rte_lpm interface header from v2.0, including the inline > functions and remapping symbols to their appropriate versions. > * I added support for multiple abi versions to the app/test unit test framework > to allow users to switch between abi versions (set_abi_version), without > further polluting the already long list of unit tests available in app/test. > > The intention here is that in future as developers need to deprecate APIs, the > associated unit tests may move into the ABI version testing mechanism of the > app/test instead of being replaced by the latest set of unit tests as would be > the case today. > > v2: > > * Added LPM IPv6 test cases for the v2.0 ABI. > * Fixed a number of checkpatch errors, stop short of substantially reworking > the test code from the v2.0 ABI. > * Removed duplicating test cases published in the original v1 patch. Thanks for this work. I think it's useful. I see an error under aarch64 builds because there are some x86_64 specific types being used in the testing. See: https://travis-ci.com/ovsrobot/dpdk/builds/124254699 > Ray Kinsella (2): > app/test: add abi version testing functionality > app/test: lpm abi version testing > > app/test/Makefile | 12 +- > app/test/commands.c | 131 +- > app/test/meson.build | 6 + > app/test/test.c | 2 + > app/test/test.h | 48 +- > app/test/test_lpm.c | 3 +- > app/test/test_lpm6.c | 2 +- > app/test/test_lpm_perf.c | 293 +--- > app/test/test_lpm_routes.c | 287 ++++ > app/test/test_lpm_routes.h | 25 + > app/test/v2.0/dcompat.h | 30 + > app/test/v2.0/rte_lpm.h | 451 +++++ > app/test/v2.0/rte_lpm6.h | 198 +++ > app/test/v2.0/test_lpm.c | 1139 +++++++++++++ > app/test/v2.0/test_lpm6.c | 1748 ++++++++++++++++++++ > app/test/v2.0/test_lpm6_perf.c | 179 ++ > app/test/v2.0/test_lpm_perf.c | 212 +++ > app/test/v2.0/test_v20.c | 14 + > doc/guides/contributing/versioning.rst | 4 + > lib/librte_eal/common/include/rte_compat.h | 7 + > 20 files changed, 4471 insertions(+), 320 deletions(-) > create mode 100644 app/test/test_lpm_routes.c > create mode 100644 app/test/test_lpm_routes.h > create mode 100644 app/test/v2.0/dcompat.h > create mode 100644 app/test/v2.0/rte_lpm.h > create mode 100644 app/test/v2.0/rte_lpm6.h > create mode 100644 app/test/v2.0/test_lpm.c > create mode 100644 app/test/v2.0/test_lpm6.c > create mode 100644 app/test/v2.0/test_lpm6_perf.c > create mode 100644 app/test/v2.0/test_lpm_perf.c > create mode 100644 app/test/v2.0/test_v20.c