From: Aaron Conole <aconole@redhat.com>
To: Nicolas Chautru <nicolas.chautru@intel.com>
Cc: akhil.goyal@nxp.com, dev@dpdk.org, ferruh.yigit@intel.com,
thomas@monjalon.net, amr.mokhtar@intel.com,
kamilx.chalupnik@intel.com
Subject: Re: [dpdk-dev] [PATCH v6 3/3] baseband/turbo_sw: meson build support for PMD driver
Date: Wed, 19 Jun 2019 20:05:37 -0400 [thread overview]
Message-ID: <f7ty31xjf3i.fsf@dhcp-25.97.bos.redhat.com> (raw)
In-Reply-To: <1560964274-83070-4-git-send-email-nicolas.chautru@intel.com> (Nicolas Chautru's message of "Wed, 19 Jun 2019 10:11:14 -0700")
Nicolas Chautru <nicolas.chautru@intel.com> writes:
> Turbo_sw PMD driver now building with meson/ninja
> with or without SDK libraries.
>
> Acked-by: Kamil Chalupnik <kamilx.chalupnik@intel.com>
> Acked-by: Nicolas Chautru <nicolas.chautru@intel.com>
It seems strange to ack your own patch.
> Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
> ---
Something is wrong with this series:
https://travis-ci.com/ovsrobot/dpdk/builds/116170401
We cannot enable this on AARCH64 builds - it seems that it wants to take
advantage of facilities that are x86 specific (like SSE 4.2)
> drivers/baseband/meson.build | 2 +-
> drivers/baseband/turbo_sw/meson.build | 30 ++++++++++++++++++++++++++++++
> meson_options.txt | 2 ++
> 3 files changed, 33 insertions(+), 1 deletion(-)
> create mode 100644 drivers/baseband/turbo_sw/meson.build
>
> diff --git a/drivers/baseband/meson.build b/drivers/baseband/meson.build
> index 52489df..40a87d2 100644
> --- a/drivers/baseband/meson.build
> +++ b/drivers/baseband/meson.build
> @@ -1,7 +1,7 @@
> # SPDX-License-Identifier: BSD-3-Clause
> # Copyright(c) 2018 Luca Boccassi <bluca@debian.org>
>
> -drivers = ['null']
> +drivers = ['null', 'turbo_sw']
>
> config_flag_fmt = 'RTE_LIBRTE_@0@_PMD'
> driver_name_fmt = 'rte_pmd_@0@'
> diff --git a/drivers/baseband/turbo_sw/meson.build b/drivers/baseband/turbo_sw/meson.build
> new file mode 100644
> index 0000000..9b4fe34
> --- /dev/null
> +++ b/drivers/baseband/turbo_sw/meson.build
> @@ -0,0 +1,30 @@
> +# SPDX-License-Identifier: BSD-3-Clause
> +# Copyright(c) 2019 Intel Corporation
> +
> +path = get_option('flexran_sdk')
> +
> +if dpdk_conf.has('RTE_BBDEV_SDK_AVX2')
> + lib = cc.find_library('libturbo', dirs: [path + '/lib_turbo'], required: false)
> + if not lib.found()
> + build = false
> + else
> + ext_deps += cc.find_library('libturbo', dirs: [path + '/lib_turbo'], required: true)
> + ext_deps += cc.find_library('libcrc', dirs: [path + '/lib_crc'], required: true)
> + ext_deps += cc.find_library('librate_matching', dirs: [path + '/lib_rate_matching'], required: true)
> + ext_deps += cc.find_library('libcommon', dirs: [path + '/lib_common'], required: true)
> + ext_deps += cc.find_library('libstdc++', required: true)
> + ext_deps += cc.find_library('libirc', required: true)
> + ext_deps += cc.find_library('libimf', required: true)
> + ext_deps += cc.find_library('libipps', required: true)
> + ext_deps += cc.find_library('libsvml', required: true)
> + includes += include_directories(path + '/lib_turbo')
> + includes += include_directories(path + '/lib_crc')
> + includes += include_directories(path + '/lib_rate_matching')
> + includes += include_directories(path + '/lib_common')
> + endif
> +endif
> +
> +deps += ['bbdev', 'bus_vdev', 'ring']
> +name = 'bbdev_turbo_sw'
> +allow_experimental_apis = true
> +sources = files('bbdev_turbo_software.c')
> diff --git a/meson_options.txt b/meson_options.txt
> index 16d9f92..92d3e97 100644
> --- a/meson_options.txt
> +++ b/meson_options.txt
> @@ -10,6 +10,8 @@ option('enable_kmods', type: 'boolean', value: true,
> description: 'build kernel modules')
> option('examples', type: 'string', value: '',
> description: 'Comma-separated list of examples to build by default')
> +option('flexran_sdk', type: 'string', value: '',
> + description: 'Path to FlexRAN SDK optional Libraries for BBDEV device')
> option('ibverbs_link', type: 'combo', choices : ['shared', 'dlopen'], value: 'shared',
> description: 'Linkage method (shared/dlopen) for Mellanox PMDs with ibverbs dependencies.')
> option('include_subdir_arch', type: 'string', value: '',
next prev parent reply other threads:[~2019-06-20 0:05 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-05 17:38 [dpdk-dev] [PATCH] BBDEV turbo_sw PMD compilation fix Nicolas Chautru
2019-06-05 17:38 ` [dpdk-dev] [PATCH] baseband/turbo_sw: Option to build turbosw PMD without SDK Nicolas Chautru
2019-06-05 17:47 ` Thomas Monjalon
2019-06-05 20:06 ` [dpdk-dev] [PATCH v2 0/3] BBDEV turbo_sw PMD compilation fix Nicolas Chautru
2019-06-05 20:06 ` [dpdk-dev] [PATCH v2 1/3] version: 19.05-rc4 Nicolas Chautru
2019-06-05 20:06 ` [dpdk-dev] [PATCH v2 2/3] baseband/turbo_sw: option to build turbosw PMD without SDK Nicolas Chautru
2019-06-05 20:06 ` [dpdk-dev] [PATCH v2 3/3] docs/guides: updating turbo_sw building steps Nicolas Chautru
2019-06-05 20:10 ` [dpdk-dev] [PATCH v2 0/3] BBDEV turbo_sw PMD compilation fix Nicolas Chautru
2019-06-05 20:10 ` [dpdk-dev] [PATCH v2 1/3] baseband/turbo_sw: option to build turbosw PMD without SDK Nicolas Chautru
2019-06-05 20:10 ` [dpdk-dev] [PATCH v2 2/3] docs/guides: updating turbo_sw building steps Nicolas Chautru
2019-06-06 10:34 ` Ferruh Yigit
2019-06-06 17:03 ` Chautru, Nicolas
2019-06-05 20:10 ` [dpdk-dev] [PATCH v2 3/3] baseband/turbo_sw: meson build support for PMD driver Nicolas Chautru
2019-06-05 21:20 ` [dpdk-dev] [PATCH v2 0/3] baseband/fpga_lte_fec: adding driver for FEC on FPGA Nicolas Chautru
2019-06-05 21:20 ` [dpdk-dev] [PATCH v2 1/3] " Nicolas Chautru
2019-06-06 9:04 ` [dpdk-dev] [PATCH v3] " Nicolas Chautru
2019-06-06 9:04 ` Nicolas Chautru
2019-06-08 0:17 ` [dpdk-dev] [PATCH v4] " Nicolas Chautru
2019-06-08 0:17 ` Nicolas Chautru
2019-06-10 17:01 ` Nicolas Chautru
2019-06-10 17:01 ` Nicolas Chautru
[not found] ` <EEA9FF629BF25B47BD67ADE995041EE2496A888B@IRSMSX103.ger.corp.intel.com>
2019-06-13 17:05 ` Chautru, Nicolas
2019-06-13 17:28 ` [dpdk-dev] [PATCH v5] " Nicolas Chautru
2019-06-13 17:28 ` Nicolas Chautru
2019-06-14 16:12 ` [dpdk-dev] [PATCH v6] " Nicolas Chautru
2019-06-14 16:12 ` [dpdk-dev] [PATCH v5] " Nicolas Chautru
2019-06-14 16:17 ` [dpdk-dev] [PATCH v6] " Nicolas Chautru
2019-06-14 16:17 ` Nicolas Chautru
2019-06-19 15:20 ` Chautru, Nicolas
[not found] ` <EEA9FF629BF25B47BD67ADE995041EE2496B2975@IRSMSX103.ger.corp.intel.com>
2019-06-20 13:35 ` Ferruh Yigit
2019-06-25 12:37 ` Akhil Goyal
2019-06-06 10:17 ` [dpdk-dev] [PATCH v3 0/3] BBDEV turbo_sw PMD compilation fix Nicolas Chautru
2019-06-06 10:17 ` [dpdk-dev] [PATCH v3 1/3] baseband/turbo_sw: option to build turbosw PMD without SDK Nicolas Chautru
2019-06-07 23:54 ` [dpdk-dev] [PATCH v4 0/3] BBDEV turbo_sw PMD compilation fix Nicolas Chautru
2019-06-07 23:54 ` [dpdk-dev] [PATCH v4 1/3] baseband/turbo_sw: option to build turbosw PMD without SDK Nicolas Chautru
2019-06-13 16:51 ` [dpdk-dev] [PATCH v5 0/3] BBDEV turbo_sw PMD compilation fix Nicolas Chautru
2019-06-13 16:51 ` [dpdk-dev] [PATCH v5 1/3] baseband/turbo_sw: option to build turbosw PMD without SDK Nicolas Chautru
2019-06-19 17:11 ` [dpdk-dev] [PATCH v6 0/3] BBDEV turbo_sw PMD compilation fix Nicolas Chautru
2019-06-19 17:11 ` [dpdk-dev] [PATCH v6 1/3] baseband/turbo_sw: option to build turbosw PMD without SDK Nicolas Chautru
2019-06-19 17:48 ` [dpdk-dev] [PATCH v7 0/3] BBDEV turbo_sw PMD compilation fix Nicolas Chautru
2019-06-19 17:48 ` [dpdk-dev] [PATCH v7 1/3] baseband/turbo_sw: option to build turbosw PMD without SDK Nicolas Chautru
2019-06-20 22:42 ` Mokhtar, Amr
2019-06-19 17:48 ` [dpdk-dev] [PATCH v7 2/3] docs/guides: updating turbo_sw building steps Nicolas Chautru
2019-07-07 8:59 ` Thomas Monjalon
2019-06-19 17:48 ` [dpdk-dev] [PATCH v7 3/3] baseband/turbo_sw: meson build support for PMD driver Nicolas Chautru
2019-06-20 17:33 ` [dpdk-dev] [PATCH v7 0/3] BBDEV turbo_sw PMD compilation fix Ferruh Yigit
2019-06-25 12:41 ` Akhil Goyal
2019-06-19 17:11 ` [dpdk-dev] [PATCH v6 2/3] docs/guides: updating turbo_sw building steps Nicolas Chautru
2019-06-19 17:11 ` [dpdk-dev] [PATCH v6 3/3] baseband/turbo_sw: meson build support for PMD driver Nicolas Chautru
2019-06-20 0:05 ` Aaron Conole [this message]
2019-06-20 0:34 ` Chautru, Nicolas
2019-06-13 16:51 ` [dpdk-dev] [PATCH v5 2/3] docs/guides: updating turbo_sw building steps Nicolas Chautru
2019-06-13 16:51 ` [dpdk-dev] [PATCH v5 3/3] baseband/turbo_sw: meson build support for PMD driver Nicolas Chautru
2019-06-07 23:54 ` [dpdk-dev] [PATCH v4 2/3] docs/guides: updating turbo_sw building steps Nicolas Chautru
2019-06-07 23:54 ` [dpdk-dev] [PATCH v4 3/3] baseband/turbo_sw: meson build support for PMD driver Nicolas Chautru
2019-06-06 10:17 ` [dpdk-dev] [PATCH v3 2/3] docs/guides: updating turbo_sw building steps Nicolas Chautru
2019-06-06 10:17 ` [dpdk-dev] [PATCH v3 3/3] baseband/turbo_sw: meson build support for PMD driver Nicolas Chautru
2019-06-05 21:20 ` [dpdk-dev] [PATCH v2 2/3] doc/guides: documentation for the FPGA BBDEV PMD Nicolas Chautru
2019-06-05 21:21 ` [dpdk-dev] [PATCH v2 3/3] baseband/fpga_lte_fec: meson support Nicolas Chautru
2019-06-06 8:25 ` Bruce Richardson
2019-06-06 10:16 ` Ferruh Yigit
2019-06-06 16:39 ` Chautru, Nicolas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7ty31xjf3i.fsf@dhcp-25.97.bos.redhat.com \
--to=aconole@redhat.com \
--cc=akhil.goyal@nxp.com \
--cc=amr.mokhtar@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=kamilx.chalupnik@intel.com \
--cc=nicolas.chautru@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).