DPDK patches and discussions
 help / color / mirror / Atom feed
From: Aaron Conole <aconole@redhat.com>
To: "Juraj Linkeš" <juraj.linkes@pantheon.tech>
Cc: thomas@monjalon.net, david.marchand@redhat.com,
	maicolgabriel@hotmail.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] ci: add vm jobs for aarch64 builds with tests
Date: Fri, 11 Sep 2020 09:25:22 -0400	[thread overview]
Message-ID: <f7tzh5wtph9.fsf@dhcp-25.97.bos.redhat.com> (raw)
In-Reply-To: <1598615137-16401-1-git-send-email-juraj.linkes@pantheon.tech> ("Juraj \=\?utf-8\?Q\?Linke\=C5\=A1\=22's\?\= message of "Fri, 28 Aug 2020 13:45:37 +0200")

Juraj Linkeš <juraj.linkes@pantheon.tech> writes:

> Tests requiring hugepages do not work outside of VM environment because
> of security limitations. Add aarch64 builds which run tests to run in
> a VM to avoid these limitations. Leave non-hugepage environments since
> the tests may produce different results in hugepage and non-hugepage
> environments.
>
> Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> ---

I'm okay with the change, but I wonder - does it make sense to have the
non-vm build around with these?  The builds you're adding cover all the
cases of the container build, and add the additional hugepage tests.

Maybe we should drop the other tests?  It can be a follow up patch, WDYT?

Acked-by: Aaron Conole <aconole@redhat.com>

>  .travis.yml | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>
> diff --git a/.travis.yml b/.travis.yml
> index d6eeab371..5e12db23b 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -90,6 +90,12 @@ jobs:
>    - env: DEF_LIB="shared" RUN_TESTS=1
>      arch: arm64
>      compiler: gcc
> +  - env: DEF_LIB="shared" RUN_TESTS=1
> +    dist: focal
> +    arch: arm64-graviton2
> +    virt: vm
> +    group: edge
> +    compiler: gcc
>    - env: DEF_LIB="shared" BUILD_DOCS=1
>      arch: arm64
>      compiler: gcc
> @@ -105,3 +111,9 @@ jobs:
>    - env: DEF_LIB="shared" RUN_TESTS=1
>      arch: arm64
>      compiler: clang
> +  - env: DEF_LIB="shared" RUN_TESTS=1
> +    dist: focal
> +    arch: arm64-graviton2
> +    virt: vm
> +    group: edge
> +    compiler: clang


  parent reply	other threads:[~2020-09-11 13:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-25  7:08 [dpdk-dev] [PATCH] ci: enable vm env for aarch64 builds Juraj Linkeš
2020-08-25 14:18 ` Aaron Conole
2020-08-26  6:14   ` Juraj Linkeš
2020-08-27  8:51   ` Juraj Linkeš
2020-08-28 11:45 ` [dpdk-dev] [PATCH v2] ci: add vm jobs for aarch64 builds with tests Juraj Linkeš
2020-09-01  7:15   ` Ruifeng Wang
2020-09-11 13:25   ` Aaron Conole [this message]
2020-09-16  8:03     ` Juraj Linkeš
2020-10-01  6:49   ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f7tzh5wtph9.fsf@dhcp-25.97.bos.redhat.com \
    --to=aconole@redhat.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=juraj.linkes@pantheon.tech \
    --cc=maicolgabriel@hotmail.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).