From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 829A3A0487 for ; Mon, 1 Jul 2019 14:05:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9194F4D27; Mon, 1 Jul 2019 14:05:48 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id AF60E325F for ; Mon, 1 Jul 2019 14:05:46 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D2AAA36887; Mon, 1 Jul 2019 12:05:23 +0000 (UTC) Received: from dhcp-25.97.bos.redhat.com (ovpn-120-240.rdu2.redhat.com [10.10.120.240]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F301417D32; Mon, 1 Jul 2019 12:05:11 +0000 (UTC) From: Aaron Conole To: David Marchand Cc: Thomas Monjalon , Michael Santana , dev , Neil Horman , Adrien Mazarguil , Stephen Hemminger References: <1561635235-22238-1-git-send-email-david.marchand@redhat.com> <1561809533-6545-1-git-send-email-david.marchand@redhat.com> <1561809533-6545-11-git-send-email-david.marchand@redhat.com> <3633624.cieMKMvx7x@xps> Date: Mon, 01 Jul 2019 08:05:10 -0400 In-Reply-To: (David Marchand's message of "Sat, 29 Jun 2019 18:39:32 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Mon, 01 Jul 2019 12:05:46 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v2 10/10] enforce __rte_experimental at the start of symbol declarations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" David Marchand writes: > On Sat, Jun 29, 2019 at 6:14 PM Thomas Monjalon wrote: > > 29/06/2019 13:58, David Marchand: > > Special mention for rte_mbuf_data_addr_default(): > > > > There is either a bug or a (not yet understood) issue with gcc. > > gcc won't drop this inline when unused and rte_mbuf_data_addr_default() > > calls rte_mbuf_buf_addr() which itself is experimental. > > This results in a build warning when not accepting experimental apis > > from sources just including rte_mbuf.h. > > > > For this specific case, we hide the call to rte_mbuf_buf_addr() under > > the ALLOW_EXPERIMENTAL_API flag. > [...] > > -static inline char * __rte_experimental > > -rte_mbuf_data_addr_default(struct rte_mbuf *mb) > > +__rte_experimental > > +static inline char * > > +rte_mbuf_data_addr_default(struct rte_mbuf *mb __rte_unused) > > { > > + /* gcc complains about calling this experimental function even > > + * when not using it. Hide it with ALLOW_EXPERIMENTAL_API. > > + */ > > +#ifdef ALLOW_EXPERIMENTAL_API > > return rte_mbuf_buf_addr(mb, mb->pool) + RTE_PKTMBUF_HEADROOM; > > +#else > > + return NULL; > > +#endif > > } > > Doxygen is confused by having __rte_unused at the end: > > lib/librte_mbuf/rte_mbuf.h:876: warning: > argument 'mb' of command @param is not found in the argument list of > rte_mbuf_data_addr_default(struct rte_mbuf *mb __rte_unused) > lib/librte_mbuf/rte_mbuf.h:889: warning: > The following parameters of > rte_mbuf_data_addr_default(struct rte_mbuf *mb __rte_unused) > are not documented: > parameter '__rte_unused' > > I move __rte_unused at the beginning while merging. > > Indeed. > Thanks for catching and fixing. > > Consequently, could we have the documentation (html only?) generated in the CI if it is not too time > consuming. > WDYT Aaron, Michael? Just as a check that it will generate? I think it's a good idea. I am thinking that having it uploaded somewhere might be more involved, but not sure.