From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id BFC151B29E for ; Tue, 17 Oct 2017 20:18:04 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E833B3E2DB; Tue, 17 Oct 2017 18:18:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com E833B3E2DB Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=aconole@redhat.com Received: from dhcp-25-97.bos.redhat.com (unknown [10.18.25.172]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9357D6DACE; Tue, 17 Oct 2017 18:18:03 +0000 (UTC) From: Aaron Conole To: Gaetan Rivet Cc: dev@dpdk.org References: Date: Tue, 17 Oct 2017 14:18:02 -0400 In-Reply-To: (Gaetan Rivet's message of "Thu, 12 Oct 2017 10:21:07 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Tue, 17 Oct 2017 18:18:04 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v2 00/18] devargs cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Oct 2017 18:18:05 -0000 Gaetan Rivet writes: > The use of rte_devargs is inconsistent in the light of new functionalities > such as device hotplug. > > Most of its API is still experimental and needs stabilization. > Older functions were deprecated and need to be rewritten or removed. > The rte_devtype is meant to disappear. > > v2: > > Big rework. > > * Enact requiring bus name prepended in rte_devargs parsing functions. > * Remove rte_devtype. Use new probe mode setter along with generic > bus reference within rte_devargs. > * Rework devargs parsing API. > The function is now variadic, does not enforce bus rules on the devargs > being inserted as the bus has been configured previously. > Old parsing function is removed. > * Expose bus guessing from device name. > This uses the "parse" bus operator, which may be meant to disappear. > This is optional, but nice to have in a transition period. > * Introduce new --dev generic device declaration parameter. > > This patchset depends on: It is weird to me that you introduce patch sets, and then introduce cleanups later? Shouldn't we revise the existing patchsets? Maybe I missed a discussion somewhere? > Move PCI away from the EAL > http://dpdk.org/ml/archives/dev/2017-August/073512.html > > Bus control framework > http://dpdk.org/ml/archives/dev/2017-October/078752.html > > Gaetan Rivet (18): > eal: prepend busname on legacy device declaration > eal: remove generic devtype > devargs: introduce iterator > devargs: introduce foreach macro > vdev: do not reference devargs list > bus/pci: do not reference devargs list > test: remove devargs unit tests > devargs: make devargs list private > devargs: make parsing variadic > devargs: require bus name prefix > devargs: simplify implementation > eal: add generic device declaration parameter > bus: make device recognition function public > net/failsafe: keep legacy sub-device declaration > ether: use new devargs parsing function > devargs: remove old devargs parsing function > devargs: use proper prefix > doc: remove devargs deprecation notices > > MAINTAINERS | 1 - > app/test-pmd/cmdline.c | 2 +- > doc/guides/rel_notes/deprecation.rst | 13 --- > drivers/bus/pci/pci_common.c | 22 +--- > drivers/net/failsafe/failsafe_args.c | 11 +- > examples/bond/main.c | 2 +- > lib/librte_eal/bsdapp/eal/rte_eal_version.map | 15 ++- > lib/librte_eal/common/eal_common_dev.c | 39 ++----- > lib/librte_eal/common/eal_common_devargs.c | 129 +++++++++-------------- > lib/librte_eal/common/eal_common_options.c | 47 ++++++--- > lib/librte_eal/common/eal_common_vdev.c | 11 +- > lib/librte_eal/common/eal_options.h | 2 + > lib/librte_eal/common/include/rte_bus.h | 12 +++ > lib/librte_eal/common/include/rte_dev.h | 8 -- > lib/librte_eal/common/include/rte_devargs.h | 120 ++++++++-------------- > lib/librte_eal/linuxapp/eal/rte_eal_version.map | 15 ++- > lib/librte_ether/rte_ethdev.c | 11 +- > test/test/Makefile | 1 - > test/test/commands.c | 2 +- > test/test/test_devargs.c | 131 ------------------------ > 20 files changed, 186 insertions(+), 408 deletions(-) > delete mode 100644 test/test/test_devargs.c