From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AAD1441D40; Wed, 22 Feb 2023 17:33:40 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9A77B4305E; Wed, 22 Feb 2023 17:33:40 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id DB66943021 for ; Wed, 22 Feb 2023 17:33:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677083619; x=1708619619; h=message-id:date:subject:to:references:from:in-reply-to: content-transfer-encoding:mime-version; bh=jxzBo77HlIz0O12zctRdF8E+QTgGbNEzB9G287Xs5ko=; b=R489Yz17Jqp8vwkqeOLnDt9PYJ8lGBrL65DOv4Wbq5etLiQH5GFprKB9 bXP7rOJo3G+XAf50rM++uN2WlOxmKZQ9HRwi/doE2GUsi5UEypb/QoDkU lG2g2iVJ6Ebi/LXwBlKAXHvLtRCH50+NWgBMZ/CAqIiolUcd6CyCivxfX Qz/3gJW2sHko+5pFNa8I2GTmPxYnJfBw/y3ouhhC86HDXI5IGJt1Bm3Zp Y+AbVpj/qOrVWxG/IMI0ar3/wbMGbAvamL+LzE1It2WtCWnKaqxpLCBSM fK195546v/e96HITTiUobskV4cXXwhi0B3iUqCGEicbJyTWYHXuYd65cf Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10629"; a="360454117" X-IronPort-AV: E=Sophos;i="5.97,319,1669104000"; d="scan'208";a="360454117" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2023 08:33:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10629"; a="621965809" X-IronPort-AV: E=Sophos;i="5.97,319,1669104000"; d="scan'208";a="621965809" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga003.jf.intel.com with ESMTP; 22 Feb 2023 08:33:36 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 22 Feb 2023 08:33:35 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 22 Feb 2023 08:33:35 -0800 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.40) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 22 Feb 2023 08:33:35 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hOm5oqsgyMOeCKOe+3Ky+nOmBRVNFmiTNO9CGCldealPUCewgms+Tfd4+/DpuDVTis8YsOilxZK87VipRXk6mGdiJmCLpFZW7JLzXNOuFx0s3tRNrvmv6lyxMWmuAuZJBP8l4Z8XOiqVeKHWerVpVWyB+onbmmofNyoTnypw4uZ0d8GYMZ6Sr+rKCAdWfkZf+yBg51bAR3+GRXg6xnFBWPE6CjZdk5/qW7Bfrle/Q1R/Q+3YnZbC/klxI7E8JssUVCjTIQxbKpB1ISTtPKbyyfjbDj7EkmUNQvDnvI1DjQoPp7VjFiQmnwups0DTo+IApq3Um4MJEIlL4FH/kZbmzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cWk/bFzo45OAVw3thWuauSliuYbMnrdloJ4f4roMBxI=; b=fLmjVY1qt3OKYGl0GiEqhMoUChT+LoIFmCpNbmOjBHlOeUiGOdikzCXSYeJ2F+di4iLiScTlv7BRv0gLaofvZEfkhB9753Zw6UYj5ddzELUh6Cvmksgw6//MhSNg/FsN8Lq6Ls/QW3yLnvp6VJtPkN9jv35DnGtDhS+bwolWQgyLb1dglY3Tw7PfXDI6/YBEYM5Un/+cWNPJdfEdoHLD8MbLYJr9TTLtMTjdchWZuo5G0GBlVfhFIb91aa0RcxVdK1M/GqJVJZKZPij18npR8VdKrBMZSZPAy1FfNBAR/oqvxtxUktiEqhKbQcPNmliE4efyFaRE3cU30+tuF2V9ig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from BYAPR11MB3799.namprd11.prod.outlook.com (2603:10b6:a03:fb::19) by BN9PR11MB5388.namprd11.prod.outlook.com (2603:10b6:408:11d::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.19; Wed, 22 Feb 2023 16:33:33 +0000 Received: from BYAPR11MB3799.namprd11.prod.outlook.com ([fe80::4242:36e2:5a81:ff49]) by BYAPR11MB3799.namprd11.prod.outlook.com ([fe80::4242:36e2:5a81:ff49%7]) with mapi id 15.20.6111.021; Wed, 22 Feb 2023 16:33:33 +0000 Message-ID: Date: Wed, 22 Feb 2023 16:33:27 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v9 08/22] examples/l3fwd-power: replace use of RTE_LOGTYPE_POWER Content-Language: en-US To: Stephen Hemminger , References: <20230207204151.1503491-1-stephen@networkplumber.org> <20230221190208.514276-1-stephen@networkplumber.org> <20230221190208.514276-9-stephen@networkplumber.org> From: "Hunt, David" In-Reply-To: <20230221190208.514276-9-stephen@networkplumber.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P123CA0023.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:a6::35) To BYAPR11MB3799.namprd11.prod.outlook.com (2603:10b6:a03:fb::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR11MB3799:EE_|BN9PR11MB5388:EE_ X-MS-Office365-Filtering-Correlation-Id: c677ab01-c407-4384-47d0-08db14f289d7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4N69q4IUq2QsIb43VuPubju2ziDmYU0wGxcmndy58CbBA7M3Q0edewzUfVE3BPPgGWXFJ5dLuDgb87rcEhLLuQBwYUvG6yCCXOgQ7RX7dvc/Dq1lEntfVgICltCqgCbredTPfH6P2+U2oZ6J0ql6mkdJNADQnTsaEtgHx9rhhixRChGF125gIN4+2dzrcGFIkYa40aGwHZWLSsycnxtFB0Ss/jGj+pWvCjyZt7NI6fD0N0R6AAHY7LEWKrE4aXOAkDD9v3pwIVXb39UDJRh9YbMUO2sg3/tOGKE00ItPjlfWki3KQ5F4fZnPvTc6m+I+q136d8q5tksl+beirjTQwsGMA0HEnpybaArVPfyCUaXFkaIq7hv1O2abCz9SYxrZyS0M8g9GpeketEQedxbcXCeJqrwEdZs9pn+s+LXwoyEO0JCEV/2K1hYKt8pp23cQW/xuuhwS2q77R5/AYE9aLNWgCMlSJ30QJPK2VJ1InQ11ubBid9t8lhh3CwRqJKyeCUs48qkLnCx34Ii08M0gFUlU1SHaPh2n7iwy3SiBeYgZyl9bhCrUJkKAwFzrZHH+CKCL1kbPYqdMNSoChymfN6uyJb1z32vGx0Uf3ZCUWhBlEhEb+fEiFgoFkum9cBmbsSvNW3ZtBfZQMzrViZQJMR/NUxbGlN83pUKyOnZDE7c7SwAH0jeTTL9oSNLYC61sB7z65ZQYe+SP4GyvUYKP42Fjxy7Be35HCKD42Gki8yk= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3799.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(39860400002)(136003)(396003)(346002)(376002)(366004)(451199018)(6486002)(31686004)(83380400001)(2906002)(36756003)(5660300002)(31696002)(41300700001)(478600001)(86362001)(6512007)(6666004)(8936002)(53546011)(38100700002)(2616005)(26005)(186003)(6506007)(82960400001)(66476007)(66946007)(66556008)(8676002)(316002)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RW1zcERIWVVidTBEcmxiTzRSMXBrd3VjWU1HczVtYWN3Mm5KbjFJTzJKSncw?= =?utf-8?B?eHY4UVpJYTEyL3dBUitrdzIyQU9QQUhVTHlQcnFHTVJ2Q2pRaGFieCthSklm?= =?utf-8?B?VDY4M1QyRk11RUxramRYVklJYitEa1VLWUhyRjZRd0V3d3k4YnRNL254Z1N6?= =?utf-8?B?TjNLc2M3SVR6a2p5aDZaanRNQzh6eSszMXUzU1BvMFNVS1FpdW1xdDZZRGNN?= =?utf-8?B?OEdIa1E0STlCRlZjWXpjZTN2N2hZdVBDZFJrY3BreGl5MHpkdHR0QWowWnV6?= =?utf-8?B?clZ2WjNpSW5oYmc2YUVoQ2YrWXlPSVhhYitXY2RYWXduNS81c2xtTi9yRnNl?= =?utf-8?B?UlZONjJZOUFXK1Z3M2o3Z0ozeGV5WGZ6TU9hT0xtNEFmQys4V1lDTXhRRFB4?= =?utf-8?B?bEhHZkpyZk1WRDFzRENqcWxpQXZNa2lUT2NOc085QkxJQnRTQUhYTFNOZW5G?= =?utf-8?B?ZW8xLytFaEtzUlhZRmFzcTA5RjlkYjVLeWVlUmpMWU1RL1Y2MzM5Zm5VRnlC?= =?utf-8?B?STduakV6QXQ5SC9ZeUxSUzhYM3cxOTNMaXJ1alpmSGd5ZnBlQ2pzeExuU0Mv?= =?utf-8?B?RjZZVkQ4d0RKemtxR1gxQUpyYlZNdmtlYXdnT3M4SXVqUEhseHUrRHN5aDJF?= =?utf-8?B?UFYvSDZhTWlZUmFvemx3eHp0L1l6R29BZllkeVM2NEcwYmgrZzRtQ05wcTdQ?= =?utf-8?B?dTNEdmFFbE9EUkhpeUR4cFo4bUxwMzRsNU9vWVhUbGVLU2VoQ01Qb09tZVph?= =?utf-8?B?RFFDUDNlOGVBUjZYaWs4d0t3L2luZE5NNnNoMmQ5SXdBOXFuU1Y5VzdPbHl5?= =?utf-8?B?VVZXMFN3QlNwcXlGWHVCV2dTZlpQbUN0K1pLL1pFNHc2M0xvVkdzbSszcXJ5?= =?utf-8?B?QWFRMU5LZTZjaTFXcTd5S0dVKytnSG04SnNrLy9nQXNTNUs0QXFNck5uNFRT?= =?utf-8?B?ajJhR2lhR3AwTEZ3aGluTlpHbndVclZhY0EvZklsMGkrUkRya1VxR2Qwd0dU?= =?utf-8?B?TTM4RHNzNGQvMVBvZnVJem5nVmo0UEVoVHd3a2s1d2lncktBcWdMNG5mTEpX?= =?utf-8?B?N3IxZHpydVlFRjVSZ3REZDlZQTlqWFIvZzJvb28wbGxueW1lcDRWeHFJajhp?= =?utf-8?B?T3lDeVN1OG5QOFEwUHY4QlRwckk3MUhiUHh6cDJvbkN4TU9VaUZYb1dxU2FT?= =?utf-8?B?NGwwRUg1YzF3MWM2MXV3cGg0TVI3aytYOFIrMTFiWmc4TGx3QkUxRzRqU2ky?= =?utf-8?B?NGkzN3Q0c0p4UDRuUjc0cUZvL0tVQWdZVXU1MmtuQkZmRTBKaHRVcVFyVzMx?= =?utf-8?B?WDY3VGtYaWYzdk43QXNGdG1EZnVrVnNONTVMWTVyc21ndldVbUdjaFhHbFRj?= =?utf-8?B?YnlTY3dFWm9HbndMeXBtdDdSZlBjVmZRRlJlK1hUOUlFQnJQVE94WmVLNDI5?= =?utf-8?B?azNCMG9HZEhLcHl0U0lLdWRNNFpSVGdqT1R3eWhwNE1VZm9sMWQ4MksvMllJ?= =?utf-8?B?c1h4Mm1RVnRKdkthbzVQSzdCV0thaUtScGxoWTBJaTU3ZTdtK1p4SE13eFdj?= =?utf-8?B?Y2h0WVJ5cXB5K3lONEROT3cySnlVYnkwbzF6SFJwcG9aVGU4NldVM25hTFVQ?= =?utf-8?B?OFZHaCs4bExkc0laTnIyOVc2eFVib1pCRDFqU0hTR2laeGZiWkg4MXdVN3E5?= =?utf-8?B?bUlxbTluWW56RTloK3FvYnhvU1ZMYkpYSGN2SnlFRUVnN1kreXNzWWd0Qk5I?= =?utf-8?B?NGIrL08rK0R6WXk2cUxCVWQwZ3Fwa2dJelpzRzBKV0VKcTFkZ0RGME1PbThD?= =?utf-8?B?YllYZVE0WnI0ekVpSW1YU2RzQVo4czNOOWJBWWdBdEQyY2EzeEVwZ0ZtR250?= =?utf-8?B?Z2g2TW9LL0taaGNsWXRQb093ZjRNSFVYYUErZmpMaE04SEpyeHI4ZFdwNno5?= =?utf-8?B?QVgvRGNJRFl6K2U0ZXpqSnlka3ZBTDZWNng5cytvSElrc1BWcnVlbXQzbFY4?= =?utf-8?B?NS9DVWpLTHZ6dFNnekNVU0RQZnlETEVBOUpUa29kTllTbG42UUx6c2doZGhh?= =?utf-8?B?VGlsK25sQ2E0bndvWE0zcm5QZzdocDRWcm9nbnlZNGJvRWVwUjdTSWszNHp2?= =?utf-8?B?ZDNuam9CeENPNU8rT21MZFVZZmZYRlFMRmIrOHJFRVJWZiszMVpTWlZYQk9I?= =?utf-8?B?NGc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: c677ab01-c407-4384-47d0-08db14f289d7 X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3799.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2023 16:33:33.3566 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +v/kmoO452pd4prWvZ1bHTHUqyaVCp6J9SxWOUzpc3wLM9WHZ8njVP9167aigdhGn8uO863SvmOdGOxpHQiHpQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5388 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 21/02/2023 19:01, Stephen Hemminger wrote: > Convert to using a dynamic logtype for the application. > > Signed-off-by: Stephen Hemminger > --- > examples/l3fwd-power/main.c | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) > > diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c > index f57c54d2b57c..76b890b76c88 100644 > --- a/examples/l3fwd-power/main.c > +++ b/examples/l3fwd-power/main.c > @@ -51,7 +51,8 @@ > #include "perf_core.h" > #include "main.h" > > -#define RTE_LOGTYPE_L3FWD_POWER RTE_LOGTYPE_USER1 > +RTE_LOG_REGISTER(l3fwd_power_logtype, l3fwd.power, INFO); > +#define RTE_LOGTYPE_L3FWD_POWER l3fwd_power_logtype > > #define MAX_PKT_BURST 32 > > @@ -2236,7 +2237,7 @@ init_power_library(void) > /* init power management library */ > ret = rte_power_init(lcore_id); > if (ret) { > - RTE_LOG(ERR, POWER, > + RTE_LOG(ERR, L3FWD_POWER, > "Library initialization failed on core %u\n", > lcore_id); > return ret; > @@ -2245,7 +2246,7 @@ init_power_library(void) > env = rte_power_get_env(); > if (env != PM_ENV_ACPI_CPUFREQ && > env != PM_ENV_PSTATE_CPUFREQ) { > - RTE_LOG(ERR, POWER, > + RTE_LOG(ERR, L3FWD_POWER, > "Only ACPI and PSTATE mode are supported\n"); > return -1; > } > @@ -2263,7 +2264,7 @@ deinit_power_library(void) > /* deinit power management library */ > ret = rte_power_exit(lcore_id); > if (ret) { > - RTE_LOG(ERR, POWER, > + RTE_LOG(ERR, L3FWD_POWER, > "Library deinitialization failed on core %u\n", > lcore_id); > return ret; > @@ -2332,7 +2333,7 @@ update_telemetry(__rte_unused struct rte_timer *tim, > ret = rte_metrics_update_values(RTE_METRICS_GLOBAL, telstats_index, > values, RTE_DIM(values)); > if (ret < 0) > - RTE_LOG(WARNING, POWER, "failed to update metrics\n"); > + RTE_LOG(WARNING, L3FWD_POWER, "failed to update metrics\n"); > } > > static int > @@ -2381,7 +2382,7 @@ launch_timer(unsigned int lcore_id) > rte_get_main_lcore()); > } > > - RTE_LOG(INFO, POWER, "Bring up the Timer\n"); > + RTE_LOG(INFO, L3FWD_POWER, "Bring up the Timer\n"); > > telemetry_setup_timer(); > > @@ -2397,7 +2398,7 @@ launch_timer(unsigned int lcore_id) > } > } > > - RTE_LOG(INFO, POWER, "Timer_subsystem is done\n"); > + RTE_LOG(INFO, L3FWD_POWER, "Timer_subsystem is done\n"); > > return 0; > } Acked-by: David Hunt