From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <akhil.goyal@nxp.com> Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0078.outbound.protection.outlook.com [104.47.40.78]) by dpdk.org (Postfix) with ESMTP id 2D8CF7CB8 for <dev@dpdk.org>; Wed, 16 Aug 2017 09:03:26 +0200 (CEST) Received: from BN6PR03CA0010.namprd03.prod.outlook.com (10.168.230.148) by BN6PR03MB3314.namprd03.prod.outlook.com (10.174.233.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1362.18; Wed, 16 Aug 2017 07:03:25 +0000 Received: from BN1BFFO11FD003.protection.gbl (2a01:111:f400:7c10::1:194) by BN6PR03CA0010.outlook.office365.com (2603:10b6:404:23::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1341.21 via Frontend Transport; Wed, 16 Aug 2017 07:03:25 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1BFFO11FD003.mail.protection.outlook.com (10.58.144.66) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1304.16 via Frontend Transport; Wed, 16 Aug 2017 07:03:25 +0000 Received: from [10.232.134.49] (B35197-11.ap.freescale.net [10.232.134.49]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v7G73MwR002968; Wed, 16 Aug 2017 00:03:22 -0700 To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, "Doherty, Declan" <declan.doherty@intel.com> CC: "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com> References: <20170728110738.28922-1-akhil.goyal@nxp.com> <20170728110738.28922-3-akhil.goyal@nxp.com> <E115CCD9D858EF4F90C690B0DCB4D8976CBF84D9@IRSMSX108.ger.corp.intel.com> <c924f588-fb16-addc-de97-3be0237fdb23@nxp.com> <E115CCD9D858EF4F90C690B0DCB4D8976CBF8AD0@IRSMSX108.ger.corp.intel.com> From: Akhil Goyal <akhil.goyal@nxp.com> Message-ID: <f84d7bd3-e0cb-1ebe-09c1-2e5a81b3a740@nxp.com> Date: Wed, 16 Aug 2017 12:33:21 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8976CBF8AD0@IRSMSX108.ger.corp.intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131473406053477707; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(39860400002)(39380400002)(2980300002)(1109001)(1110001)(339900001)(3190300001)(199003)(13464003)(189002)(377454003)(24454002)(51914003)(77096006)(54356999)(2950100002)(189998001)(229853002)(33646002)(53936002)(230700001)(76176999)(50986999)(65956001)(65806001)(93886004)(31686004)(85426001)(105606002)(106466001)(498600001)(6246003)(626005)(4326008)(83506001)(305945005)(356003)(104016004)(2906002)(8676002)(81156014)(65826007)(81166006)(64126003)(36756003)(53546010)(8656003)(2501003)(31696002)(50466002)(68736007)(86362001)(47776003)(4001350100001)(23676002)(5660300001)(8936002)(97736004)(21314002); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR03MB3314; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD003; 1:yMu5ScwQ9OHOdIFVppIDzfRB9/t3qju3DtMFW5TXw3+vIYKlFAPLp5btRyw4+aa9sfdet40KE4M5w1rQBrZKMs6LceG+20Sc6vbJjvvBhDlO0jfR3Y9hmYR0+BUlfdUh0bmF8kKDoo355mOMICL6LnvBEwjXbfPCkx+/lXXc77rjH7XFGXbKXfJZclhytRg2UVaJavuMOFSkvTr+7R8dmRm6k36eHREoicDPKSxaPa+35eFI9hzY586nHip9NgETH/bQo1T1p7Gi9G6N8EVWHK6rGmFnT/8nkvuHfCaFChSiMIFCGCXcrNB506OImEQtFawfAg8h0G8zpZ+ukOEc5KnvEBjgzWToxvJm02c3nf/AsJKNVMbv0LKYNDThj4yVSsQ01FMTogabqQTm1pjTDNq1COnNzqGga62qsN6tD8K+RHMNfjmU9TDXbhFVqgQS9KEuQrBIHrnuxZ9v2O9zQJK5CEwzBxj91niHrhFc9vDIpFeXF04c81jUratN+02VQsfNlmb+xziFjuKRAEzFOPaxkljanGhXWHtTwB7VdHhFGznzEBPsjcN96Eigyye6VTG97SuhAsa07uXLjQs4WwFpvEpGeR6UdsneH4hI+IqUMEYvWKeBShZhSceb+DFhMfrKfpJCe2sQSmdrCQCRRJMdNDE907zAuCFPL8/5TWdxoYL5Yd7mLCwyEg9i5zhUGZ0u8YUPoDIdD3GM91seu6GoY7PgODxBs1ZZcmSAn8qfqEcOSDlKyf8t4JaQsSj7+VLv7fi6tJJGXv1RpdPHiKOOqaxNlFm8R6b4gj0/ia2i5DaKqsfv82AfdCG7DKvhExeQpGaNLsYRopdXHhBQmmEm6yiL2jkbveFo9oMskOiQTB4PT5p7lCXhEfYERE/UstitwArWOmETlL/IpxSsmUKYmeRWiB6oat02d3cT9TE= X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cf5a328d-f95e-4061-6243-08d4e474e39e X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(300000503095)(300135400095)(2017052603031)(201703131430075)(201703131517081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:BN6PR03MB3314; X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB3314; 3:GOcL45F3IppfA7S8p2/j3onxA3e4FZzfo6xbNexjhq1CgHy7PMjniSZWtCmaT3PC09Hm4l7/FjgLOfJizXwULHq6c7yiPOdo3rnfR5RC0rlABJhwSYl88ppi+mavXelA6HfdVR2TeTE/rXoc5f40zAQ7dzK0vwRV+IpQ/WYQMxXI875t4xUkz9GI9f3uqRdJolYgOmpNvc+MwRM8H5NVxvZZXUUdNYErAlB9DaetMjEclMZB1EuIHQyu5f+49iergRbhvGdD6QBSQtFHjgZNWPU1LBqVkhc1v2m461zuAT5svfZNp/sUWgae9dSAd9YUE9WThHk+KNEP+SjdU1ekxSnVIXTScUmMSBHVus67cXg=; 25:ZQs5AIfl/MHqp1JDUnzb+O4YLO/QgqUnTSBGqqT/7jE5tePgcumlG5rDKgTYwU5PYx9mp10HOdmjzIapjNO+6PKInrixEAUCs32v+BBXUPKsvGLbrfsk1P6K4N2UzJgPf9yNATEnOTRQ5H/yOM1ojfaVtz+L1jaTTnomWcFw5q+SOic/HiYEfbKliCgKBM8YO91kybCUaLFBQlP7nquFkX7jzE3BrTiN8VucFeBieq5DmmkOPKhltmFnbfNSSnLHH39KqlYP/PBEaHF2hAZueAGKjQUFntsWGYcpZBSO+ij89TB+zloMIe6XNZHGBGp4I4xRoMoMHmhf7hLLvfLGkg== X-MS-TrafficTypeDiagnostic: BN6PR03MB3314: X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB3314; 31:kGnoqRXg96+hCOI4QCdoBH/3Jw7OnU0qT1wBAEKaa8gS5te31UMsK1PGx/q68k7S/8bg7jSvS4TIDaj9DMitSXcpQ8y1qfMuoj3BmnVppgyzGrTEmTGuk6Iz+cVhXAI1MXI12yLins0I/j7o2kjQBuvnKB/RqDRT/4ZQkrOiaeK+EAR6j5b56B7WfwnTvOkGt8I+kD+faiLhB9jiS9lpZwWmakc2/C3s9z9spCiBCRk=; 4:1MQFR2EIO9/0Xa+BQ5FnWJogCFK6iI92boX/ffebS6LSSXFBIkxG6nstcufRay2ezMqq79ooQYpBkZoqcFqV87VQ1HXY5UeUR7nq8gQmxgjxNhUtsrUomQmiTdzQKeeiVR5JVQvJiHamjGDpxTXmZKAA71x83A1JVs3Xij3N6S8zDj5TlESojYOK2zicXtNLyvduOfD1oK1x9zXrtmqvAZgS5AGpi6oA/gh1nB4BJ4JCbAUfPNX4xIlpVBXq193ixNaWWgJUNd3vxBHirfe7OzNbOD6XcuQkGH5onuDHekM8w3oodAleEfcjNYR5qvfpaZt51c26NS2icTaYr9LaoQ== X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(228905959029699); X-Microsoft-Antispam-PRVS: <BN6PR03MB3314B7D4CA6802D335B1AFFBE6820@BN6PR03MB3314.namprd03.prod.outlook.com> X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(601004)(2401047)(8121501046)(13016025)(5005006)(13018025)(3002001)(100000703101)(100105400095)(10201501046)(93006095)(93001095)(6055026)(6096035)(20161123565025)(20161123561025)(20161123559100)(201703131430075)(201703131433075)(201703131448075)(201703161259150)(201703151042153)(20161123563025)(20161123556025)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BN6PR03MB3314; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BN6PR03MB3314; X-Forefront-PRVS: 0401647B7F X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjZQUjAzTUIzMzE0OzIzOkdLdEdOY0dialNvdXRoMGtiUGtmOVBDcmRz?= =?utf-8?B?NDlkTy9ueGpzdnFsRHB2a3FVMXk5aUlIdmhhNDJoTVc2ck9vaEE3K1Q3NjdE?= =?utf-8?B?RjRldWNqWlFJYWJ1bnl4REQ2bU9qM1N4VHp6Q3RYRFNiVjZCV3Z2ZGlmOVlV?= =?utf-8?B?Vis1YzRaeEhQL1plR1pVY3dvdVY0L21VZHd6c0tJcC9FdldlNWR0dDJTS1dm?= =?utf-8?B?TWdLb1dBNi94V0lIZzZxYlAwZVlaL1NQVmFtMmpJTFNhYWZyNk42NkttUVox?= =?utf-8?B?bVNwalowR010cnFyQnBobHQzbkh6TUtZY0JLQVkvbjVpUU9XNDViOTlmLzFK?= =?utf-8?B?dWFROXZKSytpVUYwbDhqZ2pNTG9EWDJHKzRzeVlJNEpGWndrbHpMMnN2TlZj?= =?utf-8?B?N1pzR0Q0cEFMOWpYcGRLTGJ5Z1dyRnNNR1MrV0xRMmpSZXl4ZTM3M1V0Tjlp?= =?utf-8?B?a3d4UXY1Vi9kMVRhdExWN2pNTEJ1MHYxZEpqcjlQRW1IcisvenVCeld3VTN6?= =?utf-8?B?ZXZnS21qOHUzSDVhU1lsM0NGN2ZzYkowRE11N3ZoK0lialBjZjdKcXU0Q3lL?= =?utf-8?B?elVlSTdFWkVLNXpzOWp4aUpEZnR6dkdhd3owTE5UWFoyQ1I3RFRBSnNZejRi?= =?utf-8?B?TnpjcnJ4Q3JIaW15ZUlzQm5MU1gzdGdJOU9EbllkN0pxUFFKejdReXhsWXIy?= =?utf-8?B?dVlwVnRlMklXQ2p6ZEdIOVMwclRQVlFydzNCKy90NlEza05ZaUVabUZSd21y?= =?utf-8?B?amNRL2t2VEFXMEZhU1F3b3hEUS95SW80aU1FM29Kcis3S1cvSmlKeGcyTzdV?= =?utf-8?B?OXVNREZxa3VzSDVZVmJMQytaN09tL3kram8ybXQ0QVVtV1VJQTMySDUvQm5o?= =?utf-8?B?WUlPanFZb0tDcXhDU0dKeXNZSDk3UnYwNGdVVk1KQ3pJMzk3U3U3SnVBcE5r?= =?utf-8?B?NnpIUlIvenM5ZjE5d21NczNtb2FuYjJCTCtUZ1JHK0sxYndOaTRJZElqQkJy?= =?utf-8?B?OEhmbnEvU0IzQkR5dVRtSVBpRTFaNW1wL1B3SFB1dnVHaE9rRlRKZGF6L0xC?= =?utf-8?B?VVNIa2ZYT1ZXclllYXArdzVOK2hVZ0lXZHU3L013YUowODhwejZBWXZzRnc2?= =?utf-8?B?TTFBRENxODZibnRFM09QSGlnNWJHUWdYd0tXVWJZYTRqKzNoT3h6OGwwWFFn?= =?utf-8?B?Q2l2enhTbU1laWt1YzZ4MitMYmYvN3ZaUWZHZ1dHNHVxLytXZ25CaEVyVHB3?= =?utf-8?B?ektuVGN6aUc3WGdHQVgxejdNVWlYRUtzVVZOa0lDYy9XN1V6dHpHNFpkbEp5?= =?utf-8?B?UWpyOFZSNnF4eWJ2UVJRdUcvZXJtd1VvMGkrMlhIMGV6UkJVcXRLSENrOG5t?= =?utf-8?B?cjcxUXVUZjNoVXZQS2JQVDcyZDBGS3BDSjViYklVaFd1R1NqWXdPYmd2VDYy?= =?utf-8?B?VmxvMk9WSGl6am13Ni9rWUNjUDg1dDJld2QybDRsUnRXK2tYd3BpbUF3Y0Zl?= =?utf-8?B?L0JITlJuc0RlN29CK1B1bndidG9yMjVlUy9TdkNmZ2k1Ukd6eVRMVHVEMzJC?= =?utf-8?B?Vk43R05rRmRJNC9EaWxuMDFhVTFaRmFNVW5NNWlHYk1wd0x5YmR3ZFozWjBl?= =?utf-8?B?cFJSNEM0aXNpUjhwRmNUYlhPQjhjWSsySDMrVVhkbE9RaXR6S0lnWkR0ZzF4?= =?utf-8?B?cTZnVUhPcytDM2Y5L0cxN1FFVktKWFhLSjZIakMrdllJZ3pIRlFHTU1PK2NB?= =?utf-8?B?NEhuTGRSdlBXbytELzFWbUM0U0hDMXNld2JLWG1jbnF0enNoZVFod2JsejFs?= =?utf-8?B?WUdhZlU1em41V2d0TTNpOE1zeHdHak83TGNwaTdjQmRMUTZSRC94R3VJeU92?= =?utf-8?B?RktDenhtNFVJbVl4Nk1sYzlmVkJjakFxRHFTcDBqZ0RoZHA4cVVCczFBT3Uw?= =?utf-8?Q?iZpA9F/fiO6VizElF/ulh6mzxvUjWI=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB3314; 6:Us7JiLP6Hf+KLJ6a9FSP7cFI+GmMzrkNEzo+nd+wFTBr85J3GX6QOWzb+7ob/RVSismTk7ca6n6hZiwkYxzcCbl9X+kDrA2B48RefItYSFmjqCHmFtAffp6EyF7GyO692Yd3NzYHu35+k/3IfO5p5pE3KtT+fSxoWd9YU1/qZ3mvLhQIYfDDkysMFf8E7pxNBER+IYHhanpY/4l4vNbT3wBJyGVTsvMOf33/JYXNkYRS0IuESUZ63QbEt4dEHC7/zgzlRpMaF33v/CLyHBpLnxnLr7Yh6FA73n1XS5G004IImR/zoqwotLFvFyVqckgZ7DRV7QKqFvZI+HRzOUtYxw==; 5:rk0A6YWf91lTOpfzf1xgoO2ionmRiLwNBkz/MtkwMhsOBY1CpnZs5YBa+T6Q+0vbZKqP45IDetlvWQhNIiEc8ElpEWGEJpG/JFZtfsG3wfu/GDw7rDyQhFcWd98/ZlTALK0LdAAX/7FLd7OeWReenA==; 24:SQ+aiNihdNvupzDIVkaBZjjTYGrYjoaHJWQpZ+IQnmc6M3cJMcwd7uzk69mwSiwqSnlqvNHZ8ffOva3JdGYcwYkOvx3OgPG5LGNKBusCl/o=; 7:rhJYSX64SKqCO8x3msWnR1ToxGJgz1BTVDmRQenV3Mz+mEDmXmCy8RKOfdFJwaCGpcsU1yOdTtddWOv4WtEz7oCeMt0j0vrN1oTX5CYSAHS8qfIVljl5onM4nfxC8v9B3Sxd9A8IbDehP+6WhO2Ak7LUgNqnxZ/AoRDSA6ZvWmvSzVEzfifMMCOAyFssVBJnRtn4YSY/ZHnn6jmtq/m0wtwY6Pm6eKv9YgPimZdfw/I= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Aug 2017 07:03:25.0201 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB3314 Subject: Re: [dpdk-dev] [PATCH] crypto/openssl: performance improvements X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 16 Aug 2017 07:03:27 -0000 Hi Pablo, On 8/15/2017 12:56 PM, De Lara Guarch, Pablo wrote: > Hi, > >> -----Original Message----- >> From: Akhil Goyal [mailto:akhil.goyal@nxp.com] >> Sent: Tuesday, August 15, 2017 7:45 AM >> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; >> dev@dpdk.org; Doherty, Declan <declan.doherty@intel.com> >> Cc: hemant.agrawal@nxp.com >> Subject: Re: [PATCH] crypto/openssl: performance improvements >> >> On 8/14/2017 7:47 PM, De Lara Guarch, Pablo wrote: >>> Hi Akhil, >>> >>>> -----Original Message----- >>>> From: Akhil Goyal [mailto:akhil.goyal@nxp.com] >>>> Sent: Friday, July 28, 2017 12:08 PM >>>> To: dev@dpdk.org; Doherty, Declan <declan.doherty@intel.com> >>>> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; >>>> hemant.agrawal@nxp.com; Akhil Goyal <akhil.goyal@nxp.com> >>>> Subject: [PATCH] crypto/openssl: performance improvements >>>> >>>> key and algo are added in the openssl ctx during session >>>> initialization instead of adding it for each packet. >>>> >>>> Also in case of HMAC the openssl APIs HMAC_XXX give better >>>> performance for all HMAC cases. >>>> >>>> Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com> >>> >>> Thanks for the patch, nice optimization! >>> Could you split this into two patches, as you are doing two different >> things here? >>> One for the first sentence and another one for the second sentence. >>> Also, as you do that, could you rename the title to be more explicit? >>> Like: crypto/openssl: initialize cipher key at session init >>> >>> Finally, I was looking at GCM, and I think it could benefit from this. >>> I will send a separate patch for it, unless you want to integrate it in this >> patchset yourself. >>> >> >> Ok I would split the patches. >> For GCM I will try to incorporate in this patchset, if I get some performance >> improvement, or I would send a different patch later if some issue comes. > > Thanks Ahkil. Since I am working on AES-CCM for this PMD, I have the change > already done. I have seen performance improvements, but it is not as straight forward > as the cipher algorithms, because GMAC is also affected, which is in a different code path, > but requires GCM to be set. > If you have the change and it is working fine, then you can send your patch, no issues in that. Thanks, Akhil