From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DAC79A04B5; Mon, 2 Dec 2019 12:57:52 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2BC0E1BF78; Mon, 2 Dec 2019 12:57:52 +0100 (CET) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 613732BD8 for ; Mon, 2 Dec 2019 12:57:50 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 74DE24C005C; Mon, 2 Dec 2019 11:57:47 +0000 (UTC) Received: from [192.168.38.17] (10.17.10.39) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 2 Dec 2019 11:57:37 +0000 To: Jerin Jacob , Thomas Monjalon CC: Ferruh Yigit , Pavan Nikhilesh , Neil Horman , "John McNamara" , Marko Kovacevic , dpdk-dev , Ori Kam , David Marchand , "Olivier Matz" , "Ananyev, Konstantin" References: <1574165145-23960-1-git-send-email-arybchenko@solarflare.com> <1788171.neaCWyZYis@xps> <1832509.BOePYM8p3J@xps> From: Andrew Rybchenko Autocrypt: addr=arybchenko@solarflare.com; keydata= mQINBF2681gBEACbdTxu8eLL3UX2oAelsnK9GkeaJeUYSOHPJQpV7RL/iaIskqTwBRnhjXt7 j9UEwGA+omnOmqQMpeQTb/F9Ma2dYE+Hw4/t/1KVjxr3ehFaASvwR4fWJfO4e2l/Rk4rG6Yi 5r6CWU2y8su2654Fr8KFc+cMGOAgKoZTZHZsRy5lHpMlemeF+VZkv8L5sYJWPnsypgqlCG3h v6lbtfZs+QqYbFH6bqoZwBAl5irmxywGR7ZJr1GLUZZ1lfdazSY8r6Vz0/Ip/KVxGu2uxo81 QCsAj0ZsQtwji9Sds/prTiPrIjx8Fc/tfbnAuVuPcnPbczwCJACzQr4q26XATL3kVuZhSBWh 4XfO/EAUuEq5AemUG5DDTM87g7Lp4eT9gMZB6P+rJwWPNWTiV3L7Cn+fO+l9mTPnOqdzBgDe OaulKiNSft1o0DY4bGzOmM2ad2cZt0jfnbMPMTE9zsr6+RFa+M8Ct20o6U1MUE4vP6veErMK of4kZ8PdoMM+Sq1hxMPNtlcVBSP9xMmdSZPlfDYI5VWosOceEcz7XZdjBJKdwKuz70V7eac4 ITSxgNFCTbeJ03zL2MR5s0IvD9ghISAwZ6ieCjU5UATn5+63qpD0nVNLsAdb/UpfvQcKAmvj 0fKlxu/PMVkjBa7/4cfNogYOhWDKUO+1pMaFwvb6/XTo6uMpfQARAQABtCxBbmRyZXcgUnli Y2hlbmtvIDxhcnliY2hlbmtvQHNvbGFyZmxhcmUuY29tPokCVAQTAQoAPhYhBP6NPgcKRj/Y X0yXQahue0sAy4m+BQJduvNYAhsDBQkB4TOABQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJ EKhue0sAy4m+t3gP/j1MNc63CEozZo1IZ2UpVPAVWTYbLdPjIRdFqhlwvZYIgGIgIBk3ezKL K0/oc4ZeIwL6wQ5+V24ahuXvvcxLlKxfbJ6lo2iQGC7GLGhsDG9Y2k6sW13/sTJB/XuR2yov k5FtIgJ+aHa1PDZnepnGGOt9ka9n/Jzrc9WKYapOIIyLRe9U26ikoVgyqsD37PVeq5tLWHHA NGTUKupe9G6DFWidxx0KzyMoWDTbW2AWYcEmV2eQsgRT094AZwLFN5ErfefYzsGdO8TAUU9X YTiQN2MvP1pBxY/r0/5UfwV4UKBcR0S3ZvzyvrPoYER2Kxdf/qurx0Mn7StiCQ/JlNZb/GWQ TQ7huduuZHNQKWm7ufbqvKSfbPYvfl3akj7Wl8/zXhYdLqb5mmK45HXrgYGEqPN53OnK2Ngx IgYKEWr05KNv09097jLT5ONgYvszflqlLIzC4dV245g7ucuf9fYmsvmM1p/gFnOJBJL18YE5 P1fuGYNfLP+qp4WMiDqXlzaJfB4JcinyU49BXUj3Utd6f6sNBsO8YWcLbKBV9WmA324S3+wj f4NPRp3A5E+6OmTVMLWire2ZvnYp3YvifUj1r8lhoZ2B2vKuWwiTlHOKYBEjnOQJQnqYZEF0 JQQ1xzVDBQKE01BPlA3vy6BGWe6I4psBVqMOB9lAev/H+xa4u6Z3uQINBF269JsBEAC2KB3W 8JES/fh74avN7LOSdK4QA7gFIUQ4egVL81KnxquLzzilABuOhmZf3Rq6rMHSM8xmUAWa7Dkt YtzXStjEBI/uF0mAR3mMz1RcL2Wp+WD/15HjVpA7hPjXSEsWY0K2ymPerK4yrLcfFTHdMonY JfuACCC9NtOZxrWHOJoUS+RT7AWk80q/6D2iwQ47/2dBTznVG+gSeHSes9l91TB09w6f9JX/ sT+Ud0NQfm7HJ7t2pmGI9O6Po/NLZsDogmnIpJp/WwYOZN9JK7u2FyX2UyRzR8jK42aJkRsh DXs16Cc2/eYGakjrdO3x9a+RoxN7EuFtYhGR1PzMXdUiB5i+FyddYXkYUyO43QE/3VPA5l1v TUOagzZq6aONsdNonGJkV3TIG3JmUNtM+D/+r6QKzmgoJ8w576JxEZI09I/ZFN+g7BnUmlMx 6Z3IUOXVX/SWfGFga0YajwajHz03IBhChEbYbbqndVhmshu2GFURxrfUPYWdDXEqkh+08a5U Didia9jm2Opv4oE1e1TXAePyYJl/Zyps4Cv00GObAxibvMBQCUZQ+IBnNldRBOwXXRQV2xpx P+9iO1VYA/QXn0KqRK+SH1JGRXbJYi42YFaW1gE0EU0fiR2Wb9pK+doNEjjOhlzUGuvOEAUS +4m0m3dlfEvpCV9GMr7ERRpZzh9QkQARAQABiQI8BBgBCgAmFiEE/o0+BwpGP9hfTJdBqG57 SwDLib4FAl269JsCGwwFCQlmAYAACgkQqG57SwDLib7x6g//e+eCtNnJz7qFGbjWRJYNLCe5 gQwkhdyEGk4omr3VmjGj3z9kNFy/muh4pmHUngSAnnpwZggx14N4hhKf9y8G4Dwvsqa6b1zB Jq/c4t/SBDtGW4M/E331N04PaQZpcrbTfp1KqHNknk2N7yOk4CcoLVuIZmA5tPguASV8aAfz ZwhWAwn6vUEw9552eXEAnGFGDTCbyryNwzB5jtVQOEEDjTxcCkpcXMB45Tb1QUslRTu/sBAe HhPCQSUcJHR+KOq+P6yKICGAr291PZd6Qc7C3UyE+A3pY/UfdEVWj0STBWx1qvYLaHLrI4O9 KXDgh7luLjZZafcueCaPYmNo4V2lmNb3+7S4TvqhoZS+wN+9ldRQ4gH3wmRZybN6Y/ZCqxol RaZpE3AqdWsGvIgAkD0FpmtZNii9s2pnrhw0K6S4t4tYgXGTossxNSJUltfFQZdXM1xkZhtv dBZuUEectbZWuviGvQXahOMuH2pM64mx2hpdZzPcI2beeJNHkAsGT2KcaMETgvtHUBFRlLVB YxsUYz3UZmi2JSua4tbcGd6iWVN90eb8CxszYtivfpz6o2nPSjNwg0NaVGSHXjAK0tdByZ9t SkwjC3tEPljVycRSDpbauogOiAkvjENfaPd/H26V5hY822kaclaKDAW6ZG9UKiMijcAgb9u5 CJoOyqE8aGS5Ag0EXbr1RwEQAMXZHbafqmZiu6Kudp+Filgdkj2/XJva5Elv3fLfpXvhVt0Y if5Rzds3RpffoLQZk9nPwK8TbZFqNXPu7HSgg9AY7UdCM94WRFTkUCGKzbgiqGdXZ7Vyc8cy teGW+BcdfQycDvjfy50T3fO4kJNVp2LDNdknPaZVe8HJ80Od63+9ksB6Ni+EijMkh6Uk3ulB CSLnT4iFV57KgU2IsxOQVLnm+0bcsWMcCnGfphkY0yKP+aJ6MfmZkEeaDa7kf24N14ktg50m vOGDitcxA/+XXQXOsOIDJx1VeidxYsQ2FfsKu1G8+G6ejuaLf4rV5MI/+B/tfLbbOdikM5PF pxZVgTir9q13qHumMxdme7w5c7hybW412yWAe9TsrlXktFmFjRSFzAAxQhQSQxArS6db4oBk yeYJ59mW52i4occkimPWSm/raSgdSM+0P6zdWUlxxj+r1qiLgCYvruzLNtp5Nts5tR/HRQjE /ohQYaWDSVJEsc/4eGmgwzHzmvHtXeKkasn01381A1Lv3xwtpnfwERMAhxBZ8EGKEkc5gNdk vIPhknnGgPXqKmE1aWu8LcHiY+RHAF8gYPCDMuwyzBYnbiosKcicuIUp0Fj8XIaPao6F+WTi In4UOrqrYhsaCUvhVjsTBbNphGih9xbFJ8E+lkTLL8P3umtTcMPnpsB4xqcDABEBAAGJBHIE GAEKACYWIQT+jT4HCkY/2F9Ml0GobntLAMuJvgUCXbr1RwIbAgUJCWYBgAJACRCobntLAMuJ vsF0IAQZAQoAHRYhBNTYjdjWgdaEN5MrAN+9UR5r/4d3BQJduvVHAAoJEN+9UR5r/4d3EiQP /3lyby6v49HTU94Q2Fn2Xat6uifR7kWE5SO/1pUwYzx6v+z5K2jqPgqUYmuNoejcGl0CTNhg LbsxzUmAuf1OTAdE+ZYvOAjjKQhY4haxHc4enby/ltnHfWJYWJZ9UN5SsIQLvITvYu6rqthO CYjpXJhwkj3ODmC9H1TrvjrBGc6i7CTnR8RCjMEwCs2LI2frHa4R6imViEr9ScMfUnzdABMQ B0T5MOg8NX92/FRjTldU2KovG0ML9mSveSvVHAoEBLy4UIs5nEDdNiO1opJgKb5CXvWQugub 7AR52phNdKVdEB0S4tigJT4NalyTaPiUhFEm+CzZpMQDJ5E+/OowaPRfN4HeJX+c8sB+vUAZ mkAaG75N+IEk5JKFK9Z+bBYgPgaBDFZYdWDB/TMH0ANt+KI5uYg0i12TB4M8pwKG1DEPUmWc F2YpvB3jnbwzsOpSFiJOOlSs6nOB0Sb5GRtPOO3h6XGj+6mzQd6tcL63c9TrrUkjq7LDkxCz SJ2hTYRC8WNX8Uw9skWo5728JNrXdazEYCenUWmYiKLNKLslXCFodUCRDh/sUiyqRwS7PHEA LYC/UIWLMomI0Yvju3KA5v3RQVXhL+Gx2CzSj3GDz9xxGhJB2LfRfjzPbTR/Z27UpjCkd8z0 Ro3Ypmi1FLQwnRgoOKDbetTAIhugEShaLTITzJAP/iRDJCQsrZah5tE8oIl81qKEmBJEGcdt HYikbpQe7ydcXhqTj7+IECa3O7azI5OhCxUH2jNyonJ/phUslHH2G1TTBZK8y4Hrx5RpuRNS esn3P9uKu9DHqBAL7DMsCPwb2p1VNnapD72DBmRhzS/e6zS2R4+r9yNv03Hv7VCxKkmtE63H qpS//qpjfrtsIcHAjnKDaDtL1LYCtHoweI+DOpKKULSAYp/JE6F8LNibPQ0/P3S5ZIJNC4QZ uESjFOalJwFIqGQdkQB7ltRNJENLrHc+2jKGOuyFHm/Sbvp5EMGdaeQ0+u8CY0P+y6oXenwx 7WrJz/GvbNoFhJoJ6RzxCMQrFgxrssVZ7w5HcUj94lbnJ6osdYE/WpSd50B6jet6LKh5revg u9XI9CoqsPQ1V4wKYYdllPuogCye7KNYNKuiiuSNpaF4gHq1ZWGArwZtWHjgc2v3LegOpRQF SwOskMKmWsUyHIRMG1p8RpkBQTqY2rGSeUqPSvaqjT0nq+SUEM6qxEXD/2Wqri/X6bamuPDb S0PkBvFD2+0zr5Bc2YkMGPBYPNGZiTp3UjmZlLfn3TiBKIC92jherY563CULjSsiBEJCOSvv 4VPLn5aAcfbCXJnE3IGCp/hPl50iQqu7BPOYBbWXeb9ptDjGCAThNxSz0WAXkmcjAFE8gdE6 Znk9 Message-ID: Date: Mon, 2 Dec 2019 14:57:33 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.17.10.39] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-25078.003 X-TM-AS-Result: No-9.298000-8.000000-10 X-TMASE-MatchedRID: CxmI61mtwh/4ECMHJTM/ufZvT2zYoYOwC/ExpXrHizw/hcT28SJs8pGS q1u/woRGBM0EYR0zlItNL9bcWiPKTTUZn1MYzuPIqjZ865FPtpq3xwqfnvnKHsAkyHiYDAQbi7q 7kJ+Pw5qk1uyPbJGKZtwxf6U2IejQcc8G9KynN+MZSUX8zcPGn71eNx77bVNJM/dZg2GSzOU81O 75lkEwtb5OLg9J9T3a1yOgL5EgJXpwF5WHNA8cU9h5cGtwmAvkElLH7tCb90r3msKSd1g4xZWix nDxF7NQJRxsfynP2ghy9bLRi78l8ZZtaC3mVX1vmOFnGEL0JOOCANcRIoeZMNZd/DOmlnxI3c00 lAOLPF4iB8dEJksHKfJCy8b55C13b581EchakiMqkSeDPauzr/ZfafJjZZIJsS0sZEB7c8aUfOk Z8bfg6m3nwjPbxr+M6cOaz1Rw6AR2FusXbyebzGY+xOrx57jW6qG5M9QNAO2RoQLwUmtovwV4uK 358vNJotefJJtI9C8iqRgiH5zaKsnfDca2HGa6LTHwnYOikQ3dXhRKGhNdp9qUml4VvcDY/sT+a 85aigSXldHH1yrZsEMrzNO5Yl/zrN4LKWBTbNR/OBWacv+iVeDTYjejIZTwBCzD0Dc8iUvbWkHM ATUzulMO/QCmUqVQ4ePDVeOYxsX1GY21p8Mq4d+G9ND+fWcZgMLeOhIhBoR3PducjiV5hU867+t VsabVc0HN9vq/TGFAZoZQH6vhA3SV/Of/JEwFRTO9mhIXG423OFcpziLcq9vgL7Kv8y9BKYKOOx NxwUXFwZq65uHEjjf9o2/0YdMdSveVz2wqp3WeAiCmPx4NwLTrdaH1ZWqC1B0Hk1Q1KyJXaDn6D hA2Ao2j49Ftap9E4kYXbobxJbLLLrRfL5Fh4SKF911N3TJ63Iv8UbqYaEL5tdYeMH0P+FaogVRE 4+FaaDqumhtn06k= X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--9.298000-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-25078.003 X-MDID: 1575287869-lvZqhZJVHHMk Subject: Re: [dpdk-dev] [PATCH v2 3/3] ethdev: improve flow mark Rx offload deprecation notice X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/2/19 2:09 PM, Jerin Jacob wrote: > On Mon, Dec 2, 2019 at 6:16 PM Thomas Monjalon wrote: >> >> 02/12/2019 05:21, Jerin Jacob: >>> On Mon, Nov 25, 2019 at 8:39 PM Thomas Monjalon wrote: >>>> >>>> 25/11/2019 11:44, Jerin Jacob: >>>>> On Sun, Nov 24, 2019 at 3:12 AM Thomas Monjalon wrote: >>>>>> >>>>>> 23/11/2019 10:42, Jerin Jacob: >>>>>>> On Sat, Nov 23, 2019 at 3:58 AM Thomas Monjalon wrote: >>>>>>>> 22/11/2019 12:53, Andrew Rybchenko: >>>>>>>>> On 11/22/19 2:15 PM, Thomas Monjalon wrote: >>>>>>>>>> 22/11/2019 11:12, Andrew Rybchenko: >>>>>>>>>>> On 11/22/19 1:01 AM, Thomas Monjalon wrote: >>>>>>>>>>>> 19/11/2019 13:12, Andrew Rybchenko: >>>>>>>>>>>>> The deprecation notice is required since it adds more requirements >>>>>>>>>>>>> when RTE flow mark and flag actions may be used and require >>>>>>>>>>>>> changes in applications. >>>>>>>>>>>> I am still not sure what is the best solution here. >>>>>>>>>>>> I continued to think about it in this thread: >>>>>>>>>>>> http://mails.dpdk.org/archives/dev/2019-November/151960.html >>>>>>>>>>>> >>>>>>>>>>>> I think we cannot require any application change until 20.11 >>>>>>>>>>>> in order to keep API (and behaviour) compatibility. >>>>>>>>>>> Expected, but still very disappointing. >>>>>>>>>>> >>>>>>>>>>> The feature is implemented by Pavan (@ Marvell), supported by me, >>>>>>>>>>> used by Qi (@ Intel), looks better than alternatives from application >>>>>>>>>>> developer point of view [1] and finally postponed for 1 year without really >>>>>>>>>>> strong motivation. >>>>>>>>>> >>>>>>>>>> I see different valuable point of views. This is enough motivation. >>>>>>>>> >>>>>>>>> It looks like I miss it in previous discussion, I would be thankful if >>>>>>>>> you give me links to read or hints how to find. >>>>>>>> >>>>>>>> http://mails.dpdk.org/archives/dev/2019-November/150793.html >>>>>>>> >>>>>>>>> Introducing new types of controls would make configuration more and >>>>>>>>> more complex. I think that many different types of control would >>>>>>>>> over-complicate it. May be it is unavoidable, but it should be clear >>>>>>>>> why the problem cannot be solved using existing types of controls >>>>>>>>> (e.g. offloads). >>>>>>>> >>>>>>>> The offload control is used as an effective configuration for now. >>>>>>>> The features which are configured with DEV_RX_OFFLOAD_* >>>>>>>> do not need any other API to be used. >>>>>>>> Extending DEV_RX_OFFLOAD_* bits for enabling features which >>>>>>>> must be configured via other API anyway, is possible. >>>>>>>> The real problem is that features in DEV_RX_OFFLOAD_* are supposed >>>>>>>> to be disabled by default. If we add some opt-in features here, >>>>>>>> we cannot enable them by default for API compatibility and do the >>>>>>>> right thing by default. >>>>>>>> >>>>>>>> Choosing DEV_RX_OFFLOAD_* bits or rte_eth_dev_opt* functions is a detail. >>>>>>>> The real decision is to change the API for using all these features. >>>>>>>> Can we keep all features available by default (opt-out)? >>>>>>> >>>>>>> IMO, *rte_eth_dev_opt* has following problems >>>>>>> >>>>>>> 1) It is not multi-process friendly. If we are changing the Rx/Tx >>>>>>> function pointer, based on >>>>>>> the selected offload, then, using *rte_eth_dev_opt* scheme won't >>>>>>> really work(if the new API >>>>>>> called after the secondary process launch) >>>>>> >>>>>> Yes it must be used before launching the secondary process. >>>>>> It is the same as DEV_RX_OFFLOAD_* config. >>>>> >>>>> Yes. rte_eth_dev_opt_* has another dimension to enable and disable as API. >>>>> So, we need to document, opt-in -> start() -> opt-out case won't work >>>>> in multi process >>>>> case. >>>>> >>>>>> >>>>>>> 2) If we are taking rte_eth_dev_opt path then by default feature has >>>>>>> to be enabled to >>>>>>> not break the functional ABI. That scheme won't scale if as when we >>>>>>> keep adding the new features. >>>>>>> It is always easy for the application to define "what it wants" vs >>>>>>> "what it does not want" >>>>>> >>>>>> Yes, opt-in may look more natural than opt-out. >>>>>> But opt-in makes the default more complex, and changes the API. >>>>>> >>>>>>> 3) Defining the device state after the reconfigure operation. >>>>>>> >>>>>>> IMO, if any operation is connected to fastpath it is better to use >>>>>>> DEV_RX_OFFLOAD_ like >>>>>>> this feature where enable or disable PMDs from updating >>>>>>> ``rte_mbuf::hash::fdir`` so that if possible >>>>>>> we can use different Rx function pointer if possible(Hence it can work >>>>>>> with the multi-process case case) >>>>>> >>>>>> I reply to 2 and 3 together. >>>>>> >>>>>> We decided that offloads must be disabled by default. >>>>>> This is what we have in 19.11: >>>>>> - Some offloads are enabled before start with DEV_?X_OFFLOAD_* >>>>>> - Some offloads are enabled with functions at any time >>>>>> >>>>>> For the second type of offloads, you want to know, before start, >>>>>> whether it will be used or not. >>>>>> If adding the second type of offloads (like rte_flow ones) >>>>>> to DEV_?X_OFFLOAD_*, it means it must be enabled 2 times: >>>>>> - before start with offload bits >>>>>> - later with more precise functions >>>>>> >>>>>> I would like to avoid changing the default behaviour, >>>>>> which is to enable an offload only one time. >>>>>> That's why I think this second category of offloads should >>>>>> offer opt-out (global disabling), so it will continue >>>>>> to work by default if they are configured. >>>>>> >>>>>> I hope you understand the difference between the two categories. >>>>> >>>>> I understand the difference. The only point of "difference in opinion" is >>>>> the default behavior of the feature/offload. If it is in RX_OFFLOAD scheme then >>>>> by default it is disabled. opt_* scheme makes this new feature/offload >>>>> enabled default to avoid changing the default behavior. >>>> >>>> OK, this is where we disagree. >>>> I am for keeping what we agreed this year: all offloads are disabled by default. >>>> But I am against the need for double enablement. >>>> The offloads which are enabled with a specific function should not need >>>> to be also enabled (opt-in) before start. >>> >>> OK. >>> >>>> >>>>> It is good to avoid functional ABI change. But bad as, >>>>> 1) New API starts bloating the ethdev API. >>>> >>>> In general, I want to clean-up the ethdev API during next year. >>>> >>>>> 2) It is diffcult for application guys to figure out what are features need to >>>>> be disabled to performance as he/she does not know, for the given release, >>>>> the enabled features. >>>> >>>> Yes this is a good point. >>>> >>>>> Item (1) is a trade-off between elegance vs ABI compatibility. No >>>>> strong opinion on this. >>>>> >>>>> To fix the item (2), Can we get have an API in ethdev to get enabled >>>>> features so that >>>>> the application can probe and disable if required? >>>> >>>> We can think about something like that. >>>> Note that there is also a need to better advertise all capabilities. >>>> >>>>> For example, rte_eth_dev_set_ptypes() comes in same category, By default, >>>>> ptype parsing is enabled. I think, we can have a general interface to >>>>> "probe" the by default enabled features >>>>> and disable it if required. Not scattered API for each feature. >>>> >>>> This is an issue. The packet type parsing should be disabled by default. >>> >>> IMO, It makes sense to disable by default. >>> >>> Isn't conflicting? One thread, we are saying for in order to make, >>> existing application work without breaking ABI, Default should be >>> enabled. >>> >>> Thoughts? >> >> Every offloads should be disabled by default. >> This is a good reason to break the behaviour in 20.11. > > Ack. Yes, I agree as well, but in general we already have an exception MBUF_FAST_FREE which is just a nice wrap for enabled by default support for mbufs from different mempools and support for mbuf reference counters. I don't suggest to change it. Just want to highlight that we already have exceptions (nicely wrapped). That's why I would not touch packet type parsing "offload". Packet type parsing is not just on/off and adding on/off in addition to existing API looks overkill. Yes, it is one more exception, but nicely wrapped as well. >>> And what would be DEFAULT behavior for the mbuf MARK updation feature? >>> (That's where this thread started). >> >> As all other features, mark is disabled by default. >> Using a rte_flow rule, it can be enabled. >> No need to pre-enable it. > > Ok. But it returns us to the point where we started [1]: The problem: ~~~~~~~~~~~~ PMD wants to know before port start if application wants to to use flow MARK/FLAG in the future. It is required because: 1. HW may be configured in a different way to reserve resources for MARK/FLAG delivery. 2. Datapath implementation choice may depend on it (e.g. vPMD is faster, but does not support MARK). opt-in/opt-out solution has drawbacks mentioned above. Also I'm not sure if opt-in/opt-out is per-queue or per-port. (Offloads may be naturally per-queue and it is a big advantage). IMHO feature which should be opt-out is almost equivalent to offload enabled by default. It has the same negative properties as enabled by default offloads. Am I missing something again? >From my point of view I see no problem in necessity to say in advance (before device start) that application would like to use some features at run time. Yes, all features which may be controlled at run-time are headache for optimizations (VLAN offloads). [1] http://inbox.dpdk.org/dev/f170105b-9c60-1b04-cb18-52e0951ddcdb@solarflare.com/