From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B7961A00E6 for ; Thu, 11 Jul 2019 12:53:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 50A505680; Thu, 11 Jul 2019 12:53:12 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 7864331FC; Thu, 11 Jul 2019 12:53:10 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jul 2019 03:53:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,478,1557212400"; d="scan'208";a="364776426" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.82]) ([10.237.220.82]) by fmsmga005.fm.intel.com with ESMTP; 11 Jul 2019 03:53:07 -0700 To: yasufum.o@gmail.com, david.marchand@redhat.com Cc: dev@dpdk.org, stable@dpdk.org, Yasufumi Ogawa References: <1555379952-23517-1-git-send-email-ogawa.yasufumi@lab.ntt.co.jp> <20190711103148.9187-1-yasufum.o@gmail.com> <20190711103148.9187-2-yasufum.o@gmail.com> From: "Burakov, Anatoly" Message-ID: Date: Thu, 11 Jul 2019 11:53:07 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20190711103148.9187-2-yasufum.o@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 1/1] fbarray: get fbarrays from containerized secondary X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11-Jul-19 11:31 AM, yasufum.o@gmail.com wrote: > From: Yasufumi Ogawa > > In secondary_msl_create_walk(), it creates a file for fbarrays with its > PID for reserving unique name among secondary processes. However, it > does not work if secondary is run as app container because each of > containerized secondary has PID 1. To reserve unique name, use hostname > instead of PID because hostname is assigned as a short form of 64 > digits full container ID in docker. > > Cc: stable@dpdk.org > > Signed-off-by: Yasufumi Ogawa > --- <...> > + if (getpid() == 1) { > + FILE *hn_fp; > + hn_fp = fopen("/etc/hostname", "r"); > + if (hn_fp == NULL) { > + RTE_LOG(ERR, EAL, > + "Cannot open '/etc/hostname' for secondary\n"); > + return -1; > + } > + > + /* with docker, /etc/hostname just has one entry of hostname */ > + if (fscanf(hn_fp, "%s", proc_id) == EOF) { Apologies for not pointing this out earlier, but do i understand correctly that there's no bounds checking here, and fscanf() will write however many bytes it wants? -- Thanks, Anatoly