From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6EBF1A0032; Fri, 18 Feb 2022 19:49:14 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0281B4014E; Fri, 18 Feb 2022 19:49:14 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 7979B40141 for ; Fri, 18 Feb 2022 19:49:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645210152; x=1676746152; h=message-id:date:to:references:from:subject:in-reply-to: content-transfer-encoding:mime-version; bh=+MH9097F6g3M8AgYRi8unH2p+dNhIHKUDWo3/uBIZM4=; b=DyAyfNVJmjf1YwU9PqDnfE9eWTN656EOpmFrhUSCf2CS6VKimVRGht4f XRKeYoH62A6sKyiE7BpyoFw6O4CgAqf+muo1O+CGvCpQ+gIZkQp7B9e1T acXMkjJUDNM2lZmhWRlmZ1L8JTlEl2PBOyQQiSkgCKuQpgi8Xh2AYVqEq +DbQ3tQaGOyW1bpi6sjjOrxoZmJZy8af01OWy4/W802t+BBBvvqLN3Hnh XslsJb2JErHC1bdg9ujOYFKQkt+MHuk3jVIWpXSOetH2fJ6bv0vG2FI01 n+FS+0nAzfUrmFl3Kx52C5xXT/6JUYh722TvIOKYpOih9QmEnAZ8sCqqB g==; X-IronPort-AV: E=McAfee;i="6200,9189,10262"; a="251389091" X-IronPort-AV: E=Sophos;i="5.88,379,1635231600"; d="scan'208";a="251389091" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2022 10:49:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,379,1635231600"; d="scan'208";a="504092411" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga002.jf.intel.com with ESMTP; 18 Feb 2022 10:49:10 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 18 Feb 2022 10:49:10 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Fri, 18 Feb 2022 10:49:10 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.177) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Fri, 18 Feb 2022 10:49:10 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e8COcNGgQz8tPv7CPc1/+EP5Crll7Xnn+0Bu9IPeM0an1Zu/BXKqBBl3Oz2K0kbAMYHJ99c3lZQwpayHTZ9tRvpTH1ajYRCsrUAXTasX/U1ixZPBZMApD044lLikOdh15GyM7KGr5gJX0QGsvp0EDRZ4HKYUZwNTl+Y7icmcO9EHft3Bwga4Br4GEatQFIqKDJoKhnk2eINaKd/CEflACrmvutof+hrHtIUUq1R7HZuT/4g0aiv0Z7Snyhum4UtzYORAnFRLTBPSXLt3uCeW7iyZcUwPrOF+HPjNsoAbOpLd1y/q/1rfx5/q/yiZ635Nhjond9WGnLypteoz+si3qA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=75JAMA5O/Cpeu71Ehq/fnyOT2jE8pL5hpuNoOs7W4UI=; b=ogvHIx0MRfird5c7OHUsUucwc2/UbNl2WMQe/1Mf+mYtWO/yiy6USDIKrrSxbvZgjZDYWtym+agwiW0g+j17s2j0sPo1UY64hs6EUmCkXfPZ8gkCNbtf+yjA4y4zpDcYUWlKRnAuPt5ESLDfYYhPxlTiWlHoOA6PASIaS3Rm9wc8qA5UajP8+bApeNB2tpJsX2NBmD01eRAcmqGiZHD4BDVeTWA+35yTMsMqJHKCIw6hVgt/l/XcGRrVncDazP/UKCj9x8hHwqQ14mIjtL2PBzfHfFsB4hriQvp5VFzU3tpvKAg4PG7xa7NfznBWSbbpR+FZBhQa7a2HNacH1lOcwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5903.namprd11.prod.outlook.com (2603:10b6:510:144::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.17; Fri, 18 Feb 2022 18:49:08 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4995.024; Fri, 18 Feb 2022 18:49:08 +0000 Message-ID: Date: Fri, 18 Feb 2022 18:49:03 +0000 Content-Language: en-US To: Ciara Loftus , References: <20220218112037.61204-1-ciara.loftus@intel.com> <20220218112037.61204-2-ciara.loftus@intel.com> From: Ferruh Yigit Subject: Re: [PATCH 2/2] net/af_xdp: reserve fill queue before socket create X-User: ferruhy In-Reply-To: <20220218112037.61204-2-ciara.loftus@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0098.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:c::14) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cf74a715-cdd3-4ce2-ef75-08d9f30f5865 X-MS-TrafficTypeDiagnostic: PH0PR11MB5903:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:279; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NrlHneBfeEliOJkrjwaiTre+pgzvlIPFmTQ7Fyf5yM7wN27TM0APNcJFp5jdk3h3C6q6M8zyJ3r5ovNR1jGtf0UGHSY26Jb6ly8JCjT73eDDOSh8pzb5y7jiXsthbfrO6m2dO6mFAUrwSbqcAQOiAI3cmkslDytDgEoZuBdMAXeBCIV/EBP7rGZkj4vsSa8gwV6MTAtViv30aZs9xGOK1sumxP8Zz++4Ha0GbYXPPbMLwIJcJOIFbNwIF5qqd8EMFuC/dDaoJvinvpWxi3p46WEvAOpwL0pGLAQ9KkL/hMwctuCi3+PpG3Ur8VSP4m+BLrok3PIXlhZItWQfSqHbVcafeoFZ1O4hJuGDhu0N1hvPX88XZmTLX/JDxrIeuMAGvvpz/6+o95U1NX53IJnlmTqsQF5jrE4FxIvDs1MXclEv1nRbcvnPEQMjEbwmv5IPH1HnoYrm62QjRPxXQlqdUkWGL6JT2WHAjrudSI6+K/aM1LbAAYfJTjd1aZfecVNzcwbCo1mfmQWSvlC/xdlAa6rvsy672o/mj7jm22Iylu2AXzak8M0THmdny242GDaxq9UvjurRxKKJFhzyhN5DUJwAtOowQUBgE4z95cwjmndWk3l7fY7NO5FdYl9ktmRPzrrnvAqz8nHOFDx1KSB6SASe95vzgdKq07BhM52fDzbBT/6eTJu2ryx7e6dFcqFoMXhHjpvlBbNZl8UrNvdkdA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(82960400001)(86362001)(316002)(66946007)(31686004)(66476007)(6666004)(6512007)(38100700002)(66556008)(6486002)(186003)(36756003)(26005)(2616005)(31696002)(2906002)(508600001)(4744005)(44832011)(53546011)(8936002)(8676002)(6506007)(5660300002)(83380400001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VjVSK0x5aFlPbTM0TEliSXIxVnJ6NWFaT2JqcmJtRm1XWFUrUEZMSjhtZEpy?= =?utf-8?B?cjdDMFJGOHJNSVNjckU5cWNSUjNQN1dNZ3NzRnJYbVRKN2xZa0NqaURqNFFj?= =?utf-8?B?N3ZpQVZZbGJIZ3NsWEh6VHBGN01xNGxUNThVVmRDRHVVZDJ6SDNQdTR6ZURm?= =?utf-8?B?TlpFLzE5N2c0RENLNDN6Y0djdlkreG5PYjdUYVQ5OGlJMWU4MEZTRzBIbG1Y?= =?utf-8?B?bjMyTlBraUZCRmJ3cmt5OENVUzUxbHFnOFdEN0hVS2lDK0hOU1V3V0prbXNH?= =?utf-8?B?b0Nkc21rVlBmOUxQMXJxb3JGQS9TSmwwaFRyWGNqSTVHbUdSN0tweXU1UTFY?= =?utf-8?B?T1hrZ0pKT0FRWDJFdkNnd3p0dG9OMjZ0WEJlNUZ3Qm5PZTg3b3VxR09RQm53?= =?utf-8?B?ZkpzY2daNUNZWDZPMER2YWJsSG44STlSc1hBSmcvbzFjMFJ3dU95bE5YUEZo?= =?utf-8?B?NFg2aytUREQ5M09kMkoxVXB6TFdUQ2lXbU54RHpwK1MyTW4rT1psT3doTC93?= =?utf-8?B?U000YVBLcjBtRWRmWnV2UFRBbjV5bDhUQlVuVXFkVEd4Zm5aOHkzZ2llRVFw?= =?utf-8?B?eXhGazUxMEhpR2RjTkxBWkhxVGRySGdkNU13cktiVGZucmtoVFZBSHBBWlJz?= =?utf-8?B?ZGgxTlJ5NGt2M3pXTnVxbUhoTjJOdnNtbkk5R0VjcWp0Vk5zWGZPRWRyTFQ5?= =?utf-8?B?MjJNc2h6WktYNFNrVWNQS3BqLzJLcUNOMG5QNHZGOW9oRGd2Qmh5cU1rNTF0?= =?utf-8?B?RTRpN245RkRqWTEzdnp0Nmg1VmhFZkJ2blRmZFgvZ2xxM0pIK1I0NUg4R3BI?= =?utf-8?B?WldGZUw5a0FFeU5DU3E2TFcyOW0zM0JKamhpMC8zTlhTU2tsYzJZQS82Tjh2?= =?utf-8?B?STlMZzR4RTV2aFdKazhIZWV6MmpqT1lGNnhRdmJtNkowVzFqRkZGQmJmRHJn?= =?utf-8?B?ZHNpd0lrQWlRbzN3ZzVUR2VmZ0RZVCtBcUxEVkNvWmY2WkFJbFpnYUtUamV6?= =?utf-8?B?OU02THdrTHZoSWFrMmh2QkdDM2JBYkwyZDkrR3g2T0VnMjREUndaOXJjODF5?= =?utf-8?B?eVZ1Wk1NTGh6aHpsbTJNKzZEeEFyN3V5QldSVE10Zm5aQ1BmTzlRd3M4NzBJ?= =?utf-8?B?Y0wyZ1JQVS8yMkFZKzRhaGRObjl3aWJleUkwWEJ4RFJZRDRBZXlLMEFTNnFh?= =?utf-8?B?T0RJdzBiMTVIeGJ2Z210cHViSVpyTmh5T2VTcXU2OXlEOW5pR0FWL01qZ0FV?= =?utf-8?B?aFpHbnM5U25iaG9sTm5OS1JNbXh0L1dNOHRZMzVZSnF6d3c2MXNHaTJGak9x?= =?utf-8?B?MnBwZGlJR0NxU2w2bXFXQno4OXdIRS9OL21ra0twNnNpUXJZakwvcTFRRzJR?= =?utf-8?B?S09RbUpoVi84SW8xQml6ck9qU1l6MGxCSGNWRWMvZXlreFlzcmpLUjFtY2FF?= =?utf-8?B?TG90QWIwWGs1dGJvbkFmUyt5TVpoZzE4UzROT1hHVDBSSE5EOXFhQUFCRTJZ?= =?utf-8?B?dXhEcHhWUUswd04xaDV0Y0pQd0ZVcXUzZkdGNnVlcDkyNHg4VVNkcFl0NjFO?= =?utf-8?B?WlJvaFVLTjU2YzVWTFlIYUF6Ri90OHVGZlc5aHdIUFlIK0xrdDJvOC9XZDN2?= =?utf-8?B?Z3VPbjM4T0c1cW9iM1Z1TzFFSzBsaFFOcHFrZm9hbXJjR3pRTVdWRXJxc0JC?= =?utf-8?B?eVdrSkNaWEpqS1RUdWRFWnlLQ1BEU1VxMTBUUURkbGV0ZytPVHBZQkw0aW1N?= =?utf-8?B?b0VFSExTQkEwaXdYeURzUXc1RGtoUzNUMTBJTzI2bEJ1am5yNFBzRE9DdkZ0?= =?utf-8?B?eTZPNmxDdkxUUmRHaE5vZjNIYkNKMXQ5NC84ZncyL0MxeklFZFNMRXR3OHBF?= =?utf-8?B?WlpYUTZ6TEpMcXdNTGNiQ0J0aExFT3E1bHRsNjdsRzI4TXh3MHF1MGxpam1n?= =?utf-8?B?Wno1eFpxeFJGMVNra3dhU2U4S2s2Qi91RGxmdU1WSEZJRCtBVHJBd0ZyS3JG?= =?utf-8?B?ZjhPaTB0enB0S2ZCMm1YdFIwamMyOFMwSVNCV0NMaXMyVHl2WVk3Y1RMYmdV?= =?utf-8?B?Mk9CMFh3LzNGNVBnOXlLNXpnNTA3dGpDTkY0ZVdSLzVldlBTM0tjVWRjUy9s?= =?utf-8?B?TFV1cmVnVk10c3lPUEp0TXN6U0lLcGRJUTg2WVhyWHFYdGl4TUhPS3NuK0pT?= =?utf-8?Q?FghfaWL827zPeDTEiUaH+Pc=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: cf74a715-cdd3-4ce2-ef75-08d9f30f5865 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2022 18:49:08.5894 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7vLNHUQS7J9mDcmH50itT7f5I/r0rKvEMG04x+AGzUUR9sNVW3i48jq/HWLDlv0fMPtFHxBhHJezDWAS/srCBQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5903 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/18/2022 11:20 AM, Ciara Loftus wrote: > Some zero copy AF_XDP drivers eg. ice require that there are addresses > already in the fill queue before the socket is created. Otherwise you may > see log messages such as: > > XSK buffer pool does not provide enough addresses to fill 2047 buffers on > Rx ring 0 > I confirm the above log is gone with the patch, for the record I am seeing below instead now: [ +0.346578] ice 0000:86:00.1: Registered XDP mem model MEM_TYPE_XSK_BUFF_POOL on Rx ring 0 [ +0.032472] device enp134s0f1 left promiscuous mode > This commit ensures that the addresses are available before creating the > socket, instead of after. > > Signed-off-by: Ciara Loftus Tested-by: Ferruh Yigit