[dpdk-dev] [PATCH 0/6] crypto/mvsam: add new features and fixes

[dpdk-dev] [PATCH 0/6] crypto/mvsam: add new features and fixes

[Tomasz Duszynski]

This patch series introduces following changes:

* Add support for HMAC SHA224, AES ECB and NULL algorithms.
* Update hash digest sizes to match hardware capabilities.
* Fix a shared build.

Szymon Sliwa (1):
  crypto/mvsam: update hash digest sizes

Tomasz Duszynski (5):
  crypto/mvsam: fix shared library build
  crypto/mvsam: add support for HMAC SHA224
  crypto/mvsam: add support for AES ECB
  crypto/mvsam: add support for crypto/auth NULL algorithms
  crypto/mvsam: add 3DES ECB to the capabilities list

 drivers/crypto/mvsam/Makefile           |   2 +-
 drivers/crypto/mvsam/rte_mrvl_pmd.c     |  15 ++++
 drivers/crypto/mvsam/rte_mrvl_pmd_ops.c | 150 +++++++++++++++++++++++++++-----
 3 files changed, 144 insertions(+), 23 deletions(-)

--
2.7.4

[dpdk-dev] [PATCH 1/6] crypto/mvsam: fix shared library build

[Tomasz Duszynski]

Add missing rte_kvargs library dependency. Without that
shared library build fails due to unresolved rte_kvargs_* symbols.

Fixes: 25b05a1c806b ("crypto/mvsam: parse max number of sessions")
Cc: pablo.de.lara.guarch@intel.com

Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
---
 drivers/crypto/mvsam/Makefile       | 2 +-
 drivers/crypto/mvsam/rte_mrvl_pmd.c | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/crypto/mvsam/Makefile b/drivers/crypto/mvsam/Makefile
index c3dc72c..3290147 100644
--- a/drivers/crypto/mvsam/Makefile
+++ b/drivers/crypto/mvsam/Makefile
@@ -31,7 +31,7 @@ EXPORT_MAP := rte_pmd_mvsam_version.map
 
 # external library dependencies
 LDLIBS += -L$(LIBMUSDK_PATH)/lib -lmusdk
-LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool
+LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_kvargs
 LDLIBS += -lrte_cryptodev
 LDLIBS += -lrte_bus_vdev
 
diff --git a/drivers/crypto/mvsam/rte_mrvl_pmd.c b/drivers/crypto/mvsam/rte_mrvl_pmd.c
index 73eff75..9d130b1 100644
--- a/drivers/crypto/mvsam/rte_mrvl_pmd.c
+++ b/drivers/crypto/mvsam/rte_mrvl_pmd.c
@@ -11,6 +11,7 @@
 #include <rte_bus_vdev.h>
 #include <rte_malloc.h>
 #include <rte_cpuflags.h>
+#include <rte_kvargs.h>
 
 #include "rte_mrvl_pmd_private.h"
 
-- 
2.7.4

[dpdk-dev] [PATCH 2/6] crypto/mvsam: update hash digest sizes

[Tomasz Duszynski]

From: Szymon Sliwa <szs@semihalf.com>

Update hash digest sizes to match hardware capabilities.

Signed-off-by: Szymon Sliwa <szs@semihalf.com>
Reviewed-by: Yelena Krivosheev <yelena@marvell.com>
Reviewed-by: Natalie Samsonov <nsamsono@marvell.com>
---
 drivers/crypto/mvsam/rte_mrvl_pmd_ops.c | 46 ++++++++++++++++-----------------
 1 file changed, 23 insertions(+), 23 deletions(-)

diff --git a/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c b/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
index c045562..e2cfc07 100644
--- a/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
+++ b/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
@@ -30,9 +30,9 @@ static const struct rte_cryptodev_capabilities
 					.increment = 1
 				},
 				.digest_size = {
-					.min = 16,
+					.min = 12,
 					.max = 16,
-					.increment = 0
+					.increment = 4
 				},
 			}, }
 		}, }
@@ -50,9 +50,9 @@ static const struct rte_cryptodev_capabilities
 						.increment = 0
 					},
 					.digest_size = {
-						.min = 16,
+						.min = 12,
 						.max = 16,
-						.increment = 0
+						.increment = 4
 					},
 				}, }
 			}, }
@@ -70,9 +70,9 @@ static const struct rte_cryptodev_capabilities
 						.increment = 1
 					},
 					.digest_size = {
-						.min = 20,
+						.min = 12,
 						.max = 20,
-						.increment = 0
+						.increment = 4
 					},
 				}, }
 			}, }
@@ -90,9 +90,9 @@ static const struct rte_cryptodev_capabilities
 					.increment = 0
 				},
 				.digest_size = {
-					.min = 20,
+					.min = 12,
 					.max = 20,
-					.increment = 0
+					.increment = 4
 				},
 			}, }
 		}, }
@@ -110,9 +110,9 @@ static const struct rte_cryptodev_capabilities
 					.increment = 0
 				},
 				.digest_size = {
-					.min = 28,
+					.min = 12,
 					.max = 28,
-					.increment = 0
+					.increment = 4
 				},
 			}, }
 		}, }
@@ -130,9 +130,9 @@ static const struct rte_cryptodev_capabilities
 						.increment = 1
 					},
 					.digest_size = {
-						.min = 32,
+						.min = 12,
 						.max = 32,
-						.increment = 0
+						.increment = 4
 					},
 				}, }
 			}, }
@@ -150,9 +150,9 @@ static const struct rte_cryptodev_capabilities
 						.increment = 0
 					},
 					.digest_size = {
-						.min = 32,
+						.min = 12,
 						.max = 32,
-						.increment = 0
+						.increment = 4
 					},
 				}, }
 			}, }
@@ -170,9 +170,9 @@ static const struct rte_cryptodev_capabilities
 					.increment = 1
 				},
 				.digest_size = {
-					.min = 48,
+					.min = 12,
 					.max = 48,
-					.increment = 0
+					.increment = 4
 				},
 			}, }
 		}, }
@@ -190,9 +190,9 @@ static const struct rte_cryptodev_capabilities
 					.increment = 0
 				},
 				.digest_size = {
-					.min = 48,
+					.min = 12,
 					.max = 48,
-					.increment = 0
+					.increment = 4
 				},
 			}, }
 		}, }
@@ -210,9 +210,9 @@ static const struct rte_cryptodev_capabilities
 					.increment = 1
 				},
 				.digest_size = {
-					.min = 64,
-					.max = 64,
-					.increment = 0
+					.min = 12,
+					.max = 48,
+					.increment = 4
 				},
 			}, }
 		}, }
@@ -230,8 +230,8 @@ static const struct rte_cryptodev_capabilities
 					.increment = 0
 				},
 				.digest_size = {
-					.min = 64,
-					.max = 64,
+					.min = 12,
+					.max = 48,
 					.increment = 0
 				},
 			}, }
-- 
2.7.4

[dpdk-dev] [PATCH 3/6] crypto/mvsam: add support for HMAC SHA224

[Tomasz Duszynski]

Add support for the HMAC SHA224 authentication algorithm.

Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
Reviewed-by: Natalie Samsonov <nsamsono@marvell.com>
---
 drivers/crypto/mvsam/rte_mrvl_pmd.c     |  3 +++
 drivers/crypto/mvsam/rte_mrvl_pmd_ops.c | 21 +++++++++++++++++++++
 2 files changed, 24 insertions(+)

diff --git a/drivers/crypto/mvsam/rte_mrvl_pmd.c b/drivers/crypto/mvsam/rte_mrvl_pmd.c
index 9d130b1..5ef4139 100644
--- a/drivers/crypto/mvsam/rte_mrvl_pmd.c
+++ b/drivers/crypto/mvsam/rte_mrvl_pmd.c
@@ -113,6 +113,9 @@ struct auth_params_mapping auth_map[RTE_CRYPTO_AUTH_LIST_END] = {
 	[RTE_CRYPTO_AUTH_SHA1] = {
 		.supported = ALGO_SUPPORTED,
 		.auth_alg = SAM_AUTH_HASH_SHA1 },
+	[RTE_CRYPTO_AUTH_SHA224_HMAC] = {
+		.supported = ALGO_SUPPORTED,
+		.auth_alg = SAM_AUTH_HMAC_SHA2_224 },
 	[RTE_CRYPTO_AUTH_SHA224] = {
 		.supported = ALGO_SUPPORTED,
 		.auth_alg = SAM_AUTH_HASH_SHA2_224 },
diff --git a/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c b/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
index e2cfc07..d253b8f 100644
--- a/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
+++ b/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
@@ -97,6 +97,27 @@ static const struct rte_cryptodev_capabilities
 			}, }
 		}, }
 	},
+	{
+		/* SHA224 HMAC */
+		.op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
+		{.sym = {
+			.xform_type = RTE_CRYPTO_SYM_XFORM_AUTH,
+			{.auth = {
+				.algo = RTE_CRYPTO_AUTH_SHA224_HMAC,
+				.block_size = 64,
+				.key_size = {
+					.min = 1,
+					.max = 64,
+					.increment = 1
+				},
+				.digest_size = {
+					.min = 28,
+					.max = 28,
+					.increment = 0
+				},
+			}, }
+		}, }
+	},
 	{	/* SHA224 */
 		.op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
 		{.sym = {
-- 
2.7.4

[dpdk-dev] [PATCH 4/6] crypto/mvsam: add support for AES ECB

[Tomasz Duszynski]

Add support for AES128/192/256 in ECB mode.

Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
Reviewed-by: Natalie Samsonov <nsamsono@marvell.com>
---
 drivers/crypto/mvsam/rte_mrvl_pmd.c     |  5 +++++
 drivers/crypto/mvsam/rte_mrvl_pmd_ops.c | 20 ++++++++++++++++++++
 2 files changed, 25 insertions(+)

diff --git a/drivers/crypto/mvsam/rte_mrvl_pmd.c b/drivers/crypto/mvsam/rte_mrvl_pmd.c
index 5ef4139..08d4a23 100644
--- a/drivers/crypto/mvsam/rte_mrvl_pmd.c
+++ b/drivers/crypto/mvsam/rte_mrvl_pmd.c
@@ -94,6 +94,11 @@ struct cipher_params_mapping cipher_map[RTE_CRYPTO_CIPHER_LIST_END] = {
 		.cipher_alg = SAM_CIPHER_AES,
 		.cipher_mode = SAM_CIPHER_CTR,
 		.max_key_len = BITS2BYTES(256) },
+	[RTE_CRYPTO_CIPHER_AES_ECB] = {
+		.supported = ALGO_SUPPORTED,
+		.cipher_alg = SAM_CIPHER_AES,
+		.cipher_mode = SAM_CIPHER_ECB,
+		.max_key_len = BITS2BYTES(256) },
 };
 
 /**
diff --git a/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c b/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
index d253b8f..3d3bbf1 100644
--- a/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
+++ b/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
@@ -298,6 +298,26 @@ static const struct rte_cryptodev_capabilities
 			}, }
 		}, }
 	},
+	{	/* AES ECB */
+		.op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
+		{.sym = {
+			.xform_type = RTE_CRYPTO_SYM_XFORM_CIPHER,
+			{.cipher = {
+				.algo = RTE_CRYPTO_CIPHER_AES_ECB,
+				.block_size = 16,
+				.key_size = {
+					.min = 16,
+					.max = 32,
+					.increment = 8
+				},
+				.iv_size = {
+					.min = 0,
+					.max = 0,
+					.increment = 0
+				}
+			}, }
+		}, }
+	},
 	{	/* AES GCM */
 		.op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
 		{.sym = {
-- 
2.7.4

[dpdk-dev] [PATCH 5/6] crypto/mvsam: add support for crypto/auth NULL algorithms

[Tomasz Duszynski]

Add support for both cipher and auth NULL algorithms.

Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
Reviewed-by: Natalie Samsonov <nsamsono@marvell.com>
---
 drivers/crypto/mvsam/rte_mrvl_pmd.c     |  6 +++++
 drivers/crypto/mvsam/rte_mrvl_pmd_ops.c | 45 +++++++++++++++++++++++++++++++++
 2 files changed, 51 insertions(+)

diff --git a/drivers/crypto/mvsam/rte_mrvl_pmd.c b/drivers/crypto/mvsam/rte_mrvl_pmd.c
index 08d4a23..961802e 100644
--- a/drivers/crypto/mvsam/rte_mrvl_pmd.c
+++ b/drivers/crypto/mvsam/rte_mrvl_pmd.c
@@ -69,6 +69,9 @@ __rte_aligned(32);
  */
 static const
 struct cipher_params_mapping cipher_map[RTE_CRYPTO_CIPHER_LIST_END] = {
+	[RTE_CRYPTO_CIPHER_NULL] = {
+		.supported = ALGO_SUPPORTED,
+		.cipher_alg = SAM_CIPHER_NONE },
 	[RTE_CRYPTO_CIPHER_3DES_CBC] = {
 		.supported = ALGO_SUPPORTED,
 		.cipher_alg = SAM_CIPHER_3DES,
@@ -106,6 +109,9 @@ struct cipher_params_mapping cipher_map[RTE_CRYPTO_CIPHER_LIST_END] = {
  */
 static const
 struct auth_params_mapping auth_map[RTE_CRYPTO_AUTH_LIST_END] = {
+	[RTE_CRYPTO_AUTH_NULL] = {
+		.supported = ALGO_SUPPORTED,
+		.auth_alg = SAM_AUTH_NONE },
 	[RTE_CRYPTO_AUTH_MD5_HMAC] = {
 		.supported = ALGO_SUPPORTED,
 		.auth_alg = SAM_AUTH_HMAC_MD5 },
diff --git a/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c b/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
index 3d3bbf1..f3251aa 100644
--- a/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
+++ b/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
@@ -413,6 +413,51 @@ static const struct rte_cryptodev_capabilities
 			}, }
 		}, }
 	},
+	{	/* NULL (AUTH) */
+		.op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
+		{.sym = {
+			.xform_type = RTE_CRYPTO_SYM_XFORM_AUTH,
+			{.auth = {
+				.algo = RTE_CRYPTO_AUTH_NULL,
+				.block_size = 1,
+				.key_size = {
+					.min = 0,
+					.max = 0,
+					.increment = 0
+				},
+				.digest_size = {
+					.min = 0,
+					.max = 0,
+					.increment = 0
+				},
+				.iv_size = {
+					.min = 0,
+					.max = 0,
+					.increment = 0
+				}
+			}, },
+		}, },
+	},
+	{	/* NULL (CIPHER) */
+		.op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
+		{.sym = {
+			.xform_type = RTE_CRYPTO_SYM_XFORM_CIPHER,
+			{.cipher = {
+				.algo = RTE_CRYPTO_CIPHER_NULL,
+				.block_size = 1,
+				.key_size = {
+					.min = 0,
+					.max = 0,
+					.increment = 0
+				},
+				.iv_size = {
+					.min = 0,
+					.max = 0,
+					.increment = 0
+				}
+			}, },
+		}, }
+	},
 
 	RTE_CRYPTODEV_END_OF_CAPABILITIES_LIST()
 };
-- 
2.7.4

[dpdk-dev] [PATCH 6/6] crypto/mvsam: add 3DES ECB to the capabilities list

[Tomasz Duszynski]

3DES in ECB mode is supported by the PMD thus specific
entry should exist in the crypto PMD capabilities list.

Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
Reviewed-by: Natalie Samsonov <nsamsono@marvell.com>
---
 drivers/crypto/mvsam/rte_mrvl_pmd_ops.c | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c b/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
index f3251aa..62f5a2a 100644
--- a/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
+++ b/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
@@ -413,6 +413,26 @@ static const struct rte_cryptodev_capabilities
 			}, }
 		}, }
 	},
+	{	/* 3DES ECB */
+		.op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
+		{.sym = {
+			.xform_type = RTE_CRYPTO_SYM_XFORM_CIPHER,
+			{.cipher = {
+				.algo = RTE_CRYPTO_CIPHER_3DES_ECB,
+				.block_size = 8,
+				.key_size = {
+					.min = 24,
+					.max = 24,
+					.increment = 0
+				},
+				.iv_size = {
+					.min = 0,
+					.max = 0,
+					.increment = 0
+				}
+			}, }
+		}, }
+	},
 	{	/* NULL (AUTH) */
 		.op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
 		{.sym = {
-- 
2.7.4

Re: [dpdk-dev] [PATCH 2/6] crypto/mvsam: update hash digest sizes

[Akhil Goyal]

Hi Tomasz,

Is this patch a fix which needs to be applied for stable as well or you have
added some changes in the code which can support this.

-Akhil

On 8/24/2018 7:24 PM, Tomasz Duszynski wrote:
> From: Szymon Sliwa <szs@semihalf.com>
>
> Update hash digest sizes to match hardware capabilities.
>
> Signed-off-by: Szymon Sliwa <szs@semihalf.com>
> Reviewed-by: Yelena Krivosheev <yelena@marvell.com>
> Reviewed-by: Natalie Samsonov <nsamsono@marvell.com>
> ---
>   drivers/crypto/mvsam/rte_mrvl_pmd_ops.c | 46 ++++++++++++++++-----------------
>   1 file changed, 23 insertions(+), 23 deletions(-)
>
> diff --git a/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c b/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
> index c045562..e2cfc07 100644
> --- a/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
> +++ b/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
> @@ -30,9 +30,9 @@ static const struct rte_cryptodev_capabilities
>   					.increment = 1
>   				},
>   				.digest_size = {
> -					.min = 16,
> +					.min = 12,
>   					.max = 16,
> -					.increment = 0
> +					.increment = 4
>   				},
>   			}, }
>   		}, }
> @@ -50,9 +50,9 @@ static const struct rte_cryptodev_capabilities
>   						.increment = 0
>   					},
>   					.digest_size = {
> -						.min = 16,
> +						.min = 12,
>   						.max = 16,
> -						.increment = 0
> +						.increment = 4
>   					},
>   				}, }
>   			}, }
> @@ -70,9 +70,9 @@ static const struct rte_cryptodev_capabilities
>   						.increment = 1
>   					},
>   					.digest_size = {
> -						.min = 20,
> +						.min = 12,
>   						.max = 20,
> -						.increment = 0
> +						.increment = 4
>   					},
>   				}, }
>   			}, }
> @@ -90,9 +90,9 @@ static const struct rte_cryptodev_capabilities
>   					.increment = 0
>   				},
>   				.digest_size = {
> -					.min = 20,
> +					.min = 12,
>   					.max = 20,
> -					.increment = 0
> +					.increment = 4
>   				},
>   			}, }
>   		}, }
> @@ -110,9 +110,9 @@ static const struct rte_cryptodev_capabilities
>   					.increment = 0
>   				},
>   				.digest_size = {
> -					.min = 28,
> +					.min = 12,
>   					.max = 28,
> -					.increment = 0
> +					.increment = 4
>   				},
>   			}, }
>   		}, }
> @@ -130,9 +130,9 @@ static const struct rte_cryptodev_capabilities
>   						.increment = 1
>   					},
>   					.digest_size = {
> -						.min = 32,
> +						.min = 12,
>   						.max = 32,
> -						.increment = 0
> +						.increment = 4
>   					},
>   				}, }
>   			}, }
> @@ -150,9 +150,9 @@ static const struct rte_cryptodev_capabilities
>   						.increment = 0
>   					},
>   					.digest_size = {
> -						.min = 32,
> +						.min = 12,
>   						.max = 32,
> -						.increment = 0
> +						.increment = 4
>   					},
>   				}, }
>   			}, }
> @@ -170,9 +170,9 @@ static const struct rte_cryptodev_capabilities
>   					.increment = 1
>   				},
>   				.digest_size = {
> -					.min = 48,
> +					.min = 12,
>   					.max = 48,
> -					.increment = 0
> +					.increment = 4
>   				},
>   			}, }
>   		}, }
> @@ -190,9 +190,9 @@ static const struct rte_cryptodev_capabilities
>   					.increment = 0
>   				},
>   				.digest_size = {
> -					.min = 48,
> +					.min = 12,
>   					.max = 48,
> -					.increment = 0
> +					.increment = 4
>   				},
>   			}, }
>   		}, }
> @@ -210,9 +210,9 @@ static const struct rte_cryptodev_capabilities
>   					.increment = 1
>   				},
>   				.digest_size = {
> -					.min = 64,
> -					.max = 64,
> -					.increment = 0
> +					.min = 12,
> +					.max = 48,
> +					.increment = 4
>   				},
>   			}, }
>   		}, }
> @@ -230,8 +230,8 @@ static const struct rte_cryptodev_capabilities
>   					.increment = 0
>   				},
>   				.digest_size = {
> -					.min = 64,
> -					.max = 64,
> +					.min = 12,
> +					.max = 48,
>   					.increment = 0
>   				},
>   			}, }

Re: [dpdk-dev] [PATCH 3/6] crypto/mvsam: add support for HMAC SHA224

[Akhil Goyal]

Hi Tomasz,

On 8/24/2018 7:24 PM, Tomasz Duszynski wrote:
> Add support for the HMAC SHA224 authentication algorithm.
>
> Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
> Reviewed-by: Natalie Samsonov <nsamsono@marvell.com>
> ---
>   drivers/crypto/mvsam/rte_mrvl_pmd.c     |  3 +++
>   drivers/crypto/mvsam/rte_mrvl_pmd_ops.c | 21 +++++++++++++++++++++
>   2 files changed, 24 insertions(+)
>
> diff --git a/drivers/crypto/mvsam/rte_mrvl_pmd.c b/drivers/crypto/mvsam/rte_mrvl_pmd.c
> index 9d130b1..5ef4139 100644
> --- a/drivers/crypto/mvsam/rte_mrvl_pmd.c
> +++ b/drivers/crypto/mvsam/rte_mrvl_pmd.c
> @@ -113,6 +113,9 @@ struct auth_params_mapping auth_map[RTE_CRYPTO_AUTH_LIST_END] = {
>   	[RTE_CRYPTO_AUTH_SHA1] = {
>   		.supported = ALGO_SUPPORTED,
>   		.auth_alg = SAM_AUTH_HASH_SHA1 },
> +	[RTE_CRYPTO_AUTH_SHA224_HMAC] = {
> +		.supported = ALGO_SUPPORTED,
> +		.auth_alg = SAM_AUTH_HMAC_SHA2_224 },
>   	[RTE_CRYPTO_AUTH_SHA224] = {
>   		.supported = ALGO_SUPPORTED,
>   		.auth_alg = SAM_AUTH_HASH_SHA2_224 },
> diff --git a/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c b/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
> index e2cfc07..d253b8f 100644
> --- a/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
> +++ b/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
> @@ -97,6 +97,27 @@ static const struct rte_cryptodev_capabilities
>   			}, }
>   		}, }
>   	},
> +	{
> +		/* SHA224 HMAC */
> +		.op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
> +		{.sym = {
> +			.xform_type = RTE_CRYPTO_SYM_XFORM_AUTH,
> +			{.auth = {
> +				.algo = RTE_CRYPTO_AUTH_SHA224_HMAC,
> +				.block_size = 64,
> +				.key_size = {
> +					.min = 1,
> +					.max = 64,
> +					.increment = 1
> +				},
> +				.digest_size = {
> +					.min = 28,
> +					.max = 28,
> +					.increment = 0
> +				},
> +			}, }
> +		}, }
> +	},
>   	{	/* SHA224 */
>   		.op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
>   		{.sym = {
doc shall also be updated for each of the new algorithm supported.

Also please rephrase the subject as
crypto/mvsam: support for HMAC SHA224

Please change the subject for other patches as well.

Thanks,
Akhil

Re: [dpdk-dev] [PATCH 4/6] crypto/mvsam: add support for AES ECB

[Akhil Goyal]

On 8/24/2018 7:24 PM, Tomasz Duszynski wrote:
> Add support for AES128/192/256 in ECB mode.
>
> Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
> Reviewed-by: Natalie Samsonov <nsamsono@marvell.com>
> ---
>   drivers/crypto/mvsam/rte_mrvl_pmd.c     |  5 +++++
>   drivers/crypto/mvsam/rte_mrvl_pmd_ops.c | 20 ++++++++++++++++++++
>   2 files changed, 25 insertions(+)
>
> diff --git a/drivers/crypto/mvsam/rte_mrvl_pmd.c b/drivers/crypto/mvsam/rte_mrvl_pmd.c
> index 5ef4139..08d4a23 100644
> --- a/drivers/crypto/mvsam/rte_mrvl_pmd.c
> +++ b/drivers/crypto/mvsam/rte_mrvl_pmd.c
> @@ -94,6 +94,11 @@ struct cipher_params_mapping cipher_map[RTE_CRYPTO_CIPHER_LIST_END] = {
>   		.cipher_alg = SAM_CIPHER_AES,
>   		.cipher_mode = SAM_CIPHER_CTR,
>   		.max_key_len = BITS2BYTES(256) },
> +	[RTE_CRYPTO_CIPHER_AES_ECB] = {
> +		.supported = ALGO_SUPPORTED,
> +		.cipher_alg = SAM_CIPHER_AES,
> +		.cipher_mode = SAM_CIPHER_ECB,
> +		.max_key_len = BITS2BYTES(256) },
>   };
>   
>   /**
> diff --git a/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c b/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
> index d253b8f..3d3bbf1 100644
> --- a/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
> +++ b/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
> @@ -298,6 +298,26 @@ static const struct rte_cryptodev_capabilities
>   			}, }
>   		}, }
>   	},
> +	{	/* AES ECB */
> +		.op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
> +		{.sym = {
> +			.xform_type = RTE_CRYPTO_SYM_XFORM_CIPHER,
> +			{.cipher = {
> +				.algo = RTE_CRYPTO_CIPHER_AES_ECB,
> +				.block_size = 16,
> +				.key_size = {
> +					.min = 16,
> +					.max = 32,
> +					.increment = 8
> +				},
> +				.iv_size = {
> +					.min = 0,
> +					.max = 0,
> +					.increment = 0
> +				}
iv size may not be zero in this case and also in other patch for 3des. 
Please check
> +			}, }
> +		}, }
> +	},
>   	{	/* AES GCM */
>   		.op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
>   		{.sym = {

Re: [dpdk-dev] [PATCH 1/6] crypto/mvsam: fix shared library build

[Akhil Goyal]

Please add cc: stable@dpdk.org for the fixes patches in the next version.

On 8/24/2018 7:24 PM, Tomasz Duszynski wrote:
> Add missing rte_kvargs library dependency. Without that
> shared library build fails due to unresolved rte_kvargs_* symbols.
>
> Fixes: 25b05a1c806b ("crypto/mvsam: parse max number of sessions")
> Cc: pablo.de.lara.guarch@intel.com
>
> Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
> ---
>   drivers/crypto/mvsam/Makefile       | 2 +-
>   drivers/crypto/mvsam/rte_mrvl_pmd.c | 1 +
>   2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/mvsam/Makefile b/drivers/crypto/mvsam/Makefile
> index c3dc72c..3290147 100644
> --- a/drivers/crypto/mvsam/Makefile
> +++ b/drivers/crypto/mvsam/Makefile
> @@ -31,7 +31,7 @@ EXPORT_MAP := rte_pmd_mvsam_version.map
>   
>   # external library dependencies
>   LDLIBS += -L$(LIBMUSDK_PATH)/lib -lmusdk
> -LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool
> +LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_kvargs
>   LDLIBS += -lrte_cryptodev
>   LDLIBS += -lrte_bus_vdev
>   
> diff --git a/drivers/crypto/mvsam/rte_mrvl_pmd.c b/drivers/crypto/mvsam/rte_mrvl_pmd.c
> index 73eff75..9d130b1 100644
> --- a/drivers/crypto/mvsam/rte_mrvl_pmd.c
> +++ b/drivers/crypto/mvsam/rte_mrvl_pmd.c
> @@ -11,6 +11,7 @@
>   #include <rte_bus_vdev.h>
>   #include <rte_malloc.h>
>   #include <rte_cpuflags.h>
> +#include <rte_kvargs.h>
>   
>   #include "rte_mrvl_pmd_private.h"
>   

Re: [dpdk-dev] [PATCH 4/6] crypto/mvsam: add support for AES ECB

[Andrzej Ostruszka]

Akhil

This is ECB mode so AFAIU there is no need for IV as this is not feed
forward/back type of algo and there is nothing extra needed by the first
block (same thing in ccp driver).

I'm leaving this as it is (same for 3DES).

On 17.09.2018 15:59, Akhil Goyal wrote:
> On 8/24/2018 7:24 PM, Tomasz Duszynski wrote:
[...]
>> +	[RTE_CRYPTO_CIPHER_AES_ECB] = {
[...]
>> +				.algo = RTE_CRYPTO_CIPHER_AES_ECB,
>> +				.block_size = 16,
[...]
>> +				.iv_size = {
>> +					.min = 0,
>> +					.max = 0,
>> +					.increment = 0
>> +				}
> iv size may not be zero in this case and also in other patch for 3des. 
> Please check

Re: [dpdk-dev] [PATCH 3/6] crypto/mvsam: add support for HMAC SHA224

[Andrzej Ostruszka]

On 17.09.2018 15:57, Akhil Goyal wrote:
> Hi Tomasz,
> 
> On 8/24/2018 7:24 PM, Tomasz Duszynski wrote:
>> Add support for the HMAC SHA224 authentication algorithm.
[...]
>>   	{	/* SHA224 */
>>   		.op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
>>   		{.sym = {
> doc shall also be updated for each of the new algorithm supported.

Doc is updated in pending patch:
http://patches.dpdk.org/patch/44253/

> Also please rephrase the subject as
> crypto/mvsam: support for HMAC SHA224
> 
> Please change the subject for other patches as well.

Changed.

[dpdk-dev] [PATCH v2 0/6] crypto/mvsam: add new features and fixes

[Andrzej Ostruszka]

This patch series introduces following changes:

* Add support for HMAC SHA224, AES ECB and NULL algorithms.
* Update hash digest sizes to match hardware capabilities.
* Fix a shared build.

v2:
  * added Cc: stable@dpdk.org to couple of patches
  * rephrased the subject/commit msgs

Szymon Sliwa (1):
  crypto/mvsam: update hash digest sizes

Tomasz Duszynski (5):
  crypto/mvsam: fix shared library build
  crypto/mvsam: support for HMAC SHA224
  crypto/mvsam: support for AES ECB
  crypto/mvsam: support for crypto/auth NULL algorithms
  crypto/mvsam: add 3DES ECB to the capabilities list

 drivers/crypto/mvsam/Makefile           |   2 +-
 drivers/crypto/mvsam/rte_mrvl_pmd.c     |  15 ++++
 drivers/crypto/mvsam/rte_mrvl_pmd_ops.c | 150 +++++++++++++++++++++++++++-----
 3 files changed, 144 insertions(+), 23 deletions(-)

-- 
2.7.4

[dpdk-dev] [PATCH v2 1/6] crypto/mvsam: fix shared library build

[Andrzej Ostruszka]

From: Tomasz Duszynski <tdu@semihalf.com>

Add missing rte_kvargs library dependency. Without that
shared library build fails due to unresolved rte_kvargs_* symbols.

Fixes: 25b05a1c806b ("crypto/mvsam: parse max number of sessions")
Cc: pablo.de.lara.guarch@intel.com
Cc: stable@dpdk.org

Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
---
 drivers/crypto/mvsam/Makefile       | 2 +-
 drivers/crypto/mvsam/rte_mrvl_pmd.c | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/crypto/mvsam/Makefile b/drivers/crypto/mvsam/Makefile
index c3dc72c..3290147 100644
--- a/drivers/crypto/mvsam/Makefile
+++ b/drivers/crypto/mvsam/Makefile
@@ -31,7 +31,7 @@ EXPORT_MAP := rte_pmd_mvsam_version.map
 
 # external library dependencies
 LDLIBS += -L$(LIBMUSDK_PATH)/lib -lmusdk
-LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool
+LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_kvargs
 LDLIBS += -lrte_cryptodev
 LDLIBS += -lrte_bus_vdev
 
diff --git a/drivers/crypto/mvsam/rte_mrvl_pmd.c b/drivers/crypto/mvsam/rte_mrvl_pmd.c
index 73eff75..9d130b1 100644
--- a/drivers/crypto/mvsam/rte_mrvl_pmd.c
+++ b/drivers/crypto/mvsam/rte_mrvl_pmd.c
@@ -11,6 +11,7 @@
 #include <rte_bus_vdev.h>
 #include <rte_malloc.h>
 #include <rte_cpuflags.h>
+#include <rte_kvargs.h>
 
 #include "rte_mrvl_pmd_private.h"
 
-- 
2.7.4

[dpdk-dev] [PATCH v2 2/6] crypto/mvsam: update hash digest sizes

[Andrzej Ostruszka]

From: Szymon Sliwa <szs@semihalf.com>

Update hash digest sizes to match hardware capabilities.

Cc: stable@dpdk.org

Signed-off-by: Szymon Sliwa <szs@semihalf.com>
Reviewed-by: Yelena Krivosheev <yelena@marvell.com>
Reviewed-by: Natalie Samsonov <nsamsono@marvell.com>
---
 drivers/crypto/mvsam/rte_mrvl_pmd_ops.c | 46 ++++++++++++++++-----------------
 1 file changed, 23 insertions(+), 23 deletions(-)

diff --git a/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c b/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
index c045562..e2cfc07 100644
--- a/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
+++ b/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
@@ -30,9 +30,9 @@ static const struct rte_cryptodev_capabilities
 					.increment = 1
 				},
 				.digest_size = {
-					.min = 16,
+					.min = 12,
 					.max = 16,
-					.increment = 0
+					.increment = 4
 				},
 			}, }
 		}, }
@@ -50,9 +50,9 @@ static const struct rte_cryptodev_capabilities
 						.increment = 0
 					},
 					.digest_size = {
-						.min = 16,
+						.min = 12,
 						.max = 16,
-						.increment = 0
+						.increment = 4
 					},
 				}, }
 			}, }
@@ -70,9 +70,9 @@ static const struct rte_cryptodev_capabilities
 						.increment = 1
 					},
 					.digest_size = {
-						.min = 20,
+						.min = 12,
 						.max = 20,
-						.increment = 0
+						.increment = 4
 					},
 				}, }
 			}, }
@@ -90,9 +90,9 @@ static const struct rte_cryptodev_capabilities
 					.increment = 0
 				},
 				.digest_size = {
-					.min = 20,
+					.min = 12,
 					.max = 20,
-					.increment = 0
+					.increment = 4
 				},
 			}, }
 		}, }
@@ -110,9 +110,9 @@ static const struct rte_cryptodev_capabilities
 					.increment = 0
 				},
 				.digest_size = {
-					.min = 28,
+					.min = 12,
 					.max = 28,
-					.increment = 0
+					.increment = 4
 				},
 			}, }
 		}, }
@@ -130,9 +130,9 @@ static const struct rte_cryptodev_capabilities
 						.increment = 1
 					},
 					.digest_size = {
-						.min = 32,
+						.min = 12,
 						.max = 32,
-						.increment = 0
+						.increment = 4
 					},
 				}, }
 			}, }
@@ -150,9 +150,9 @@ static const struct rte_cryptodev_capabilities
 						.increment = 0
 					},
 					.digest_size = {
-						.min = 32,
+						.min = 12,
 						.max = 32,
-						.increment = 0
+						.increment = 4
 					},
 				}, }
 			}, }
@@ -170,9 +170,9 @@ static const struct rte_cryptodev_capabilities
 					.increment = 1
 				},
 				.digest_size = {
-					.min = 48,
+					.min = 12,
 					.max = 48,
-					.increment = 0
+					.increment = 4
 				},
 			}, }
 		}, }
@@ -190,9 +190,9 @@ static const struct rte_cryptodev_capabilities
 					.increment = 0
 				},
 				.digest_size = {
-					.min = 48,
+					.min = 12,
 					.max = 48,
-					.increment = 0
+					.increment = 4
 				},
 			}, }
 		}, }
@@ -210,9 +210,9 @@ static const struct rte_cryptodev_capabilities
 					.increment = 1
 				},
 				.digest_size = {
-					.min = 64,
-					.max = 64,
-					.increment = 0
+					.min = 12,
+					.max = 48,
+					.increment = 4
 				},
 			}, }
 		}, }
@@ -230,8 +230,8 @@ static const struct rte_cryptodev_capabilities
 					.increment = 0
 				},
 				.digest_size = {
-					.min = 64,
-					.max = 64,
+					.min = 12,
+					.max = 48,
 					.increment = 0
 				},
 			}, }
-- 
2.7.4

[dpdk-dev] [PATCH v2 3/6] crypto/mvsam: support for HMAC SHA224

[Andrzej Ostruszka]

From: Tomasz Duszynski <tdu@semihalf.com>

Add support for the HMAC SHA224 authentication algorithm.

Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
Reviewed-by: Natalie Samsonov <nsamsono@marvell.com>
---
 drivers/crypto/mvsam/rte_mrvl_pmd.c     |  3 +++
 drivers/crypto/mvsam/rte_mrvl_pmd_ops.c | 21 +++++++++++++++++++++
 2 files changed, 24 insertions(+)

diff --git a/drivers/crypto/mvsam/rte_mrvl_pmd.c b/drivers/crypto/mvsam/rte_mrvl_pmd.c
index 9d130b1..5ef4139 100644
--- a/drivers/crypto/mvsam/rte_mrvl_pmd.c
+++ b/drivers/crypto/mvsam/rte_mrvl_pmd.c
@@ -113,6 +113,9 @@ struct auth_params_mapping auth_map[RTE_CRYPTO_AUTH_LIST_END] = {
 	[RTE_CRYPTO_AUTH_SHA1] = {
 		.supported = ALGO_SUPPORTED,
 		.auth_alg = SAM_AUTH_HASH_SHA1 },
+	[RTE_CRYPTO_AUTH_SHA224_HMAC] = {
+		.supported = ALGO_SUPPORTED,
+		.auth_alg = SAM_AUTH_HMAC_SHA2_224 },
 	[RTE_CRYPTO_AUTH_SHA224] = {
 		.supported = ALGO_SUPPORTED,
 		.auth_alg = SAM_AUTH_HASH_SHA2_224 },
diff --git a/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c b/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
index e2cfc07..d253b8f 100644
--- a/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
+++ b/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
@@ -97,6 +97,27 @@ static const struct rte_cryptodev_capabilities
 			}, }
 		}, }
 	},
+	{
+		/* SHA224 HMAC */
+		.op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
+		{.sym = {
+			.xform_type = RTE_CRYPTO_SYM_XFORM_AUTH,
+			{.auth = {
+				.algo = RTE_CRYPTO_AUTH_SHA224_HMAC,
+				.block_size = 64,
+				.key_size = {
+					.min = 1,
+					.max = 64,
+					.increment = 1
+				},
+				.digest_size = {
+					.min = 28,
+					.max = 28,
+					.increment = 0
+				},
+			}, }
+		}, }
+	},
 	{	/* SHA224 */
 		.op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
 		{.sym = {
-- 
2.7.4

[dpdk-dev] [PATCH v2 4/6] crypto/mvsam: support for AES ECB

[Andrzej Ostruszka]

From: Tomasz Duszynski <tdu@semihalf.com>

Add support for AES128/192/256 in ECB mode.

Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
Reviewed-by: Natalie Samsonov <nsamsono@marvell.com>
---
 drivers/crypto/mvsam/rte_mrvl_pmd.c     |  5 +++++
 drivers/crypto/mvsam/rte_mrvl_pmd_ops.c | 20 ++++++++++++++++++++
 2 files changed, 25 insertions(+)

diff --git a/drivers/crypto/mvsam/rte_mrvl_pmd.c b/drivers/crypto/mvsam/rte_mrvl_pmd.c
index 5ef4139..08d4a23 100644
--- a/drivers/crypto/mvsam/rte_mrvl_pmd.c
+++ b/drivers/crypto/mvsam/rte_mrvl_pmd.c
@@ -94,6 +94,11 @@ struct cipher_params_mapping cipher_map[RTE_CRYPTO_CIPHER_LIST_END] = {
 		.cipher_alg = SAM_CIPHER_AES,
 		.cipher_mode = SAM_CIPHER_CTR,
 		.max_key_len = BITS2BYTES(256) },
+	[RTE_CRYPTO_CIPHER_AES_ECB] = {
+		.supported = ALGO_SUPPORTED,
+		.cipher_alg = SAM_CIPHER_AES,
+		.cipher_mode = SAM_CIPHER_ECB,
+		.max_key_len = BITS2BYTES(256) },
 };
 
 /**
diff --git a/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c b/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
index d253b8f..3d3bbf1 100644
--- a/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
+++ b/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
@@ -298,6 +298,26 @@ static const struct rte_cryptodev_capabilities
 			}, }
 		}, }
 	},
+	{	/* AES ECB */
+		.op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
+		{.sym = {
+			.xform_type = RTE_CRYPTO_SYM_XFORM_CIPHER,
+			{.cipher = {
+				.algo = RTE_CRYPTO_CIPHER_AES_ECB,
+				.block_size = 16,
+				.key_size = {
+					.min = 16,
+					.max = 32,
+					.increment = 8
+				},
+				.iv_size = {
+					.min = 0,
+					.max = 0,
+					.increment = 0
+				}
+			}, }
+		}, }
+	},
 	{	/* AES GCM */
 		.op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
 		{.sym = {
-- 
2.7.4

[dpdk-dev] [PATCH v2 5/6] crypto/mvsam: support for crypto/auth NULL algorithms

[Andrzej Ostruszka]

From: Tomasz Duszynski <tdu@semihalf.com>

Add support for both cipher and auth NULL algorithms.

Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
Reviewed-by: Natalie Samsonov <nsamsono@marvell.com>
---
 drivers/crypto/mvsam/rte_mrvl_pmd.c     |  6 +++++
 drivers/crypto/mvsam/rte_mrvl_pmd_ops.c | 45 +++++++++++++++++++++++++++++++++
 2 files changed, 51 insertions(+)

diff --git a/drivers/crypto/mvsam/rte_mrvl_pmd.c b/drivers/crypto/mvsam/rte_mrvl_pmd.c
index 08d4a23..961802e 100644
--- a/drivers/crypto/mvsam/rte_mrvl_pmd.c
+++ b/drivers/crypto/mvsam/rte_mrvl_pmd.c
@@ -69,6 +69,9 @@ __rte_aligned(32);
  */
 static const
 struct cipher_params_mapping cipher_map[RTE_CRYPTO_CIPHER_LIST_END] = {
+	[RTE_CRYPTO_CIPHER_NULL] = {
+		.supported = ALGO_SUPPORTED,
+		.cipher_alg = SAM_CIPHER_NONE },
 	[RTE_CRYPTO_CIPHER_3DES_CBC] = {
 		.supported = ALGO_SUPPORTED,
 		.cipher_alg = SAM_CIPHER_3DES,
@@ -106,6 +109,9 @@ struct cipher_params_mapping cipher_map[RTE_CRYPTO_CIPHER_LIST_END] = {
  */
 static const
 struct auth_params_mapping auth_map[RTE_CRYPTO_AUTH_LIST_END] = {
+	[RTE_CRYPTO_AUTH_NULL] = {
+		.supported = ALGO_SUPPORTED,
+		.auth_alg = SAM_AUTH_NONE },
 	[RTE_CRYPTO_AUTH_MD5_HMAC] = {
 		.supported = ALGO_SUPPORTED,
 		.auth_alg = SAM_AUTH_HMAC_MD5 },
diff --git a/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c b/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
index 3d3bbf1..f3251aa 100644
--- a/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
+++ b/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
@@ -413,6 +413,51 @@ static const struct rte_cryptodev_capabilities
 			}, }
 		}, }
 	},
+	{	/* NULL (AUTH) */
+		.op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
+		{.sym = {
+			.xform_type = RTE_CRYPTO_SYM_XFORM_AUTH,
+			{.auth = {
+				.algo = RTE_CRYPTO_AUTH_NULL,
+				.block_size = 1,
+				.key_size = {
+					.min = 0,
+					.max = 0,
+					.increment = 0
+				},
+				.digest_size = {
+					.min = 0,
+					.max = 0,
+					.increment = 0
+				},
+				.iv_size = {
+					.min = 0,
+					.max = 0,
+					.increment = 0
+				}
+			}, },
+		}, },
+	},
+	{	/* NULL (CIPHER) */
+		.op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
+		{.sym = {
+			.xform_type = RTE_CRYPTO_SYM_XFORM_CIPHER,
+			{.cipher = {
+				.algo = RTE_CRYPTO_CIPHER_NULL,
+				.block_size = 1,
+				.key_size = {
+					.min = 0,
+					.max = 0,
+					.increment = 0
+				},
+				.iv_size = {
+					.min = 0,
+					.max = 0,
+					.increment = 0
+				}
+			}, },
+		}, }
+	},
 
 	RTE_CRYPTODEV_END_OF_CAPABILITIES_LIST()
 };
-- 
2.7.4

[dpdk-dev] [PATCH v2 6/6] crypto/mvsam: add 3DES ECB to the capabilities list

[Andrzej Ostruszka]

From: Tomasz Duszynski <tdu@semihalf.com>

3DES in ECB mode is supported by the PMD thus specific
entry should exist in the crypto PMD capabilities list.

Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
Reviewed-by: Natalie Samsonov <nsamsono@marvell.com>
---
 drivers/crypto/mvsam/rte_mrvl_pmd_ops.c | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c b/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
index f3251aa..62f5a2a 100644
--- a/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
+++ b/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
@@ -413,6 +413,26 @@ static const struct rte_cryptodev_capabilities
 			}, }
 		}, }
 	},
+	{	/* 3DES ECB */
+		.op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
+		{.sym = {
+			.xform_type = RTE_CRYPTO_SYM_XFORM_CIPHER,
+			{.cipher = {
+				.algo = RTE_CRYPTO_CIPHER_3DES_ECB,
+				.block_size = 8,
+				.key_size = {
+					.min = 24,
+					.max = 24,
+					.increment = 0
+				},
+				.iv_size = {
+					.min = 0,
+					.max = 0,
+					.increment = 0
+				}
+			}, }
+		}, }
+	},
 	{	/* NULL (AUTH) */
 		.op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
 		{.sym = {
-- 
2.7.4

Re: [dpdk-dev] [PATCH v2 0/6] crypto/mvsam: add new features and fixes

[Akhil Goyal]

Hi Andrzej,

On 9/21/2018 8:23 PM, Andrzej Ostruszka wrote:
> This patch series introduces following changes:
>
> * Add support for HMAC SHA224, AES ECB and NULL algorithms.
> * Update hash digest sizes to match hardware capabilities.
> * Fix a shared build.
>
> v2:
>    * added Cc: stable@dpdk.org to couple of patches
>    * rephrased the subject/commit msgs
>
> Szymon Sliwa (1):
>    crypto/mvsam: update hash digest sizes
>
> Tomasz Duszynski (5):
>    crypto/mvsam: fix shared library build
>    crypto/mvsam: support for HMAC SHA224
>    crypto/mvsam: support for AES ECB
>    crypto/mvsam: support for crypto/auth NULL algorithms
>    crypto/mvsam: add 3DES ECB to the capabilities list
>
>   drivers/crypto/mvsam/Makefile           |   2 +-
>   drivers/crypto/mvsam/rte_mrvl_pmd.c     |  15 ++++
>   drivers/crypto/mvsam/rte_mrvl_pmd_ops.c | 150 +++++++++++++++++++++++++++-----
>   3 files changed, 144 insertions(+), 23 deletions(-)
>
I am not able to cleanly apply your 3 patchsets.
http://patches.dpdk.org/user/todo/dpdk/?series=1172
http://patches.dpdk.org/user/todo/dpdk/?series=1440
http://patches.dpdk.org/user/todo/dpdk/?series=1442

Could you please rebase and send a single patchset if possible.
Also, I believe http://patches.dpdk.org/patch/44254/
can be squashed with http://patches.dpdk.org/patch/45104/

Thanks,
Akhil

Re: [dpdk-dev] [PATCH v2 0/6] crypto/mvsam: add new features and fixes

[Andrzej Ostruszka]

Hello Akhil

On 25.09.2018 17:24, Akhil Goyal wrote:
> Hi Andrzej,
[...]
> I am not able to cleanly apply your 3 patchsets.
> http://patches.dpdk.org/user/todo/dpdk/?series=1172
> http://patches.dpdk.org/user/todo/dpdk/?series=1440
> http://patches.dpdk.org/user/todo/dpdk/?series=1442
> 
> Could you please rebase and send a single patchset if possible.

The problem is that next-crypto is not in sync with next-net.  In
particular it is missing this commit:

7a39d1b common/mvep: add common code for Marvell drivers

Could you rebase/merge next-crypto with next-net to have this commit?

> Also, I believe http://patches.dpdk.org/patch/44254/
> can be squashed with http://patches.dpdk.org/patch/45104/

No problem I can package all patches into one set but as mentioned above
some of them depend on common mvep code introduced already in next-net.

Best regards
Andrzej

Re: [dpdk-dev] [PATCH v2 0/6] crypto/mvsam: add new features and fixes

[Akhil Goyal]

On 9/26/2018 3:33 PM, Andrzej Ostruszka wrote:
> Hello Akhil
>
> On 25.09.2018 17:24, Akhil Goyal wrote:
>> Hi Andrzej,
> [...]
>> I am not able to cleanly apply your 3 patchsets.
>> http://patches.dpdk.org/user/todo/dpdk/?series=1172
>> http://patches.dpdk.org/user/todo/dpdk/?series=1440
>> http://patches.dpdk.org/user/todo/dpdk/?series=1442
>>
>> Could you please rebase and send a single patchset if possible.
> The problem is that next-crypto is not in sync with next-net.  In
> particular it is missing this commit:
>
> 7a39d1b common/mvep: add common code for Marvell drivers
>
> Could you rebase/merge next-crypto with next-net to have this commit?
If it is dependent on net-next, then I will defer this set to be applied 
next week when the master is in sync with net-next.
>
>> Also, I believe http://patches.dpdk.org/patch/44254/
>> can be squashed with http://patches.dpdk.org/patch/45104/
> No problem I can package all patches into one set but as mentioned above
> some of them depend on common mvep code introduced already in next-net.
No need for now.. I will wait for master to get in sync and then apply 
the dependent patches.
Is there any series which can be applied without any dependency?
And it would be a good practice to mention the dependencies in the cover 
note in future.

-Akhil

Re: [dpdk-dev] [PATCH v2 0/6] crypto/mvsam: add new features and fixes

[Akhil Goyal]

On 9/21/2018 8:23 PM, Andrzej Ostruszka wrote:
> This patch series introduces following changes:
>
> * Add support for HMAC SHA224, AES ECB and NULL algorithms.
> * Update hash digest sizes to match hardware capabilities.
> * Fix a shared build.
>
> v2:
>    * added Cc: stable@dpdk.org to couple of patches
>    * rephrased the subject/commit msgs
>
> Szymon Sliwa (1):
>    crypto/mvsam: update hash digest sizes
>
> Tomasz Duszynski (5):
>    crypto/mvsam: fix shared library build
>    crypto/mvsam: support for HMAC SHA224
>    crypto/mvsam: support for AES ECB
>    crypto/mvsam: support for crypto/auth NULL algorithms
>    crypto/mvsam: add 3DES ECB to the capabilities list
>
>   drivers/crypto/mvsam/Makefile           |   2 +-
>   drivers/crypto/mvsam/rte_mrvl_pmd.c     |  15 ++++
>   drivers/crypto/mvsam/rte_mrvl_pmd_ops.c | 150 +++++++++++++++++++++++++++-----
>   3 files changed, 144 insertions(+), 23 deletions(-)
Series applied to dpdk-next-crypto

Thanks