From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 81EB54CC3 for ; Tue, 2 Oct 2018 08:32:59 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Oct 2018 23:32:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,330,1534834800"; d="scan'208,217";a="79133831" Received: from jguo15x-mobl.ccr.corp.intel.com (HELO [10.249.174.2]) ([10.249.174.2]) by orsmga006.jf.intel.com with ESMTP; 01 Oct 2018 23:32:54 -0700 To: Andrew Rybchenko , stephen@networkplumber.org, bruce.richardson@intel.com, ferruh.yigit@intel.com, konstantin.ananyev@intel.com, gaetan.rivet@6wind.com, jingjing.wu@intel.com, thomas@monjalon.net, motih@mellanox.com, matan@mellanox.com, harry.van.haaren@intel.com, qi.z.zhang@intel.com, shaopeng.he@intel.com, bernard.iremonger@intel.com, anatoly.burakov@intel.com Cc: jblunck@infradead.org, shreyansh.jain@nxp.com, dev@dpdk.org, helin.zhang@intel.com References: <1534503091-31910-1-git-send-email-jia.guo@intel.com> <1538316988-128382-1-git-send-email-jia.guo@intel.com> <1538316988-128382-4-git-send-email-jia.guo@intel.com> <522cf78b-c2f2-42b8-3b92-e7415b486846@solarflare.com> From: Jeff Guo Message-ID: Date: Tue, 2 Oct 2018 14:32:52 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <522cf78b-c2f2-42b8-3b92-e7415b486846@solarflare.com> Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2 3/4] pci: add req handler field to generic pci device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2018 06:33:00 -0000 On 10/1/2018 5:46 PM, Andrew Rybchenko wrote: > On 9/30/18 5:16 PM, Jeff Guo wrote: >> There are some extended interrupt types in vfio pci device except from the >> existing interrupts, such as err and req notifier, they could be useful for >> device error monitoring. And these corresponding interrupt handler is >> different from the other interrupt handler that register in PMDs, so a new >> interrupt handler should be added. This patch will add specific req handler >> in generic pci device. >> >> Signed-off-by: Jeff Guo >> --- >> v2->v1: >> no change >> --- >> drivers/bus/pci/rte_bus_pci.h | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/bus/pci/rte_bus_pci.h b/drivers/bus/pci/rte_bus_pci.h >> index 0d1955f..c45a820 100644 >> --- a/drivers/bus/pci/rte_bus_pci.h >> +++ b/drivers/bus/pci/rte_bus_pci.h >> @@ -66,6 +66,7 @@ struct rte_pci_device { >> uint16_t max_vfs; /**< sriov enable if not zero */ >> enum rte_kernel_driver kdrv; /**< Kernel driver passthrough */ >> char name[PCI_PRI_STR_SIZE+1]; /**< PCI location (ASCII) */ >> + struct rte_intr_handle req_notifier_handler;/**< Req notifier handle */ > > It is uninitialized now everywhere the structure is used. In the best case > it is initialized with zeros (if the structure is memset or partly > initialized > on declaration) and zero FD is a valid file descriptor. Is it OK? > The fd should be initialized as -1 as the structure of rte_intr_handler. >> }; >> >> /** >