DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: David Christensen <drc@linux.vnet.ibm.com>, dev@dpdk.org
Cc: stable@dpdk.org, thibaut.collet@6wind.com, tiwei.bie@intel.com,
	zhihong.wang@intel.com, jerinj@marvell.com, gavin.hu@arm.com
Subject: Re: [dpdk-dev] [PATCH] net/virtio: fix Rx stats with altivec vectorized functions
Date: Tue, 1 Oct 2019 12:00:10 +0200	[thread overview]
Message-ID: <f89aef11-1a51-7687-b50b-cb9eeee9b4be@redhat.com> (raw)
In-Reply-To: <20190930182754.20494-1-drc@linux.vnet.ibm.com>

Thanks David for the fix,

On 9/30/19 8:27 PM, David Christensen wrote:
> With vectorized functions, only the rx stats for number of packets is
> incremented.
> Update also the other statistics.
> Performance impact is about 2%
> 
> Fixes: fc3d66212fed ("virtio: add vector Rx")
> Cc: stable@dpdk.org
> Cc: thibaut.collet@6wind.com
> Cc: maxime.coquelin@redhat.com
> Cc: tiwei.bie@intel.com
> Cc: zhihong.wang@intel.com

The commit message seems like a copy-paste, so claim about performance
impact may be not true, same for the Fixes line, which points to a
commit when altivec was not here yet.


I'll fix that when appyling:

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime

> Signed-off-by: David Christensen <drc@linux.vnet.ibm.com>
> ---
>  drivers/net/virtio/virtio_rxtx_simple_altivec.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/net/virtio/virtio_rxtx_simple_altivec.c b/drivers/net/virtio/virtio_rxtx_simple_altivec.c
> index 1cd732dec..f856396ab 100644
> --- a/drivers/net/virtio/virtio_rxtx_simple_altivec.c
> +++ b/drivers/net/virtio/virtio_rxtx_simple_altivec.c
> @@ -49,6 +49,7 @@ virtio_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,
>  	struct vring_used_elem *rused;
>  	struct rte_mbuf **sw_ring;
>  	struct rte_mbuf **sw_ring_end;
> +	struct rte_mbuf **ref_rx_pkts;
>  	uint16_t nb_pkts_received = 0;
>  	const vector unsigned char zero = {0};
>  
> @@ -108,6 +109,7 @@ virtio_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,
>  			virtqueue_notify(vq);
>  	}
>  
> +	ref_rx_pkts = rx_pkts;
>  	for (nb_pkts_received = 0;
>  		nb_pkts_received < nb_used;) {
>  		vector unsigned char desc[RTE_VIRTIO_DESC_PER_LOOP / 2];
> @@ -199,5 +201,8 @@ virtio_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,
>  	vq->vq_used_cons_idx += nb_pkts_received;
>  	vq->vq_free_cnt += nb_pkts_received;
>  	rxvq->stats.packets += nb_pkts_received;
> +	for (nb_used = 0; nb_used < nb_pkts_received; nb_used++)
> +		virtio_update_packet_stats(&rxvq->stats, ref_rx_pkts[nb_used]);
> +
>  	return nb_pkts_received;
>  }
> 

  reply	other threads:[~2019-10-01 10:00 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-11 16:04 [dpdk-dev] [PATCH 0/2] Fixes in virtio " Thierry Herbelot
2019-09-11 16:04 ` [dpdk-dev] [PATCH 1/2] virtio: fix rx stats with " Thierry Herbelot
2019-09-27  9:08   ` Maxime Coquelin
2019-09-30 18:04   ` [dpdk-dev] [PATCH] net/virtio: fix Rx stats with altivec " David Christensen
2019-09-11 16:04 ` [dpdk-dev] [PATCH 2/2] virtio: get all pending rx packets with " Thierry Herbelot
2019-09-27  9:09   ` Maxime Coquelin
2019-09-30 18:27   ` [dpdk-dev] [PATCH] net/virtio: fix Rx stats with altivec " David Christensen
2019-10-01 10:00     ` Maxime Coquelin [this message]
2019-10-16 11:11     ` Maxime Coquelin
2019-09-30 18:42   ` [dpdk-dev] [PATCH] net/virtio: get all pending Rx packets in altivec vectorized paths David Christensen
2019-10-01 10:06     ` Maxime Coquelin
2019-10-16 11:11     ` Maxime Coquelin
2019-09-27  9:11 ` [dpdk-dev] [PATCH 0/2] Fixes in virtio vectorized functions Maxime Coquelin
2019-09-27  9:50 ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f89aef11-1a51-7687-b50b-cb9eeee9b4be@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=dev@dpdk.org \
    --cc=drc@linux.vnet.ibm.com \
    --cc=gavin.hu@arm.com \
    --cc=jerinj@marvell.com \
    --cc=stable@dpdk.org \
    --cc=thibaut.collet@6wind.com \
    --cc=tiwei.bie@intel.com \
    --cc=zhihong.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).