From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 19849A0579; Tue, 20 Apr 2021 11:05:34 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EB7D141638; Tue, 20 Apr 2021 11:05:33 +0200 (CEST) Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by mails.dpdk.org (Postfix) with ESMTP id D14CE411A5 for ; Tue, 20 Apr 2021 11:05:32 +0200 (CEST) Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4FPd4r3KvSz17R9H; Tue, 20 Apr 2021 17:03:08 +0800 (CST) Received: from [10.67.103.128] (10.67.103.128) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.498.0; Tue, 20 Apr 2021 17:05:21 +0800 To: Thomas Monjalon , Chengwen Feng CC: , References: <1617876888-63458-1-git-send-email-humin29@huawei.com> <1617876888-63458-2-git-send-email-humin29@huawei.com> <2544130.Cegyj9CWiX@thomas> From: "Min Hu (Connor)" Message-ID: Date: Tue, 20 Apr 2021 17:05:22 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <2544130.Cegyj9CWiX@thomas> Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.128] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH 1/2] examples/ethtool: fix Rx/Tx queue setup with rte socket id X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" ÔÚ 2021/4/20 8:57, Thomas Monjalon дµÀ: > 08/04/2021 12:14, Min Hu (Connor): >> From: Chengwen Feng >> >> The ethtool use the socket_id which get from rte_eth_dev_socket_id API >> in the init stage, but use the rte_socket_id API to get socket_id when >> setting ringparam. >> >> This patch make sure it call rte_eth_dev_socket_id API to get >> socket_id when setting ringparam. >> >> Fixes: bda68ab9d1e7 ("examples/ethtool: add user-space ethtool sample application") >> Cc: stable@dpdk.org > > The explanation is missing something. > Please tell why it is wrong. > > Hi, Thomas, It is advised that bind queue resources to the NUMA node where the device resides, not the NUMA node corresponding to the thread where the command line resides. And that will be better. > > . >