From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7FA5FA00C5; Tue, 21 Jun 2022 14:31:48 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6FB264069C; Tue, 21 Jun 2022 14:31:48 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150050.outbound.protection.outlook.com [40.107.15.50]) by mails.dpdk.org (Postfix) with ESMTP id 57D3140151 for ; Tue, 21 Jun 2022 14:31:47 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CFaOjn2Sc0ZlomSDUcTbVAv1B8JIWug0yJCthycMF3TOkj8cK29yJ/7GhvG2Aw4411oGcHevG87nSRcEfZ0L3/sT2WUu5QUJlSwfp/hUCAsldZmk+fm9P47tFMj2jB/67Toj+//NeOGOwx1dYVvGkRurGtPAT0AbmVSfrIIU48qFt9nCATcVptVzuPMHtZ0s9PHUXizVh3RzqIpIl6A59ZWw8RJ6f9lqAJ+hjbUcS0uUWWMWBQMlh4mfJZz3ZHskZWTOSpTXBBb7mFbpZYFbf08IlPThSQ97ruW4M8YX/KGFlZKyp3X0qkD1H1utkwjhy8Cqc3K8dh+7I6G+WO7x5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+iVMk3qkVtuDe1ngO3x2SGpVJ42UfzZ7AF7ajmwBjOc=; b=P7t268JhlcvmMSt6X6JNemXJ9OwqHrMMbwb1q1+74nlkEwi3b0mw4Hclha0tLNfR5Go55rs837pZiSYcBlwGMWFszEawEJuOG0nie37P5Ng9+FM2NZVGobxLDFX4Cu9YGsbBhgPd6E9qaoyBEzKXapqW+bSYu3Cx/KxhV4urey46RTKaZI0NQVvkj9xtznoSqDkpeayoeLQuS6/YMCxsyNrwCNrgJL2+Ex1p54Ied3dXmvztmYG2ZyKiXk/whrMDy3RCMPvy5vTN3Mi3LwK9Nlj4B9s1/HxLGfq/orZ4uyZU0V7kj2UM1vjcS9CRjbG/IWNd/BtThXx9Szw51QA51w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=xsightlabs.com; dmarc=pass action=none header.from=xsightlabs.com; dkim=pass header.d=xsightlabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xsightlabs.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+iVMk3qkVtuDe1ngO3x2SGpVJ42UfzZ7AF7ajmwBjOc=; b=Ljhv4bVUyBZuiMibe8ZLioIrOGZJ2P3HDxoCtBgdGnFgRV/KIzGhnkhmmT3vvAOx5ycQV/wMmEN0pbEDbkstB5pFBEdJx7rZn7yt0fHnVwSjch/y+1b9HlxSM2D5pOf7wPD+FtUtNdMxvbutZjJ6xIAVY5/oyICzSdWHxXKTvg0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=xsightlabs.com; Received: from DB9P193MB1482.EURP193.PROD.OUTLOOK.COM (2603:10a6:10:2a6::7) by DB9P193MB1403.EURP193.PROD.OUTLOOK.COM (2603:10a6:10:2ae::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.15; Tue, 21 Jun 2022 12:31:46 +0000 Received: from DB9P193MB1482.EURP193.PROD.OUTLOOK.COM ([fe80::61af:58cb:6533:1aaf]) by DB9P193MB1482.EURP193.PROD.OUTLOOK.COM ([fe80::61af:58cb:6533:1aaf%9]) with mapi id 15.20.5353.022; Tue, 21 Jun 2022 12:31:46 +0000 Message-ID: Date: Tue, 21 Jun 2022 08:31:39 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v6] eal: allow worker lcore stacks to be allocated from hugepage memory To: Thomas Monjalon , "Burakov, Anatoly" , Dmitry Kozlyuk , dev@dpdk.org, David Marchand Cc: Stephen Hemminger , Chengwen Feng , =?UTF-8?Q?Morten_Br=c3=b8rup?= , Bruce Richardson , Honnappa Nagarahalli , nd , "Wang, Haiyue" , Kathleen.Capella@arm.com References: <20220502141058.12707-1-donw@xsightlabs.com> <20220524195138.4963-1-donw@xsightlabs.com> <11989770.5MRjnR8RnV@thomas> From: Don Wallwork In-Reply-To: <11989770.5MRjnR8RnV@thomas> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: VI1PR08CA0253.eurprd08.prod.outlook.com (2603:10a6:803:dc::26) To DB9P193MB1482.EURP193.PROD.OUTLOOK.COM (2603:10a6:10:2a6::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 95422fbd-e112-407d-38f3-08da53820165 X-MS-TrafficTypeDiagnostic: DB9P193MB1403:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: W1VzbdbVW+ou9vC1yGZS3xFynzSHhzNwmvonLt6ewy8UKiHBLMatBJ36Z0avB7RVdqz4ZN+h80wuT1LqbUHVGDRN+Qd/ACxut9avivZJIpRQpMKpyKWV0NKc2myYDHz8JbOb/sXGK/3zXrIsdAl+zVzt0c1Jcl0iTHkSsb4q5d54tl4g/atvBZqCM6w1sjm7ZF+WgzejaMeQvWxRzeGZyYVxC+troYUGIGJjnRNEqARxmKjdjuQ8Kruwd1G5MkiOQsClD8yilbNIa5DHb24VFazTAIXlWZ7dRLG+mlBYfRKlChBiKfB2pcBlbenxAvdEP9iwwIc/dgKIV/ZoqkpwRolBN2T5Pnj08r8PSKcgko1Afuhpjyszl2mFyLRgTZT7aTQTuG4klRErmBa+tH96RL3D5QylwVshEB8NEu44NhMVWoDq2GFjSclLjwV+Dh59f2OvFJWEzCWu1skbo4xGKJRrP1ahg0FlkFH4EIdl8S9RcByqgmiBNSFmvUYIvF2muqHfGg2+VgrIopgpTL4Ii/pg5uZC196zltsYmlsIK22Pem3maM903P5fgBfQeNXAXSV1U9UvfOf0jw1mdiS6ht0mapasbHgvlegHhiR/2X6apbYJ7qiMXZlboHznFsk2m8S/Hu8eSqqSpkG9K6SGAs1iBN0dY6KA+oxuxeJkjiuS6TW6YpbnM2R2VmHglwBPNM/pgjbbyWqOyby34Dk5U3179B2L+yI3e3sJdTs9xNNtWGMiBXGa+w5rWXzkVFaG80rNQAI+zrr1ssU00sZ2Uw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB9P193MB1482.EURP193.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230016)(4636009)(136003)(39850400004)(376002)(396003)(346002)(366004)(86362001)(31696002)(8936002)(36756003)(478600001)(38100700002)(38350700002)(5660300002)(6486002)(2906002)(316002)(7416002)(6512007)(8676002)(6666004)(66946007)(4326008)(66556008)(66476007)(54906003)(2616005)(83380400001)(110136005)(52116002)(53546011)(6506007)(26005)(41300700001)(31686004)(186003)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZkkwUGdlRDRtS0l3SGZIcFJ6cWxhc2xDZDJwOU9iS1l0VmVmN1pUNXNGNEpa?= =?utf-8?B?T0NTKzZ6dlYxTmxnOEFzVEdzU0tIYks4ZnVHQ1BidFJRczM2NzNqam5CL1Zh?= =?utf-8?B?VnhNN2VieG1xbmY3RGFiZ2FITDBwL3JJc0c4NU9FV01xNndoakZzaUc1WjNq?= =?utf-8?B?SUplQm5wUGhIRk5XVUhpaTFxSkdvTk54UVpUR3FEeDU5VFk3Y0gzOTNIa28v?= =?utf-8?B?UWFrKzYxUzVySy8wS05LQnlTZ0lKSHUvWjYzVzkxT0orRHdzM0ZJME83YTdZ?= =?utf-8?B?THRSb0pSTWtxYUxKa2thbzZlNVlEZi9RVmM4TnI5Q1hhRndHRzN1SytTeDJL?= =?utf-8?B?SHd1YURiUnI0b0ZMSzVYWHJpVlAzeUlJR0orT3g5QXhYVWltWXV5b0h1Nmt5?= =?utf-8?B?SU9nU1hHYzZ5VWpxWHcvT3YxZllzNlUvUUQ2ajh1UjBIUDFndFhFdzNLTU5n?= =?utf-8?B?SWNFQWkxMWRYSy9lMXg3SUFidFhobXhjMzEwNFNhU1pCd0o3N0J2NmdXSi9j?= =?utf-8?B?VHVpZURpeVEyUTdUNWNtMUQ1TTNwNGJxNFNWQzVoY0hvRW5ZWXlWQUpEY3RP?= =?utf-8?B?dTFicXFYWWxsNk9BT3lKVHBTRGNKTVJ4cjdBTEhKakhlTjNibVlndmF4dzlT?= =?utf-8?B?WXJrejQ5ck9XS0RGU09jOHZJQjZwRE44Tzl6UEp2S3liYVJVZHRuRmZxRzRG?= =?utf-8?B?YmRkbS8zakk3OWk2a0tjVDlmb214VnNOd3h6TDE2VC9JTy9aRk5oU3dSTzV4?= =?utf-8?B?QU9UM0kySWZxckwxOCswZFM4MWFMYXE1Sm1GK0dOdnplSEZaZm4xcWFJVXg0?= =?utf-8?B?MUVaaHdtLzdTcEh4Rm5rRTYvNnZXck9oa1BnWDVRNW9YM3dtYm91SzRYRzBo?= =?utf-8?B?ZE44eEZKV3pQM0l2R042VVdSN0pUaHo3NldkK2ZsODNvQktOM1pjZSs0OVZx?= =?utf-8?B?U3ZPdVdNdGZLOHliSHZGc1VyUlFEZDIxM0pyZFJQVE9hazU3bmUvUmlOSk0w?= =?utf-8?B?SmxialNqTXdUSFBUR3RkWjl1eXJwdFRSU094cndVTXQyOUI2TTNEMDJVcDdm?= =?utf-8?B?QnpBa0pCTU4zZ3Rsc2g5bzVKaFM4VWtWa09vR25TNG9IdHVIRDdYdjdjYkhE?= =?utf-8?B?eHZnZURxY2RMRjMzaHk3SkR6dHBtcnVVRmVpSGhtU1AxZWl2cllVcDZBNzNa?= =?utf-8?B?Qm9leDZkZUowS1hQNTRpUmxYTkZPcG1MTVd5L1hUNUFxOWRRRGlucnZvVnpD?= =?utf-8?B?UzdIL0Jjci9UMHllRkZPemYrMDhGL0VybzZkcnJZMFpWbVBBdkJ6V0dIK0NK?= =?utf-8?B?VGRzczh2b293UEtDbFovM2RlVVdmN0VWUmpobEs4UnVnZldraHpwc0hCRm1J?= =?utf-8?B?VXB4MVBrUTYyd2xJTXU1RjZxRzJtUVdFMWMrcXN3V1UvbEtEai85QVpaMUcr?= =?utf-8?B?b2MvcllzdEpzVTJVeXE2Z2VnOXd5cG54d1lqVVBJTXF3alhKY0RVNDdiZVBv?= =?utf-8?B?b05TazQxNHpCOHljbGVxbnVRYjhYVVByUEc2WitEeWMxeVlrUk0rbjJQemtx?= =?utf-8?B?bEpBS1BQT0JUUElHRlFRMWF3QmNJVkVpZUtSYWZ1c2dQTUZ1ZS9kM1oyMnRn?= =?utf-8?B?YUZVdmFCUTd6dWcrb2taTzMvQWNTdUd5Nm95dTUwQmhFd3FjNk4xZTduRVZo?= =?utf-8?B?bW5jVTJHdDlIU3lDZGZyTkc0WEhGekZod2dvNVBpT3dmcENvOEZ5Szk3ODdh?= =?utf-8?B?MllKYkRWakdOb29mUitoN2dhMFR3ZzNVV2lEYzFZemRucDhkbkVBc05zU096?= =?utf-8?B?UmpYTjg0YWo0SXRWaGRkNmxKd1JmZkpnSWFJWmQ5TnZnaUE2WUNWMk9XK00z?= =?utf-8?B?aldWNVJ1ZDZsMHN1ME9VTk53MHh5L1ZPMGpRNytHN1ZOMlRKR2hjaVc1YTVX?= =?utf-8?B?dEVyQVJxT0Z0L2VrKzYvVGtlL3BsR3I4RUtNYzFaeGF1M1dCU0ppS1lJUWRT?= =?utf-8?B?S3U2cHBkZWV1RnFkS0RzcUk1UkEzM3ZCKzhVOWhIOUJwekxkU3hNZ2ozYzdv?= =?utf-8?B?eU5UODJ1YUNtbVYwUmZwUDZVamc1dHFadHdkeVplby9qY3pHWURReUxvL0M3?= =?utf-8?B?SXhUWE5td2luTFRLZnh1d29ad2lVZ2Zoa1dMYTBBcFY0MHgzQkZYZXJjY3c4?= =?utf-8?B?SnRTcVQyWGJLYmhLSE5FaVllNkt3Q1RieHlWR0ZMVzFjK0NrQWtaVDRacUh4?= =?utf-8?B?UGY3U2NXY293SUhsL0lpSjFSSmtHVFZaUTRqVmkwcEtoNW1nSWZvUnlFT3V0?= =?utf-8?B?TGNadXQrRHhHWnIxbG1kVWVsanMzVVZVMkFFcE52RjVTNTdUaHh3Zz09?= X-OriginatorOrg: xsightlabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: 95422fbd-e112-407d-38f3-08da53820165 X-MS-Exchange-CrossTenant-AuthSource: DB9P193MB1482.EURP193.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2022 12:31:46.2642 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 646a3e34-83ea-4273-9177-ab01923abaa9 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sRAux5UGxQyX9NY62w82rg1z+yfoG65PHiUQKqgBrUKBWU3p3OzURi9/3V01x6ONziTTDBOmeAYWh6VV8w7eLg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9P193MB1403 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/21/2022 6:37 AM, Thomas Monjalon wrote: > 20/06/2022 10:35, David Marchand: >> On Tue, May 24, 2022 at 9:52 PM Don Wallwork wrote: >>> Add support for using hugepages for worker lcore stack memory. The >>> intent is to improve performance by reducing stack memory related TLB >>> misses and also by using memory local to the NUMA node of each lcore. >>> EAL option '--huge-worker-stack [stack-size-in-kbytes]' is added to allow >>> the feature to be enabled at runtime. If the size is not specified, >>> the system pthread stack size will be used. >> - About the name of the option... I don't have a better name. >> >> Just want to highlight, that what this patch does is use the DPDK >> memory allocator for the stack memory. >> It happens that DPDK memory allocator is primarily used with >> hugepages, but this is not systematic for example with the "no-huge" >> mode of the DPDK memory allocator. >> >> IOW, in this patch current form, you can still run as: >> >> # dpdk-testpmd -c 3 --no-huge --huge-worker-stack=16 -m 40 -- etc... >> >> Opinions? > The name of the option should not include "huge". > What about "--worker-stack" ? > If disabled (equal zero), the workers should use the default stack memory. > > Wouldn't that have the potential to create confusion?  The point of this change is to allocate worker stacks from hugepages.  Removing huge from the option name could give the impression that the command is simply to control worker stack size. Regarding your other comments, I'm working on another patch that will address those.