From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0C17042B47; Fri, 19 May 2023 10:42:36 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D97D541148; Fri, 19 May 2023 10:42:35 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2046.outbound.protection.outlook.com [40.107.94.46]) by mails.dpdk.org (Postfix) with ESMTP id E77AD40F16 for ; Fri, 19 May 2023 10:42:33 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XKK5iWeXWM34L0ih0GzY07Qs8fKKH+zd3hQNE5VPO6CwBtGY5Bn8LhyfuB71XZSmDIpLaacQo/bCfGD19/SY9ifp9rqtaDpwNRHUrytj2jKZxHc5ti2Tg/ukwtizqwRl+ardy3CdBVvFBR8TXbDLFdOIlstdBdznjwb3JFp5pVYKRxaofxlvthi+e+K1bKv55xt9QoHQFTOwP1E1XRWuMO+NetRPfGGRmMPZ7/OZrdaVlCdfoaBTysUF+qhqdvOyXjihQGBA/N1XGVNAWG6hoIDCGPNRLS4ZluvUrvHNu9Gf23gbCqQLNbyE9dX83tb/btGifhU4fUCZU5cNz+G/uA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w7oEuD6awlp9+fNrLNmFYtMK5IHeE2QsURO9nja04qY=; b=e1QIDYCVAKGlvZBFo5xSxPGbs+bp3KYSnXJSEfryIcoExo+DyFrrpnX+FhIzkEz2SmpS09jN6w3EGwgbr/S7tdieq+XysueLAvWoYBi2T1reCYGXtpQP/u9wJQInOU1e09ZnUDERyeORGoZzpb5eAsOslXXk1/t976Laysbs41tKRS4/UbSF5Efh1oDavTi50PutEssEg2/ImUA6verurQbSFMIbozcun4wdW7s1IQiH9YHFp5I0nq6L/iQ5I/m4kwv9vG5JMNVX+wbyTlfO7w3OzcSoteIKc+FqMP+2AKns7W3l4S2RmEir5AosNLcxfKafp81XYbyqFFgGbfcH+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w7oEuD6awlp9+fNrLNmFYtMK5IHeE2QsURO9nja04qY=; b=mAdDj3pRJPJvZzHl/i9P7sSAlGXlJfqY/6bCCBshP8UInI718kQYTCavySLoH0SCk8nzKvNZHuxiCuj+xkVpV6xd0h6We0z0l8quH6eWEvVTqDHLbFEDld9O7t3WIhzfQRz1UK6qdh+zOl9x/swiYP1TJigH5bdyb6mdJmI1CBs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by LV2PR12MB5797.namprd12.prod.outlook.com (2603:10b6:408:17b::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.17; Fri, 19 May 2023 08:42:31 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::7957:641d:6aba:3f9a]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::7957:641d:6aba:3f9a%4]) with mapi id 15.20.6411.019; Fri, 19 May 2023 08:42:31 +0000 Message-ID: Date: Fri, 19 May 2023 09:42:25 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH V9] ethdev: fix one address occupies two entries in MAC addrs Content-Language: en-US To: Huisong Li , dev@dpdk.org Cc: thomas@monjalon.net, bruce.richardson@intel.com, andrew.rybchenko@oktetlabs.ru, liudongdong3@huawei.com, huangdaode@huawei.com, fengchengwen@huawei.com References: <20221020093102.20679-1-lihuisong@huawei.com> <20230519030016.34526-1-lihuisong@huawei.com> From: Ferruh Yigit In-Reply-To: <20230519030016.34526-1-lihuisong@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0515.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:272::7) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|LV2PR12MB5797:EE_ X-MS-Office365-Filtering-Correlation-Id: c965ce40-efa1-4e36-7a24-08db5844fc05 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zsxu6GG0AUMOTL8gOqsw2Wp66/w9GKgIUVmWzJjq8fKxbyhmFGIs/C/nYqTBaiRnVRaGIBhme8fCsR4eUtite9pQ03HyRdypJvlknfbdDYKFxCVDZX3I5SJpcgKbtrtpzwr9KX6Wk8Zmb6fWF/ZT0rVTn9ktfu0JiRh6A4n7sbfQbUJkEnVzuelZ1+ySNOmH/Cmrm0ROKuDeh6ma59dP9n/IwdjVRUv+tcMMPFj5QtmO4u/WdqqhI/JiTBXQv8S+Rsomcnj/71WHsO8XyqaWax0tuIojTGINdarmuEFJyp0oAel+Fhvhc3VpG6pM0bP+vKMaKsqUNqmiU03NoKnMQ1gvNXEz2Ri78z6ZzzeYukzOWxKaG/DBmsOatfv5WWZxvZeQ7/RztFNAjUQTQRdYZu6YrtHUgU2gwnhL2qoMRYxf6wo783STNJhIq/R9H6SeOGfb9ZFVsjIQ418rixUN3oe5dwMT6RxAbnM5q7IcWFFdBEp7DXV4ShhUd/h1D8b/MdnevM67ANG/cdgCyToMSrV8kYdQEwJ8PLE2PIsCEyNhPE+gNnwX19IIfvio7Kg/H4dLrOy6S0teZzXqqw6BWsMW+8V42DVTMybLQQkQ3Uohkgne6gCwq47p9pZfn7de2YfODX81pC+R4lijUW4Cjw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(346002)(376002)(396003)(136003)(366004)(451199021)(6512007)(6506007)(31696002)(2906002)(186003)(4744005)(53546011)(26005)(86362001)(2616005)(36756003)(38100700002)(316002)(41300700001)(6666004)(6486002)(4326008)(66556008)(66946007)(66476007)(31686004)(478600001)(5660300002)(44832011)(8676002)(8936002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SEN1YU45blp3SGxFa3dXRUJuUmtMMTRoWE9YWW5HVE9Xb01CS1pQaXZBcDZX?= =?utf-8?B?ZW10SjhYQy9mTHhpUndKT0p5ZUxJb3RHTmVQeGI0R0tjTkJVU3VrbHdPcEFT?= =?utf-8?B?WVczYlM0UXcxelZieEJwRTEvdFBHZmRDMTN0SFlRSC81bVZpZmdPTjRWdlkx?= =?utf-8?B?QXdweVhIcHZYTldnbnBleGJudVZoSjdYVkV1VjhmMTF1U2JRa3UxLzYyTER4?= =?utf-8?B?UUZXV0J6YXZFQmJXa09tZGcrUUtqU3d3TWhHb1MxYkE3a0dwdUd2MmpqSUZN?= =?utf-8?B?RGtrMTdBd3ZMLytZOXRRMy9pNGE5N0p4QlB6RDdUY3dBZURtQ1VraG1vYjZh?= =?utf-8?B?TEcrRFB2L0Z0NVVWTURJVks4YlliMzFqYm1DME45WWRQT3hRMDFjK1BHQ2xV?= =?utf-8?B?ZFZlbnJqbWQwYXljQzZpUEliQVJNUmpRTGZwbVRvYTZVVm1iQmg3QmF5TTFZ?= =?utf-8?B?NjZLbGx2ck1JenNtb2c2VjkrL0N2Vll0VEZJTFVtd1JwSVhSQWcrRVZvQ2Zy?= =?utf-8?B?NHpWaXFKejNoWC9XT2RpS0dhczVUL0FNQ2pCd3QxR2xUZVByKzhYK2Z3aEc4?= =?utf-8?B?V1IzVGJFRmV0NVpLK3J0UExjVk9DSzZ6WkI1S0JqNk40VEhoQ0RvazE0K0N4?= =?utf-8?B?bU1XZC83WTBuTjNUc1JGVEU3SXlXc0wyNDBpeE1VUUYwZ050eG5lY01sOWk0?= =?utf-8?B?Q29iUjNyWmU1OVN2RGhiOEpaeEF4RGNlTTlUQlBWVG1EOVl1enNLc0NBREpS?= =?utf-8?B?elk0czkvWjlnK3Z5ekYyQnVJRkNCWTB2NmVKdlBQZGZCbm9BdEZVaFdtci9o?= =?utf-8?B?bUlkb1laM1ptRk4xc0xKSTFheG8weFVXSUY4M2dIU2JxN3h4bko0ZEozOGFV?= =?utf-8?B?elA3dDc3QnBvRXZxa1pybElUUzdKVHVxTm44OXNkNjBwNG5nV0ZtN2ZyK0Q5?= =?utf-8?B?U0J3UGVxd2VRb0thQnRSMlByaDM2T2h2TjZEVGd0NjNnbVNWRVZyQ2pMRlNR?= =?utf-8?B?aXVsczZtZXlYZmdSRkhDU3hwenF3M1ZoV3BHb1hoQTFZdjBIbGpna2VjSW5a?= =?utf-8?B?OUNCTFVGcm0zbW1jQ29JbE5lTTFVTHRVVldFSzZEYVhkaWtqb1ovSVF1c2pQ?= =?utf-8?B?V3NNNU9DNnFDckQyVTZqTDlFMlI0NXYwclJwYlBEQmUzMjR4T2UwRW9OUnlV?= =?utf-8?B?Z242NkFhekN4ZzVjcnRxMGtIZ3Y0SWMyZzhxSGdNdERINXRyc1ducnFPNVdw?= =?utf-8?B?VnE5SUxJeXZ5K1JsdEhMbUJreU0wQXdlTzc1MTc2cm1DdlVFa291VXdVcUJC?= =?utf-8?B?V3ptbjdiUk01ZmtqSklxbWVMWWNsd3Znd003a0FaN1p3YTRWM2I5c3ZSVnkz?= =?utf-8?B?c09FTEJwMzhSb1NqRFlrNFlTYUg3d1NqTGx2WFRhQkZBTDdCN2xSNDBCOCtp?= =?utf-8?B?Rm5EcEk5eE84QWNtYlFOWTFsSnRuaVMyQ21walgzNHkxRjR5YXFkQ3NmSVVi?= =?utf-8?B?N3pNNFlLTHNNd2FRWlhhRDBaMmtSTjFBNmFZbW9WR2NXOEc3TGF5QlZUYnFG?= =?utf-8?B?bkZYZFBaa3d1aG00MVlmVllwRDc5eU9zSGJJMlZtZWJ6Wnlmby9la2hTKzI5?= =?utf-8?B?SkpnUlZOSitvNFc2ejBtRXhwQUNtUnZRUVlnY1pLTDhzMEdNOEZTSER5Zm5M?= =?utf-8?B?NW5sY0JtdmMvZE0xRkNVWlh6bWRsV29EUCtWa3F4NmhsS0UzQ2Q0dGhSOGZG?= =?utf-8?B?RU55NjhST2hadUVYaVg3UEVPZXpmSVgxay9Dd3cvK0kwWGJ2UXJyWGkyV1Fk?= =?utf-8?B?NnlnK2Z3NXlQYzNXQ0YyY093YzFyVlVFdldDV3ZYRk15T005WXVmT1BaNWdJ?= =?utf-8?B?cG9ZUnpINHQ0bStsbHcwMDZYMFpodkJMTEp6eU56YVdERC9ZdFFrYmw4MHpq?= =?utf-8?B?UFI3SWs3Zk51aHd5NXNjVmc4ZGZPWUlqQnR0N2hBcHl1dFhBd1R1MCtBZVo3?= =?utf-8?B?TW4zMDI3SEttVmdjNk1kSG0xanN0Q0QxUzRRT3dFYWkrR1Z6U0JZWU14cjNu?= =?utf-8?B?UW4vSnJ4b2sxV09sbUdnYzM3TEVMUld4Z00wWS9JaDZMZkI2Z3cyczcwRlp0?= =?utf-8?Q?UwpZPEUSIDGx/WhTqPWKEVR31?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: c965ce40-efa1-4e36-7a24-08db5844fc05 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2023 08:42:31.5458 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kimK2ZIsrHfYf3TET2l6BLTkYZO9ZxBA8H/mDGHX4Q4ZqFp2oir71ITTuiXFbSKk X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB5797 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/19/2023 4:00 AM, Huisong Li wrote: > diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h > index 99fe9e238b..09b2ff9e5e 100644 > --- a/lib/ethdev/rte_ethdev.h > +++ b/lib/ethdev/rte_ethdev.h > @@ -4381,6 +4381,9 @@ int rte_eth_dev_mac_addr_remove(uint16_t port_id, > > /** > * Set the default MAC address. > + * It replaces the address at index 0 of the MAC address list. > + * If the address was already in the MAC address list, > + * please remove it first. Can you please document last sentences under '@return' as (-EEXIST) error type?