* [dpdk-dev] [PATCH] net/mlx5: fix creation of drop flows
@ 2017-06-15 8:25 Nelio Laranjeiro
2017-06-15 12:34 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Nelio Laranjeiro @ 2017-06-15 8:25 UTC (permalink / raw)
To: dev; +Cc: Adrien Mazarguil, Shahaf Shuler
Drop flows being created when the port is stop should not access to the drop
table hash queues as it is invalid.
Fixes: 028761059aeb ("net/mlx5: use an RSS drop queue")
Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Acked-by: Shahaf Shuler <shahafs@mellanox.com>
---
drivers/net/mlx5/mlx5_flow.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 8b3957b..96bbf42 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -1004,9 +1004,9 @@ priv_flow_create_action_queue_drop(struct priv *priv,
}
rte_flow->drop = 1;
rte_flow->ibv_attr = flow->ibv_attr;
- rte_flow->qp = priv->flow_drop_queue->qp;
if (!priv->started)
return rte_flow;
+ rte_flow->qp = priv->flow_drop_queue->qp;
rte_flow->ibv_flow = ibv_exp_create_flow(rte_flow->qp,
rte_flow->ibv_attr);
if (!rte_flow->ibv_flow) {
--
2.1.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx5: fix creation of drop flows
2017-06-15 8:25 [dpdk-dev] [PATCH] net/mlx5: fix creation of drop flows Nelio Laranjeiro
@ 2017-06-15 12:34 ` Ferruh Yigit
2017-06-15 12:50 ` Nélio Laranjeiro
0 siblings, 1 reply; 3+ messages in thread
From: Ferruh Yigit @ 2017-06-15 12:34 UTC (permalink / raw)
To: Nelio Laranjeiro, dev; +Cc: Adrien Mazarguil, Shahaf Shuler
On 6/15/2017 9:25 AM, Nelio Laranjeiro wrote:
> Drop flows being created when the port is stop should not access to the drop
> table hash queues as it is invalid.
>
> Fixes: 028761059aeb ("net/mlx5: use an RSS drop queue")
>
> Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> Acked-by: Shahaf Shuler <shahafs@mellanox.com>
Applied to dpdk-next-net/master, thanks.
This required solving merge conflict, although it looks simple, can you
please confirm the final commit.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx5: fix creation of drop flows
2017-06-15 12:34 ` Ferruh Yigit
@ 2017-06-15 12:50 ` Nélio Laranjeiro
0 siblings, 0 replies; 3+ messages in thread
From: Nélio Laranjeiro @ 2017-06-15 12:50 UTC (permalink / raw)
To: Ferruh Yigit; +Cc: dev, Adrien Mazarguil, Shahaf Shuler
On Thu, Jun 15, 2017 at 01:34:31PM +0100, Ferruh Yigit wrote:
> On 6/15/2017 9:25 AM, Nelio Laranjeiro wrote:
> > Drop flows being created when the port is stop should not access to the drop
> > table hash queues as it is invalid.
> >
> > Fixes: 028761059aeb ("net/mlx5: use an RSS drop queue")
> >
> > Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> > Acked-by: Shahaf Shuler <shahafs@mellanox.com>
>
> Applied to dpdk-next-net/master, thanks.
>
> This required solving merge conflict, although it looks simple, can you
> please confirm the final commit.
it is good for me.
Thanks Ferruh,
--
Nélio Laranjeiro
6WIND
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-15 12:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-15 8:25 [dpdk-dev] [PATCH] net/mlx5: fix creation of drop flows Nelio Laranjeiro
2017-06-15 12:34 ` Ferruh Yigit
2017-06-15 12:50 ` Nélio Laranjeiro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).