From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A560B41CC0; Fri, 17 Feb 2023 15:00:52 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8637640EE3; Fri, 17 Feb 2023 15:00:52 +0100 (CET) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2060.outbound.protection.outlook.com [40.107.102.60]) by mails.dpdk.org (Postfix) with ESMTP id 419C840EE1 for ; Fri, 17 Feb 2023 15:00:51 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nsX2ZarODTdET2H1QJ6JgeQm9p8pmnsZIfDr/78CYdBs2a5TREBfBwAbIlIxKrIGsnm10j7QKqpGgvaj6nQ0BexzEYpvnikbCNp/2S/wTCgDxyVEy1IivDuTuuSolM9hITphbfTngL2TypiutmPtrzLXk6DZpH0XgLXuUdQ/oRBjYvH6cTQI1GcJL+gYjC/6YuWaZgvWk++X9tQ+q9VVQxCqgCDR6Fisl1Xu8/1K5rB5rxPoEegHDFSS9qga6t7DSfgTV2IfESGDpc3nHqsGa5JVedhFsg+BMuXVekDQAe2PteqQjnWJsWQ1xBysEuXoOIoDUPpBAQG04Uh2ASbsRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JnlzmSHozjMLwET1RbYxMLHxZowcrs8zgGL4xQXadmI=; b=DaId4adgcW/A+jhatgYNSPS2hSfKQuUAd29hWLuEzEjTczwWTEPGkWApptGTKZ4RD79CZN4xP1wn+wvDiBPQkZk6v+u9xQJ+gQmbRW1Gy4UEQSmAXFC34quMXLSn/X3gJyJewPZQHaSuVkVtnvHwE1rX5OFxqNPstL4MW0L9yHaAwIrQEg+i4Y/G/MN/Gbsl8Ry4CCH7WqRHkicwrmxfqruxhdWLAt6aHvN0JjDY+6u9upaRv+ilhFePtueZfC9lg+3ngF/kZVa76Yi+WW7/1h3E4hZLh+KlWNVlWmDCZBVFwgBvvJgJJNusdddElKa0Y+bfGaHuo9IBJYNA5ypegQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JnlzmSHozjMLwET1RbYxMLHxZowcrs8zgGL4xQXadmI=; b=yybgc8H4TW4j2VaCByYi39cYOr5xTcF7Q/zj3HM1gQzj3LP1qqrB0YbGN0S7hNmwj2w8GWPYYe2tFHEo14AaoY3h7UEioOEr9VxRpqz/qyKv8+qbQraknH6zmqv/fqfvT8LGHpZtxNX5Y0K39vCep55S9eS8H7X249h+xNa1Beg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SN7PR12MB7275.namprd12.prod.outlook.com (2603:10b6:806:2ae::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Fri, 17 Feb 2023 14:00:47 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48%7]) with mapi id 15.20.6111.013; Fri, 17 Feb 2023 14:00:47 +0000 Message-ID: Date: Fri, 17 Feb 2023 13:59:47 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Content-Language: en-US To: Chaoyong He , dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com References: <20230217024539.16514-1-chaoyong.he@corigine.com> <20230217024539.16514-3-chaoyong.he@corigine.com> From: Ferruh Yigit Subject: Re: [PATCH 2/3] net/nfp: get rid of the usage of RTE log level type In-Reply-To: <20230217024539.16514-3-chaoyong.he@corigine.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P302CA0037.GBRP302.PROD.OUTLOOK.COM (2603:10a6:600:317::9) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SN7PR12MB7275:EE_ X-MS-Office365-Filtering-Correlation-Id: 20e655a0-c970-4701-5cf4-08db10ef5e46 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7XaTTmPHpem3GgkzJ45fNkDWVFJr8bIHdgQQb7wK0gHpzE8cDF6kn4RyvYsPvU3c5f6ZrMttdAYu3vR8Y6NYkbpjJp9sKOaKWaBp/HJvxVs0gcFh72V7hhlvx1cSMCN/Y7YFtt46uTw7Q3H8MufMNUjxIniJ6TB5FWMNEXql3XTCBpI0kLFnhovlBVljXoMeTg87y8opncSGd7MQEAHIGgq4FoGCeRWasGRKkyjNWG1sx3ZfmO7YVVx4cMOSMnyWQfAqqwS8HuFl1A90vp3+t1aehIF5x8RLUqNT8v4wZ1kjRsge4T41kWJ7DJMj1vuseAt0IwmhmKAJNEEs2OaWCb3ak74ygfK/KenCT8Izs2X53fMNNgKRw7SdJUdHzdIU5auc2oITiSlVOSn2oelCotmlEOUaAVtk8SzBVvhIHbLB70EU0IUiPyLs8yXX2Q0YHhMJN6qHu2Jju06ndhxFuj50B7Jx94fhQBPp4NZhOu8EIkyi1pXAlj6g8/9L4kjm/epbDTdSVkORnWOj4o9ZesVEgS63fLcBz3rf2yt2StVmcPsnBfJ9A+jSZ97SmXA2OY27osQtK2/ILpEL49DNNzEtQk2gXqpJuR3n/lkPK4U1lqYTJpVrjr9/rgs9j2gY/lIQ6wKZ1e3Xh3rGx2LdfJaAZx0Xl0yQlj86InysdLtf0PPDG4ZiTgVga1OSA9A8S57198zmNTdqAS+NOueum0pqTdUKkcr4ZlsE6QO1OOyFuYqSLoej7Fa/dDjn13kooX0aFa4/RpQt4CZTzPfI1A== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(136003)(396003)(39860400002)(376002)(346002)(366004)(451199018)(53546011)(2906002)(31696002)(44832011)(6512007)(2616005)(86362001)(38100700002)(8936002)(66574015)(66946007)(316002)(66556008)(66476007)(8676002)(5660300002)(36756003)(6506007)(83380400001)(4326008)(41300700001)(478600001)(186003)(26005)(6486002)(31686004)(26583001)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UDZrTHFEL0JaczVCZ3JYYk9EODE1QTV0bVhidHpMbkdwSldTdlpjYUlORjVX?= =?utf-8?B?NFpzN0pMU3o0SjdycXNiMHFyNnNIUzhnUTNEK2FVeXhzMWtrWVFSc0htcHNs?= =?utf-8?B?dDBCWjFRMVZqQnA0WFFyeE5sWG5wVVRrOUxQVm1ZbkNTMHNtbDVtclFFT3hT?= =?utf-8?B?NmxLVHJNT285OXd5anpRbnBxcHFQK2NxQUFTUHpLbUk5Yk1IaUg1dGlZc0VE?= =?utf-8?B?dEI1TFdST1gweVhJWTFrblh5dlk0c3I2MEh2djZseGxSZVQ3QVJvd1A1dmdP?= =?utf-8?B?OE5FQU5Xczl6ZnZYV0N1L1ZxbFFvdFFnaVVidHV4eHJrTGRkQVNKa0FLdzBr?= =?utf-8?B?QXlYOHZhaUhqeDhlYXVOZkVUYndCWlBTdXk2bkNhb21jRFY3QllNaFRpamtr?= =?utf-8?B?dGNSemI2VlZnS0NrMG1IV1ExSVRYQytlOTFnaG9TMWdGcWxLNVVtSHFOWEhw?= =?utf-8?B?SE5HRE82UjJrY3NrTDlvUlpycGVobTNtcDZjZEdESWl6djArUG1ScVMxTjYw?= =?utf-8?B?MWhVa2M1QUpVUWNnYzkrMnZibjZLUUVPN3V3TVRIMHRLNjBSQ3pYaEp1RXF1?= =?utf-8?B?aVNBSmp6Sk54L1ZIOXhIanF1K080TThVeUZXQmlCY2g3aElLVVRGY1J5dWhK?= =?utf-8?B?RkJDSTBQM212NDRhdngrQ1pYMWN2UzF0RS80WTVKUzJzUE5GUDJUekhDaXU4?= =?utf-8?B?ZlhXeDJJbXRUd25kOUxhTnFSWXZvRnUvMWtsd3NnL3pFOVFySjF6TENEOWs3?= =?utf-8?B?RlZEZUQ0RFA3QU9NL283ZmVxaGEyTEprdHoyTlpqQkpMMlhJNy9nUU5BMWlU?= =?utf-8?B?MVpKZlQyYmwwTFg3ajVvVkZJSER2cldXakR4L2o3TGFURXVyeTJGdTdJT2ZY?= =?utf-8?B?V1RxTW9rdUdkSTI1YTBJY09MdkpwNTNtTTFHYWhSQ1BlRWNlUWFLTkVZQnBU?= =?utf-8?B?Y0lKWjRWN0toQXA3NUR3STV4VzJJd0pUaWJaY2NqSnBvVGZkUlVwMFBkbitU?= =?utf-8?B?RlRSazZ1VkRNU29xc0hkdzlDUXU2b3dCK2UrVDJFbUFtam5jNEpuN0ZtT3lO?= =?utf-8?B?TUtOL0syRU53T1lTT1NDQmtmME1NbzBnaTh2d2w5RklrRE53OUo1TVpia2hk?= =?utf-8?B?eWhRWWhCVnNUNCs1NDRYbmVVMWJLUTI3MVVWUnplTWtzdDArbXJBZVNzeTBa?= =?utf-8?B?S29mOTNoa201WVRWVWpEbjdXUG1LRjVSR2QxY2Nva2JCanhBLytKbHhZc0Qw?= =?utf-8?B?YVg4Q1A1WC9sTXRlT2NvbGJ4SjNDbENTSEE4a0oydkhtZ1ZCUjZka0xGWm9w?= =?utf-8?B?YVR1Y0RtYmRBQUdsREc3OUR3cE42cEwvSFd0aG1ZQzFaZGREWE0wVzJ1Vk9H?= =?utf-8?B?UXJPN0pmSGNNejBScUlIazREeDBtZCtraXlLbVprU3B2dTBwRmx0Wk5NNG1E?= =?utf-8?B?blhPQzg2MUI3S3FxTnk4eVQyL1lkbmI3LzgvMWs2amo5V3BtajlncEhCQzZp?= =?utf-8?B?K281ZUc2UGZzQ3l0c2lWeXQzUitRZzY4OGh1dXdWdWVBSmxGZEt2NnRLdkVr?= =?utf-8?B?S0Y0N0RzRExlUmcyZDNDQ3JFa00xL0pIa0tpdDB4Vm5KcnBCaThVSjliZE9O?= =?utf-8?B?bWJVU1preWlEejQ4Q2FkcENiZmhyWnNNdUFhS0pMaU5sOU5wb3RoRE9xbE9o?= =?utf-8?B?b3Z1VUIxS1dMNldwSllvZlBoMWkyWXRGYm0yMmJwdStKN0h1bUZhQ2pSWUhD?= =?utf-8?B?TjV3SWVzU2pwTWpzSFptVGtENm1TamZ3YWZadHRkZjNacUZtMmJGRklEd1A5?= =?utf-8?B?T1pEY0lZUXpHSTAxNVUzN0s4NE5ZRGRCMDV6cVdiM0FZQmpjNEoxWDVMYkxk?= =?utf-8?B?bURBMHdPN1VzekUxV3pZYjFudkxNWmdhK3kzTkNVNDlueFJhRlZJaVc5UWVx?= =?utf-8?B?OHFhUU5pby8zeWtVcS91L0xOOUlIZmlBcGp3N25tbzJ1WWZMVUhmUkdwNGJj?= =?utf-8?B?QXVEYkZleDI1eTh4bHRBallRZGNvNkZYS2pGSTM0R3ZGVTdCZjdBQUJHczRJ?= =?utf-8?B?VEdBT2ZLM202K0J2enVOcThwYjUzUzltdXpyZmlkKzFCQ0RSUk5rNXhpL2h0?= =?utf-8?Q?AzTB/YaPRF7d10QRntyCKTAJi?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 20e655a0-c970-4701-5cf4-08db10ef5e46 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2023 14:00:47.1079 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2F5jW9RgF8hEcW7Ar2MgPbWYzTNZg5uamxKohZdB0DSTHkZRFJ63BEgji+inIk4q X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7275 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/17/2023 2:45 AM, Chaoyong He wrote: > Register the own RX/TX debug log level type, and get rid of the > usage of RTE_LOGTYPE_*. Then we can control the log by a independent > switch. > > Signed-off-by: Chaoyong He > Reviewed-by: Niklas Söderlund > --- > drivers/net/nfp/nfp_logs.c | 10 ++++++++++ > drivers/net/nfp/nfp_logs.h | 8 ++++++-- > 2 files changed, 16 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/nfp/nfp_logs.c b/drivers/net/nfp/nfp_logs.c > index 48c42fe53f..cd58bcee43 100644 > --- a/drivers/net/nfp/nfp_logs.c > +++ b/drivers/net/nfp/nfp_logs.c > @@ -5,6 +5,16 @@ > > #include "nfp_logs.h" > > +#include > + > RTE_LOG_REGISTER_SUFFIX(nfp_logtype_init, init, NOTICE); > RTE_LOG_REGISTER_SUFFIX(nfp_logtype_driver, driver, NOTICE); > RTE_LOG_REGISTER_SUFFIX(nfp_logtype_cpp, cpp, NOTICE); > + > +#ifdef RTE_ETHDEV_DEBUG_RX > +RTE_LOG_REGISTER_SUFFIX(nfp_logtype_rx, rx, DEBUG) > +#endif > + > +#ifdef RTE_ETHDEV_DEBUG_TX > +RTE_LOG_REGISTER_SUFFIX(nfp_logtype_tx, tx, DEBUG) > +#endif > diff --git a/drivers/net/nfp/nfp_logs.h b/drivers/net/nfp/nfp_logs.h > index b7632ee72c..315a57811c 100644 > --- a/drivers/net/nfp/nfp_logs.h > +++ b/drivers/net/nfp/nfp_logs.h > @@ -15,15 +15,19 @@ extern int nfp_logtype_init; > #define PMD_INIT_FUNC_TRACE() PMD_INIT_LOG(DEBUG, " >>") > > #ifdef RTE_ETHDEV_DEBUG_RX > +extern int nfp_logtype_rx; > #define PMD_RX_LOG(level, fmt, args...) \ > - RTE_LOG(level, PMD, "%s() rx: " fmt "\n", __func__, ## args) > + rte_log(RTE_LOG_ ## level, nfp_logtype_rx, \ > + "%s(): " fmt "\n", __func__, ## args) > #else > #define PMD_RX_LOG(level, fmt, args...) do { } while (0) > #endif > > #ifdef RTE_ETHDEV_DEBUG_TX > +extern int nfp_logtype_tx; > #define PMD_TX_LOG(level, fmt, args...) \ > - RTE_LOG(level, PMD, "%s() tx: " fmt "\n", __func__, ## args) > + rte_log(RTE_LOG_ ## level, nfp_logtype_tx, \ > + "%s(): " fmt "\n", __func__, ## args) > #else > #define PMD_TX_LOG(level, fmt, args...) do { } while (0) > #endif Intention is to replace 'RTE_LOG_DP' with 'PMD_RX_LOG'/'PMD_TX_LOG', but these are not exactly same (although difference is minor). When 'RTE_ETHDEV_DEBUG_RX' is set, ethdev layer also adds some additional load, although I believe that will small comparing to logging in driver. If 'RTE_LOG_DP' used, the ethdev layer cost can be removed. With 'RTE_LOG_DP', log level more verbose than requested won't cause any performance impact. Like if ERR level requested, INFO, DEBUG etc logs will be compiled out and won't cause any performance impact. But with 'RTE_ETHDEV_DEBUG_RX', even log level only request ERR, all logging will add cost of at least an if branch (checking log level). For many cases I am not sure these differences matters, and already many drivers directly uses 'RTE_ETHDEV_DEBUG_RX' as done here. So you may prefer to keep as it is. But if there is a desire for this fine grain approach, it is possible to add a version of 'RTE_LOG_DP' macro that accepts dynamic log type (instead of static RTE_LOGTYPE_# type), what do you think?