From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 11861A0562; Thu, 1 Apr 2021 15:15:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EBBB11412B7; Thu, 1 Apr 2021 15:15:13 +0200 (CEST) Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) by mails.dpdk.org (Postfix) with ESMTP id D1F901410BC for ; Thu, 1 Apr 2021 15:15:12 +0200 (CEST) Received: by mail-wr1-f48.google.com with SMTP id v4so1766170wrp.13 for ; Thu, 01 Apr 2021 06:15:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=xerOETyKPT1adXq912Q4UkE7Izg7oPZKVIR6d7ZdjZI=; b=sg+M5bh1MUBdPFI1E3VP2fJ55xgyzTE2lagDrreryD05raC1DqtRYxDgQBsW8ztD6q ZLY8DuXWKWZMYxvF0eJsFjawDmp43xlU+d3+tQ2avdX+LJdLJfz60F4BoRW19o5S+yZV W5uPs6m9s55vgTsN+pUmLaQz7qpZYXr+GhKTnGZcB/kpvRc46kwWayX5/njId5DMjetE IwzkYasImCptN5mxGKYKo8GGX7g2WGImJq1JOolLQnLRxK/Cbk88UMst14pQsdM9o6Ud RbO9GmVkRfSB4+ue/LOBE/xnOkhqhD1UoyR0+8bYFTNOI4bXiAXUK0Lgrja0NTHlb1fV /oog== X-Gm-Message-State: AOAM533YSMCFNArEhmwnChF2pZFxQv3iO26IZ9ViyKjAFV9tKGhqDQmf tfiQ+D5zuef4IQTMMJrmaVE= X-Google-Smtp-Source: ABdhPJzjH5AQ4iNR6hWyIS73KPHEdBHm2c0Med/bv2YHjFgV6OXQAiunHXYI8ZeY8nYsvTfZ0NZSZQ== X-Received: by 2002:adf:fcc9:: with SMTP id f9mr9612309wrs.420.1617282912611; Thu, 01 Apr 2021 06:15:12 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id d18sm10915429wra.8.2021.04.01.06.15.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Apr 2021 06:15:12 -0700 (PDT) Message-ID: From: Luca Boccassi To: Andrew Rybchenko , Bruce Richardson , dev@dpdk.org Cc: thomas@monjalon.net, david.marchand@redhat.com Date: Thu, 01 Apr 2021 14:15:11 +0100 In-Reply-To: References: <20210401115009.1063844-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.2 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [RFC PATCH 00/14] Build file update proposals X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 2021-04-01 at 15:27 +0300, Andrew Rybchenko wrote: > On 4/1/21 2:49 PM, Bruce Richardson wrote: > > This RFC contains 5 changes/updates to the DPDK build and build files. = These > > updates all assume that the minimum version for DPDK has increased to a= t least > > meson 0.49 as proposed in [1]. > >=20 > > The changes in this set are: > > 1. Use "continue" keyword, new in 0.49 to shorten and reduce indentatio= n levels > > in the foreach loops when building library or driver components. > > 2. For libraries, drop support for header-only libraries, which was add= ed just > > for the "compat" lib which had a single header, and is now part of E= AL. This > > similarly reduces indentation levels and makes the code easier to fo= llow > > 3. Since the larger blocks of meson code in our repo is seeing massive > > whitespace changes, take the opportunity to switch our indentation s= tyle for > > meson files from that of C-files using tabs, to Meson/Python style u= sing > > spaces. [More below on this for discussion] > > 4. Remove the "librte_" prefix from all our library directories. While = as useful > > cleanup, the main driver for this was that it simplifies the matchin= g for #5 > > below. > > 5. Add a "disable_libs" build option to allow the user to optionally no= t build > > certain components. Include in this an explicit list of libraries wh= ich are > > "known safe" to disable in the build. For now this is a short list o= f three > > libs, all of which are safe because they are not buildable on FreeBS= D. More > > work is needed to expand this list in future. > >=20 > > Of these changes, I expect #3 to be most controversial. The initial > > implementation of meson build for DPDK should have originally been done= using > > the correct meson style using spaces[2], but sadly it was not done that= way. If > > we are to ever change, I believe it should be now while other rework su= ch as > > this is being done. Here are the arguments for/against, as I see them. > >=20 > > Reasons to change: > > * Align with official meson style, used on other projects > > * Reduce indentation levels in code. NOTE: While not normally a conside= ration in > > programming, this is a possible issue with meson compared to C or Pyt= hon, > > because we cannot create separate functions to move inner loops to lo= wer > > indentation levels. > > * It's probably now or never. >=20 > +1 and I think it is better to do it now, not never +1, with the addendum that we should add an ignore-rev file so that git blame keeps working (needs to be done after merge, for the commit hash): https://www.moxio.com/blog/43/ignoring-bulk-change-commits-with-git-blame --=20 Kind regards, Luca Boccassi