Re: [PATCH v3 2/2] net/vmxnet3: support larger MTU with version 6

[Jochen Behrens <jochen.behrens@broadcom.com>]

Hi Morten,

thanks for fixing the MTU setting!

Acked-by: Jochen Behrens jochen.behrens@broadcom.com

On 11/4/24 02:52, Morten Brørup wrote:
> Virtual hardware version 6 supports larger max MTU, but the device
> information (dev_info) did not reflect this, so it could not be used.
> 
> Fixes: b1584dd0affe ("net/vmxnet3: support version 6")
> 
> Signed-off-by: Morten Brørup <mb@smartsharesystems.com>
> ---
> v3:
> * Moved support for larger MTU with virtual hardware version 6 to separate
>    patch. (Ferruh Yigit)
> ---
>   drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c
> index 8a9bb452c6..1752c58069 100644
> --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c
> +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c
> @@ -1574,7 +1574,7 @@ vmxnet3_dev_info_get(struct rte_eth_dev *dev,
>   	dev_info->min_rx_bufsize = 1518 + RTE_PKTMBUF_HEADROOM;
>   	dev_info->max_rx_pktlen = 16384; /* includes CRC, cf MAXFRS register */
>   	dev_info->min_mtu = VMXNET3_MIN_MTU;
> -	dev_info->max_mtu = VMXNET3_MAX_MTU;
> +	dev_info->max_mtu = VMXNET3_VERSION_GE_6(hw) ? VMXNET3_V6_MAX_MTU : VMXNET3_MAX_MTU;
>   	dev_info->speed_capa = RTE_ETH_LINK_SPEED_10G;
>   	dev_info->max_mac_addrs = VMXNET3_MAX_MAC_ADDRS;
>   

-- 
This electronic communication and the information and any files transmitted 
with it, or attached to it, are confidential and are intended solely for 
the use of the individual or entity to whom it is addressed and may contain 
information that is confidential, legally privileged, protected by privacy 
laws, or otherwise restricted from disclosure to anyone else. If you are 
not the intended recipient or the person responsible for delivering the 
e-mail to the intended recipient, you are hereby notified that any use, 
copying, distributing, dissemination, forwarding, printing, or copying of 
this e-mail is strictly prohibited. If you received this e-mail in error, 
please return the e-mail to the sender, delete it from your computer, and 
destroy any printed copy of it.