From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1FCD645C7F; Mon, 4 Nov 2024 22:44:21 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1674540281; Mon, 4 Nov 2024 22:44:19 +0100 (CET) Received: from mail-qk1-f171.google.com (mail-qk1-f171.google.com [209.85.222.171]) by mails.dpdk.org (Postfix) with ESMTP id 89B1B4025F for ; Mon, 4 Nov 2024 22:44:16 +0100 (CET) Received: by mail-qk1-f171.google.com with SMTP id af79cd13be357-7b15d330ce1so379699785a.1 for ; Mon, 04 Nov 2024 13:44:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1730756656; x=1731361456; darn=dpdk.org; h=content-transfer-encoding:content-language:in-reply-to:from :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=SiI+XAejNza8+es7yu5yiSwMckZLHPeWTnxgjLAX2qA=; b=fJ/20sbht+c3YDBGRcyX9y6oVhhxhMPSdQVsK3h6Bbn5TVHDKprCvdNlMeWEtxyAea ll0GJ2QOS8Xys+yURjG1bT2Qv4XCg3SGipmnuMWuIAZkRQJJWJohpbuliEbYTVXAzETv ZN8pLYk6qrjSeVB4D4KGpRANNnQn18+MQzu2w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730756656; x=1731361456; h=content-transfer-encoding:content-language:in-reply-to:from :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SiI+XAejNza8+es7yu5yiSwMckZLHPeWTnxgjLAX2qA=; b=u7G3+fUc1SwYTIqSP/r7mx3RySgr8U/0OUumoKJVahPfKlEfKvzpKkhp9RF2Mhc2/f 6RAoL15SQ/1uaZzno3jqxNl+PetTeOEqfnQftLJfdetxm0guuVOJ6PQBnUSKkXUT9xqq oQblN6ZksjpG2Re2BGFjE6/17CVeneMn7pp9BO1wRYfpmnlvqEPIFHHi6RoFDg/q+XoJ OkUEPJZtYKNcSsPaIhTys7sZfnPxZyTeadsNrzeUn2blgDpKFiAIjT4hA0WzT1ZA8jnV W4haJkXEAIthuzZmmaNRWG/rRcLJnSV+h7z27NJ/5JcVmwZ5ysO1k2L/chSFt7BXcTFk qPLQ== X-Forwarded-Encrypted: i=1; AJvYcCX+8a+RYM99RpyimzHLFRXP+GUe4ud1QfuYX3FUuNCDvaR5gPGiT8wiepOwOBSoGMxEQtM=@dpdk.org X-Gm-Message-State: AOJu0Yx/bRd0g4w94yYBzEO1uUhSmGpDD8mUQd0jzuIbSgtDMmkwYMJi Y1Rqu6rJKf9YNcn3DpmiiX+VqCEkiGPQjnLNB4+ztNTR2RurNYC/CrjOa7ErbKYnmlDd3AN72iV 9oOxXvm63CSiGEWHaCsuVHAkXKC6oeg== X-Google-Smtp-Source: AGHT+IH0Z1CKTG3TYptWPcXasLCygPlkg0R+0NX1k/l4F6flRIaBUwkyzFJkdhYV2BT60SZnNH/FgA== X-Received: by 2002:a05:620a:444a:b0:7b1:45be:2e8e with SMTP id af79cd13be357-7b2f24dcd88mr2445212785a.17.1730756655788; Mon, 04 Nov 2024 13:44:15 -0800 (PST) Received: from [10.211.13.61] ([216.221.25.44]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7b2f3a6fd92sm458499985a.84.2024.11.04.13.44.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Nov 2024 13:44:15 -0800 (PST) Message-ID: Date: Mon, 4 Nov 2024 13:44:13 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/2] net/vmxnet3: support larger MTU with version 6 To: =?UTF-8?Q?Morten_Br=C3=B8rup?= , dev@dpdk.org, Ferruh Yigit , Ronak Doshi References: <20241024110129.791362-1-mb@smartsharesystems.com> <20241104105220.1421305-1-mb@smartsharesystems.com> <20241104105220.1421305-2-mb@smartsharesystems.com> From: Jochen Behrens In-Reply-To: <20241104105220.1421305-2-mb@smartsharesystems.com> Content-Language: en-US Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Morten, thanks for fixing the MTU setting! Acked-by: Jochen Behrens jochen.behrens@broadcom.com On 11/4/24 02:52, Morten Br=C3=B8rup wrote: > Virtual hardware version 6 supports larger max MTU, but the device > information (dev_info) did not reflect this, so it could not be used. >=20 > Fixes: b1584dd0affe ("net/vmxnet3: support version 6") >=20 > Signed-off-by: Morten Br=C3=B8rup > --- > v3: > * Moved support for larger MTU with virtual hardware version 6 to separat= e > patch. (Ferruh Yigit) > --- > drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/v= mxnet3_ethdev.c > index 8a9bb452c6..1752c58069 100644 > --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c > +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c > @@ -1574,7 +1574,7 @@ vmxnet3_dev_info_get(struct rte_eth_dev *dev, > dev_info->min_rx_bufsize =3D 1518 + RTE_PKTMBUF_HEADROOM; > dev_info->max_rx_pktlen =3D 16384; /* includes CRC, cf MAXFRS register= */ > dev_info->min_mtu =3D VMXNET3_MIN_MTU; > - dev_info->max_mtu =3D VMXNET3_MAX_MTU; > + dev_info->max_mtu =3D VMXNET3_VERSION_GE_6(hw) ? VMXNET3_V6_MAX_MTU : V= MXNET3_MAX_MTU; > dev_info->speed_capa =3D RTE_ETH_LINK_SPEED_10G; > dev_info->max_mac_addrs =3D VMXNET3_MAX_MAC_ADDRS; > =20 --=20 This electronic communication and the information and any files transmitted= =20 with it, or attached to it, are confidential and are intended solely for=20 the use of the individual or entity to whom it is addressed and may contain= =20 information that is confidential, legally privileged, protected by privacy= =20 laws, or otherwise restricted from disclosure to anyone else. If you are=20 not the intended recipient or the person responsible for delivering the=20 e-mail to the intended recipient, you are hereby notified that any use,=20 copying, distributing, dissemination, forwarding, printing, or copying of= =20 this e-mail is strictly prohibited. If you received this e-mail in error,= =20 please return the e-mail to the sender, delete it from your computer, and= =20 destroy any printed copy of it.