Re: [dpdk-dev] [PATCH v4] net/ixgbe: fix filter parser error in L2 tunnel

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 11/3/2017 1:38 AM, Peng, Yuan wrote:
> Tested-by: Peng Yuan <yuan.peng@intel.com>

Hi Yuan,

Thanks for the testing.

And related to the "Tested-by" tag, since it has also contains code patchwork
thinks this is a new patch [1].

This both requires someone updating patchwork and mark that patch as invalid,
and since "Tested-by" is not seen by old patch, requires to manually inserting
this tag into commit.

And we don't prefer top posting in mail list.

so to prevent above issues, would you mind changing how you send the test tag:

In the original patch _remove everything_ below tags (Signed-off-by and similar
ones) and put your tag and details _below_ those lines.


Sample:

"
xxx: fix yyyy

Some commit log.

Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
Acked-by: Wei Dai <wei.dai@intel.com>
---

<put some c code here>

"

When you want to reply to above, it will become:

"
> xxx: fix yyyy
>
> Some commit log.
>
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> Acked-by: Wei Dai <wei.dai@intel.com>

Tested-by: Yuan Peng <yuan.peng@intel.com>

<some test details>
"

And can you please spread the word to the other members of the test team who are
sending test reports?


One minor thing, we use "Name Surname <lowercase.mail@address.com>" format, so
your tag needs to be:
Tested-by: Yuan Peng <yuan.peng@intel.com>

Although this is minor someone needs to fix it if you send the reverse.

Thanks,
ferruh

[1]
http://dpdk.org/dev/patchwork/patch/31152/


> 
> - Tested Branch: dpdk-master
> - Tested Commit: commit 6fb00f8baefa03b9cfd1b2dfc1787258b8459601
> - OS: 4.8.6-300.fc25.x86_64
> - GCC: gcc (GCC) 6.4.1 20170727 (Red Hat 6.4.1-1)
> - CPU: Intel(R) Xeon(R) CPU D-1541 @ 2.10GHz
> - NIC: X552/X557-AT 10GBASE-T [8086:15ad]
> - Default x86_64-native-linuxapp-gcc configuration
> - Prerequisites:
> - Total 1 cases, 1 passed, 0 failed
> 
> Hardware:
> dut: 10.240.176.192
>  tester: 10.240.176.191
>  X552/X557-AT 10g*2
> 
> Test steps:
> 
> Bind pf to igb_uio:
> ./usertools/dpdk-devbind.py -b igb_uio 03:00.0
> 
> add two vfs on dpdk pf, then bind the vfs to vfio-pci:
>  echo 2 >/sys/bus/pci/devices/0000:03:00.0/max_vfs
>  ./usertools/dpdk-devbind.py -b vfio-pci 03:10.0 03:10.2
> 
> Start testpmd:
> ./x86_64-native-linuxapp-gcc/app/testpmd -c 1f -n 4 -m 1024 -w 03:00.0 --file-prefix=pf - -i --rxq=4 --txq=4 
> testpmd> set fwd rxonly
> testpmd> set verbose 1
> testpmd> start
> testpmd> port config 0 l2-tunnel E-tag enable
> testpmd> E-tag set forwarding on port 0
> 
> ./x86_64-native-linuxapp-gcc/app/testpmd -c 0xf0 -n 4 -w 03:10.0 --file-prefix=vf0 -m 1024 - -i --rxq=4 --txq=4 --disable-rss 
> testpmd> set fwd rxonly
> testpmd> set verbose 1
> testpmd> start
> ./x86_64-native-linuxapp-gcc/app/testpmd -c 0xf00 -n 4 -w 03:10.2 --file-prefix=vf1 -m 1024 - -i --rxq=4 --txq=4 --disable-rss  
> testpmd> set fwd rxonly
> testpmd> set verbose 1
> testpmd> start
> 
> 1. create filter rules,
> testpmd> flow create 0 ingress pattern e_tag grp_ecid_b is 0x1309 / end actions vf id 0 / end  
> Flow rule #0 created  
> testpmd> flow create 0 ingress pattern e_tag grp_ecid_b is 0x1308 / end actions vf id 1 / end  
> Flow rule #1 created
> testpmd> flow create 0 ingress pattern e_tag grp_ecid_b is 0x1307 / end actions pf / end
> Flow rule #2 created
> 
> 2. send packets:
> pkt1 = Ether(dst="00:11:22:33:44:55")/Dot1BR(GRP=0x1, ECIDbase=0x309)/Raw('x' * 20)
> pkt2 = Ether(dst="00:11:22:33:44:55")/Dot1BR(GRP=0x1, ECIDbase=0x308)/Raw('x' * 20)
> pkt3 = Ether(dst="00:11:22:33:44:55")/Dot1BR(GRP=0x1, ECIDbase=0x307)/Raw('x' * 20)
> pkt4 = Ether(dst="00:11:22:33:44:55")/Dot1BR(GRP=0x2, ECIDbase=0x309)/Raw('x' * 20)
> 
> verify pkt1 to vf0 queue0, pkt2 to vf1 queue0, pkt3 to pf queue 0, pkt4 can't received by pf and vfs.
> 

<...>