From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 54B6FA0C47;
	Thu,  7 Oct 2021 12:20:55 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 1862E4114F;
	Thu,  7 Oct 2021 12:20:55 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id D697141137
 for <dev@dpdk.org>; Thu,  7 Oct 2021 12:20:52 +0200 (CEST)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 4CDCB7F502;
 Thu,  7 Oct 2021 13:20:52 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 4CDCB7F502
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1633602052;
 bh=5oQuaVgIejW2dAcOMOQW6iGBuo7wHuNgJScsy8yiopI=;
 h=Subject:To:Cc:References:From:Date:In-Reply-To;
 b=X8SXc3HseoOZ6UbxhF2wITeZHV/UywmKw7j1rFuwMlprPLgZnaHZO5NWs/7fIVRNQ
 eaiKso6g1l/TF+UqoQngSaCUZR5Mp8+WfdpvxVgP3oKuVJrnXKwae6MDLU8WazNIiN
 fWCyfPNjYbJXnhnwNalFlGJggO69fpscwYYpROJ8=
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Ajit Khaparde <ajit.khaparde@broadcom.com>,
 Somnath Kotur <somnath.kotur@broadcom.com>, John Daley <johndale@cisco.com>,
 Hyong Youb Kim <hyonkim@cisco.com>, Beilei Xing <beilei.xing@intel.com>,
 Qiming Yang <qiming.yang@intel.com>, Qi Zhang <qi.z.zhang@intel.com>,
 Haiyue Wang <haiyue.wang@intel.com>, Matan Azrad <matan@nvidia.com>,
 Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
 Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org,
 Viacheslav Galaktionov <viacheslav.galaktionov@oktetlabs.ru>
References: <20210712161747.958019-1-andrew.rybchenko@oktetlabs.ru>
 <20210913112633.2836730-1-andrew.rybchenko@oktetlabs.ru>
 <14586794.58kHr3nmNG@thomas>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
Message-ID: <f9adb934-9ddd-f64c-c94a-fe3a17e47b4c@oktetlabs.ru>
Date: Thu, 7 Oct 2021 13:20:52 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <14586794.58kHr3nmNG@thomas>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v5] ethdev: fix representor port ID search by
 name
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10/6/21 12:56 AM, Thomas Monjalon wrote:
> 13/09/2021 13:26, Andrew Rybchenko:
>> From: Viacheslav Galaktionov <viacheslav.galaktionov@oktetlabs.ru>
>>
>> Getting a list of representors from a representor does not make sense.
>> Instead, a parent device should be used.
> 
> I don't understand which issue it is fixing.
> This function was not working before if not using the backer port?

The function, rte_eth_representor_id_get(), is used in
eth_representor_cmp() which is required in ethdev class
iterator to search ethdev port ID by name (representor case).
Before the patch the function is called on the representor
itself it tries to get representors info to match.

It was found by OvS+DPDK testing:
 1. OvS hotplugs representor
 2. OvS tries to find DPDK port ID for just hotplugged
    representor and fails (if PMD does not provider
    representors info on the representor itself)

> Is it fixing a specific PMD?

It is a generic fix for PMD which do *not* provide representors
info on the representor itself.